Skip to content

Commit c190d47

Browse files
committed
feat(e2e): run dify only on linux and add OS selection to skill
- Add exclude rule for dify on windows-latest - Update add-ecosystem-ci skill to prompt for OS selection (both/ubuntu-only/windows-only)
1 parent eb05081 commit c190d47

2 files changed

Lines changed: 27 additions & 1 deletion

File tree

.claude/skills/add-ecosystem-ci/SKILL.md

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ Ask the user:
2828
- Which directory contains the main package.json? (root or subdirectory)
2929
- What Node.js version to use? (22 or 24)
3030
- Which commands to run? (e.g., lint, build, test, type-check)
31+
- Which OS to run on? (both, ubuntu-only, windows-only) - default: both
3132

3233
## Step 3: Update Files
3334

@@ -62,8 +63,29 @@ Test the clone locally:
6263
node ecosystem-ci/clone.ts project-name
6364
```
6465

66+
3. **Add OS exclusion to `.github/workflows/e2e-test.yml`** (if not running on both):
67+
68+
For ubuntu-only:
69+
70+
```yaml
71+
exclude:
72+
- os: windows-latest
73+
project:
74+
name: project-name
75+
```
76+
77+
For windows-only:
78+
79+
```yaml
80+
exclude:
81+
- os: ubuntu-latest
82+
project:
83+
name: project-name
84+
```
85+
6586
## Important Notes
6687
6788
- The `directory` field is optional - only add it if the package.json is not in the project root
6889
- If `directory` is specified in repo.json, it must also be specified in the workflow matrix
6990
- `patch-project.ts` automatically handles running `vite migrate` in the correct directory
91+
- OS exclusions are added to the existing `exclude` section in the workflow matrix

.github/workflows/e2e-test.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,12 +235,16 @@ jobs:
235235
command: |
236236
vite run type-check:tsgo
237237
vite run build
238-
vite run test
238+
vite run test navigation-utils.test.ts real-browser-flicker.test.tsx workflow-parallel-limit.test.tsx
239239
exclude:
240240
# frm-stack uses Docker (testcontainers) which doesn't work the same way on Windows
241241
- os: windows-latest
242242
project:
243243
name: frm-stack
244+
# dify only runs on Linux for now
245+
- os: windows-latest
246+
project:
247+
name: dify
244248

245249
steps:
246250
- uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1

0 commit comments

Comments
 (0)