clean up

Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>

Author: connortsui20

benchmarks/compress-bench/src/main.rs

@@ -70,13 +70,19 @@ struct Args {
     output_path: Option<PathBuf>,
     #[arg(long)]
     tracing: bool,
+    /// Format for the primary stderr log sink. `text` is the default human-readable format;
+    /// `json` emits one JSON object per event, suitable for piping into `jq`.
+    ///
+    /// See [`LogFormat`] for the full details.
+    #[arg(long, value_enum, default_value_t = LogFormat::Text)]
+    log_format: LogFormat,
 }
 
 #[tokio::main]
 async fn main() -> anyhow::Result<()> {
     let args = Args::parse();
 
-    setup_logging_and_tracing(args.verbose, args.tracing, LogFormat::Text)?;
+    setup_logging_and_tracing(args.verbose, args.tracing, args.log_format)?;
 
     run_compress(
         args.iterations,

vortex-bench/src/bin/data-gen.rs

@@ -38,8 +38,9 @@ struct Args {
     #[arg(long)]
     tracing: bool,
 
-    /// Format for the primary stderr log sink. `text` is the default human
-    /// readable format; `json` emits newline-delimited JSON suitable for `jq`.
+    /// Format for the primary stderr log sink. `text` is the default
+    /// human-readable format; `json` emits one JSON object per event, suitable
+    /// for piping into `jq`. See [`LogFormat`] for the full details.
     #[arg(long, value_enum, default_value_t = LogFormat::Text)]
     log_format: LogFormat,
 

vortex-btrblocks/Cargo.toml

@@ -20,7 +20,7 @@ num-traits = { workspace = true }
 pco = { workspace = true, optional = true }
 rand = { workspace = true }
 rustc-hash = { workspace = true }
-tracing = { workspace = true, features = ["std", "attributes"] }
+tracing = { workspace = true }
 vortex-alp = { workspace = true }
 vortex-array = { workspace = true }
 vortex-buffer = { workspace = true }

vortex-btrblocks/src/canonical_compressor.rs

@@ -39,23 +39,9 @@ pub struct BtrBlocksCompressor(
 impl BtrBlocksCompressor {
     /// Compresses an array using BtrBlocks-inspired compression.
     ///
-    /// This call is instrumented with a `vortex_compressor::cascade` span named
-    /// `BtrBlocksCompressor::compress` so that downstream tracing consumers
-    /// (e.g. `tracing-perfetto`) have a distinct entry frame to pivot on, nested
-    /// above the generic [`CascadingCompressor::compress`] span that actually
-    /// runs the pipeline. See the `Observability` section of the
-    /// [`vortex_compressor`] crate docs for the full tracing reference.
-    #[tracing::instrument(
-        target = "vortex_compressor::cascade",
-        name = "BtrBlocksCompressor::compress",
-        level = "trace",
-        skip_all,
-        fields(
-            len = array.len(),
-            nbytes = array.nbytes(),
-            dtype = %array.dtype(),
-        ),
-    )]
+    /// This is a thin delegate to [`CascadingCompressor::compress`], which owns the tracing
+    /// instrumentation. See the `Observability` section of the [`vortex_compressor`] crate
+    /// docs for the full tracing reference.
     pub fn compress(&self, array: &ArrayRef) -> VortexResult<ArrayRef> {
         self.0.compress(array)
     }

vortex-btrblocks/src/lib.rs

@@ -54,14 +54,10 @@
 //!
 //! # Observability
 //!
-//! [`BtrBlocksCompressor`] participates in the [`vortex_compressor`] tracing target system.
-//! See the [`vortex_compressor` crate docs](vortex_compressor#observability) for the full
-//! reference on targets, spans, and events.
-//!
-//! The top-level [`BtrBlocksCompressor::compress`] call adds its own
-//! `vortex_compressor::cascade` span (named `BtrBlocksCompressor::compress`) that nests
-//! above the generic cascading-compressor pipeline, giving downstream trace consumers a
-//! distinct entry frame.
+//! [`BtrBlocksCompressor`] is a thin delegate to [`CascadingCompressor`], which owns all
+//! tracing instrumentation. See the
+//! [`vortex_compressor` crate docs](vortex_compressor#observability) for the full reference
+//! on targets, spans, and events.
 //!
 //! Quick start — one line per leaf with scheme, estimated ratio, actual ratio, accepted?:
 //!