Implement compare/between for bitpacked arrays - improve performance by up to 2X by AdamGS · Pull Request #7279 · vortex-data/vortex

AdamGS · 2026-04-03T16:36:44Z

After some iterations, this seems to improve performance in any case we actually measure. It does require merging and releasing spiraldb/fastlanes#125.

codspeed-hq · 2026-04-03T16:42:32Z

Merging this PR will degrade performance by 10.6%

⚠️

Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 20 improved benchmarks
❌ 2 regressed benchmarks
✅ 1108 untouched benchmarks
⏩ 33 skipped benchmarks¹

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Mode	Benchmark	`BASE`	`HEAD`	Efficiency
⚡	Simulation	`new_alp_prim_test_between[f64, 32768]`	250.6 µs	117.6 µs	×2.1
⚡	Simulation	`new_bp_prim_test_between[i16, 16384]`	89.1 µs	63.4 µs	+40.56%
⚡	Simulation	`new_alp_prim_test_between[f64, 2048]`	71.6 µs	54.8 µs	+30.57%
⚡	Simulation	`new_bp_prim_test_between[i16, 32768]`	134.1 µs	91.6 µs	+46.46%
⚡	Simulation	`patched_take_10k_adversarial`	258.4 µs	228.4 µs	+13.14%
⚡	Simulation	`new_bp_prim_test_between[i16, 2048]`	51.9 µs	39.8 µs	+30.53%
⚡	Simulation	`new_bp_prim_test_between[i64, 2048]`	62.7 µs	45 µs	+39.35%
⚡	Simulation	`new_bp_prim_test_between[i32, 32768]`	168.6 µs	97.1 µs	+73.67%
⚡	Simulation	`new_bp_prim_test_between[i64, 16384]`	143.2 µs	72.6 µs	+97.23%
⚡	Simulation	`new_bp_prim_test_between[i64, 32768]`	236 µs	101.8 µs	×2.3
⚡	Simulation	`new_bp_prim_test_between[i32, 2048]`	53.5 µs	40 µs	+33.95%
⚡	Simulation	`take_10k_dispersed`	284.4 µs	239.6 µs	+18.67%
⚡	Simulation	`take_10k_first_chunk_only`	270.4 µs	225.8 µs	+19.75%
⚡	Simulation	`new_bp_prim_test_between[i32, 16384]`	108.1 µs	68 µs	+59.11%
❌	Simulation	`patched_take_10k_contiguous_patches`	258.3 µs	287.1 µs	-10.02%
⚡	Simulation	`patched_take_10k_dispersed`	315.5 µs	285.3 µs	+10.59%
⚡	Simulation	`patched_take_10k_first_chunk_only`	301.9 µs	271.8 µs	+11.07%
⚡	Simulation	`new_alp_prim_test_between[f64, 16384]`	155.1 µs	84.7 µs	+83.11%
⚡	Simulation	`new_alp_prim_test_between[f32, 2048]`	60.8 µs	50.3 µs	+20.89%
⚡	Simulation	`new_alp_prim_test_between[f32, 32768]`	168.8 µs	111.7 µs	+51.11%
...	...	...	...	...	...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

_{Comparing adamg/bitpack-compare (dbfb7c2) with develop (ac8c751)}

33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

github-actions · 2026-04-03T18:26:45Z

Polar Signals Profiling Results

Latest Run

Status	Commit	Job	Attempt	Link
🟢 Done	`9177626`		1	Explore Profiling Data

Previous Runs (9)

Status	Commit	Attempt	Link
🟢 Done	`083b4b4`	1	Explore Profiling Data
🟢 Done	`54608c5`	2	Explore Profiling Data
🟢 Done	`dbe5a37`	2	Explore Profiling Data
🟢 Done	`54608c5`	1	Explore Profiling Data
🟢 Done	`dbe5a37`	1	Explore Profiling Data
🟢 Done	`db42e44`	2	Explore Profiling Data
🟢 Done	`db42e44`	1	Explore Profiling Data
🟢 Done	`00d6bc4`	1	Explore Profiling Data
🟢 Done	`abd15b8`	1	Explore Profiling Data

Powered by Polar Signals Cloud

github-actions · 2026-04-03T18:27:43Z

🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨

Benchmark PolarSignals Profiling failed! Check the workflow run for details.

github-actions · 2026-04-03T18:28:02Z

🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨

Benchmark TPC-H SF=1 on NVME failed! Check the workflow run for details.

github-actions · 2026-04-03T18:28:53Z

🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨

Benchmark FineWeb NVMe failed! Check the workflow run for details.

github-actions · 2026-04-03T18:31:47Z

🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨

Benchmark TPC-DS SF=1 on NVME failed! Check the workflow run for details.

github-actions · 2026-04-03T18:32:44Z

🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨

Benchmark TPC-H SF=10 on NVME failed! Check the workflow run for details.

github-actions · 2026-04-03T18:38:19Z

🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨

Benchmark Statistical and Population Genetics failed! Check the workflow run for details.

github-actions · 2026-04-03T18:39:38Z

🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨

Benchmark Clickbench on NVME failed! Check the workflow run for details.

github-actions · 2026-04-03T18:40:45Z

🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨

Benchmark FineWeb S3 failed! Check the workflow run for details.

github-actions · 2026-04-03T18:41:15Z

🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨

Benchmark TPC-H SF=1 on S3 failed! Check the workflow run for details.

github-actions · 2026-04-03T19:23:34Z

🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨

Benchmark TPC-H SF=10 on S3 failed! Check the workflow run for details.

a10y · 2026-04-09T14:54:21Z

+        array.len(),
+        array.offset(),
+        |bit_width, packed_chunk, chunk_matches| unsafe {
+            U::unchecked_unpack_cmp(bit_width, packed_chunk, chunk_matches, compare, value);


is the crux of this that we fuse unpacking with comparison op and avoid the second allocation/scan?

ye, you save a lot on mem bandwidth, esp. for wider types

TIL that we had fused cmp in fastlanes crate this whole time

We lacked a good way to manage fused exection, I think now we have a bit of a better mechanism

AdamGS · 2026-04-22T12:51:10Z

@joseph-isaacs do we have an accepted way of measuring code size?

AdamGS · 2026-04-22T12:58:48Z

Main difference in build time is that vortex-fastlanes jumps from ~15 seconds to almost 50 (from 9th slowest crate to 2nd), command was cargo build -p vortex --release --timings --all-features.

While this isn't great for our local experience, I think it'll still parallelize fine with other heavy dependencies, and its pretty similar to what users will experience if they pull something like DF (which has multiple crates that takes 50-60 seconds to build)

Signed-off-by: Adam Gutglick <adam@spiraldb.com>

joseph-isaacs · 2026-04-27T16:57:06Z

Diff size of and bin using this with and without the compare+bitpack

AdamGS added the changelog/performance A performance improvement label Apr 3, 2026

AdamGS force-pushed the adamg/bitpack-compare branch from 74732ef to 8cddde0 Compare April 3, 2026 16:45

AdamGS added the action/benchmark-sql Trigger SQL benchmarks to run on this PR label Apr 3, 2026

github-actions Bot removed the action/benchmark-sql Trigger SQL benchmarks to run on this PR label Apr 3, 2026

AdamGS added the action/benchmark-sql Trigger SQL benchmarks to run on this PR label Apr 3, 2026

github-actions Bot removed the action/benchmark-sql Trigger SQL benchmarks to run on this PR label Apr 3, 2026

AdamGS added the action/benchmark-sql Trigger SQL benchmarks to run on this PR label Apr 3, 2026

github-actions Bot removed the action/benchmark-sql Trigger SQL benchmarks to run on this PR label Apr 3, 2026

AdamGS force-pushed the adamg/bitpack-compare branch 2 times, most recently from a103738 to 4454bc6 Compare April 3, 2026 20:26

AdamGS changed the title ~~Try to implement compare/between for bitpacked arrays~~ Implement compare/between for bitpacked arrays - improve performance by up to 2X Apr 3, 2026

AdamGS requested review from gatesn and joseph-isaacs April 3, 2026 21:03

AdamGS force-pushed the adamg/bitpack-compare branch 2 times, most recently from 52289bf to dbe5a37 Compare April 3, 2026 21:29

AdamGS added the action/benchmark Trigger full benchmarks to run on this PR label Apr 3, 2026

github-actions Bot removed the action/benchmark Trigger full benchmarks to run on this PR label Apr 3, 2026

AdamGS force-pushed the adamg/bitpack-compare branch from dbe5a37 to 33e6d30 Compare April 3, 2026 21:40

a10y reviewed Apr 9, 2026

View reviewed changes

AdamGS force-pushed the adamg/bitpack-compare branch 5 times, most recently from fc2ad24 to 083b4b4 Compare April 22, 2026 15:45

AdamGS added the action/benchmark Trigger full benchmarks to run on this PR label Apr 22, 2026

github-actions Bot removed the action/benchmark Trigger full benchmarks to run on this PR label Apr 22, 2026

AdamGS added 12 commits April 24, 2026 09:59

Try to implement compare/between for bitpacked arrays

02ee0fe

Signed-off-by: Adam Gutglick <adam@spiraldb.com>

Use patched version

6bb7e33

Signed-off-by: Adam Gutglick <adam@spiraldb.com>

why not

30b42dd

Signed-off-by: Adam Gutglick <adam@spiraldb.com>

reuse

3f1e69a

Signed-off-by: Adam Gutglick <adam@spiraldb.com>

public APIs

df7ac92

Signed-off-by: Adam Gutglick <adam@spiraldb.com>

fix

681ee8d

Signed-off-by: Adam Gutglick <adam@spiraldb.com>

vroom vroom

ad4072d

Signed-off-by: Adam Gutglick <adam@spiraldb.com>

better

97923ab

Signed-off-by: Adam Gutglick <adam@spiraldb.com>

last thing

267c260

Signed-off-by: Adam Gutglick <adam@spiraldb.com>

another update

64c62ce

Signed-off-by: Adam Gutglick <adam@spiraldb.com>

update2

37940b4

Signed-off-by: Adam Gutglick <adam@spiraldb.com>

Fix tests

695ce82

Signed-off-by: Adam Gutglick <adam@spiraldb.com>

AdamGS force-pushed the adamg/bitpack-compare branch from 083b4b4 to 695ce82 Compare April 24, 2026 08:59

refresh

9177626

Signed-off-by: Adam Gutglick <adam@spiraldb.com>

AdamGS added the action/benchmark-sql Trigger SQL benchmarks to run on this PR label Apr 24, 2026

github-actions Bot removed the action/benchmark-sql Trigger SQL benchmarks to run on this PR label Apr 24, 2026

joseph-isaacs added the action/benchmark Trigger full benchmarks to run on this PR label Apr 28, 2026

Merge branch 'develop' into adamg/bitpack-compare

dbfb7c2

github-actions Bot removed the action/benchmark Trigger full benchmarks to run on this PR label Apr 28, 2026

Conversation

AdamGS commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codspeed-hq Bot commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will degrade performance by 10.6%

Performance Changes

Footnotes

Uh oh!

github-actions Bot commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Polar Signals Profiling Results

Latest Run

Uh oh!

github-actions Bot commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨

Uh oh!

github-actions Bot commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨

Uh oh!

github-actions Bot commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨

Uh oh!

github-actions Bot commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨

Uh oh!

github-actions Bot commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨

Uh oh!

github-actions Bot commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨

Uh oh!

github-actions Bot commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨

Uh oh!

github-actions Bot commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨

Uh oh!

github-actions Bot commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨

Uh oh!

github-actions Bot commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨

Uh oh!

a10y Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

joseph-isaacs Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

a10y Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

robert3005 Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

AdamGS commented Apr 22, 2026

Uh oh!

AdamGS commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joseph-isaacs commented Apr 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

AdamGS commented Apr 3, 2026 •

edited

Loading

codspeed-hq Bot commented Apr 3, 2026 •

edited

Loading

github-actions Bot commented Apr 3, 2026 •

edited

Loading

github-actions Bot commented Apr 3, 2026 •

edited

Loading

github-actions Bot commented Apr 3, 2026 •

edited

Loading

github-actions Bot commented Apr 3, 2026 •

edited

Loading

github-actions Bot commented Apr 3, 2026 •

edited

Loading

github-actions Bot commented Apr 3, 2026 •

edited

Loading

github-actions Bot commented Apr 3, 2026 •

edited

Loading

github-actions Bot commented Apr 3, 2026 •

edited

Loading

github-actions Bot commented Apr 3, 2026 •

edited

Loading

github-actions Bot commented Apr 3, 2026 •

edited

Loading

github-actions Bot commented Apr 3, 2026 •

edited

Loading

joseph-isaacs Apr 9, 2026 •

edited

Loading

AdamGS commented Apr 22, 2026 •

edited

Loading