Don't use SharedArray for dict values#8299
Draft
myrrc wants to merge 1 commit into
Draft
Conversation
myrrc
added
action/benchmark
github-actions
Bot
removed
the
action/benchmark
Contributor
Polar Signals Profiling ResultsLatest Run
Previous Runs (1)
Powered by Polar Signals Cloud |
Contributor
Benchmarks: PolarSignals ProfilingVortex (geomean): 1.027x ➖ How to read Verdict and Engines
datafusion / vortex-file-compressed (1.027x ➖, 1↑ 2↓)
No file size changes detected. |
Contributor
🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨Benchmark |
Merging this PR will not alter performance
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | compare[63] |
244.6 µs | 360.3 µs | -32.12% |
| ❌ | Simulation | compare[56] |
229.5 µs | 332.1 µs | -30.89% |
| ❌ | Simulation | compare[62] |
254.7 µs | 368.6 µs | -30.89% |
| ❌ | Simulation | compare[60] |
248.2 µs | 358.2 µs | -30.72% |
| ❌ | Simulation | compare[61] |
255.4 µs | 367.3 µs | -30.48% |
| ❌ | Simulation | compare[58] |
245.5 µs | 351.9 µs | -30.23% |
| ❌ | Simulation | compare[59] |
250.9 µs | 359.2 µs | -30.14% |
| ❌ | Simulation | compare[57] |
246 µs | 350.5 µs | -29.81% |
| ❌ | Simulation | compare[54] |
235.9 µs | 334.8 µs | -29.54% |
| ❌ | Simulation | compare[55] |
241.5 µs | 342.3 µs | -29.45% |
| ❌ | Simulation | compare[52] |
229.9 µs | 325.1 µs | -29.28% |
| ❌ | Simulation | compare[48] |
212.2 µs | 299.9 µs | -29.26% |
| ❌ | Simulation | compare[53] |
236 µs | 333 µs | -29.14% |
| ❌ | Simulation | compare[50] |
227 µs | 318.5 µs | -28.72% |
| ❌ | Simulation | compare[51] |
232.1 µs | 325.4 µs | -28.69% |
| ❌ | Simulation | compare[49] |
227.3 µs | 317 µs | -28.28% |
| ❌ | Simulation | compare[47] |
222.6 µs | 308.5 µs | -27.84% |
| ❌ | Simulation | compare[46] |
217.8 µs | 301.8 µs | -27.83% |
| ❌ | Simulation | compare[44] |
211.6 µs | 291.8 µs | -27.51% |
| ❌ | Simulation | compare[45] |
218.2 µs | 300.4 µs | -27.35% |
| ... | ... | ... | ... | ... | ... |
ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing myrrc/dict-no-shared-array (a325cf6) with develop (e06d80b)
Contributor
Benchmarks: TPC-H SF=1 on NVMEVerdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.018x ➖, 0↑ 1↓)
datafusion / vortex-compact (1.021x ➖, 0↑ 1↓)
datafusion / parquet (0.999x ➖, 1↑ 0↓)
datafusion / arrow (1.014x ➖, 0↑ 2↓)
duckdb / vortex-file-compressed (1.003x ➖, 0↑ 0↓)
duckdb / vortex-compact (1.005x ➖, 0↑ 0↓)
duckdb / parquet (0.997x ➖, 1↑ 3↓)
duckdb / duckdb (1.002x ➖, 0↑ 0↓)
File Size Changes (10 files changed, -0.1% overall, 6↑ 4↓)
Totals:
|
Contributor
Benchmarks: TPC-DS SF=1 on NVMEVerdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.015x ➖, 0↑ 11↓)
datafusion / vortex-compact (0.993x ➖, 3↑ 1↓)
datafusion / parquet (0.986x ➖, 2↑ 0↓)
duckdb / vortex-file-compressed (0.985x ➖, 1↑ 0↓)
duckdb / vortex-compact (0.989x ➖, 1↑ 1↓)
duckdb / parquet (0.991x ➖, 0↑ 0↓)
duckdb / duckdb (0.990x ➖, 1↑ 3↓)
File Size Changes (6 files changed, -0.0% overall, 0↑ 6↓)
Totals:
|
Contributor
🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨Benchmark |
Contributor
Benchmarks: Statistical and Population GeneticsVerdict: No clear signal (low confidence) How to read Verdict and Engines
duckdb / vortex-file-compressed (0.994x ➖, 0↑ 0↓)
duckdb / vortex-compact (0.996x ➖, 0↑ 0↓)
duckdb / parquet (1.020x ➖, 0↑ 0↓)
File Size Changes (1 files changed, -0.0% overall, 0↑ 1↓)
Totals:
|
Contributor
🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨Benchmark |
Contributor
Benchmarks: TPC-H SF=10 on NVMEVerdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.006x ➖, 0↑ 1↓)
datafusion / vortex-compact (1.003x ➖, 0↑ 1↓)
datafusion / parquet (0.991x ➖, 0↑ 0↓)
datafusion / arrow (0.984x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (0.987x ➖, 0↑ 0↓)
duckdb / vortex-compact (0.990x ➖, 0↑ 0↓)
duckdb / parquet (0.998x ➖, 0↑ 0↓)
duckdb / duckdb (0.991x ➖, 0↑ 0↓)
File Size Changes (26 files changed, -0.0% overall, 13↑ 13↓)
Totals:
|
Contributor
Benchmarks: TPC-H SF=1 on S3Verdict: No clear signal (environment too noisy confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (0.988x ➖, 0↑ 1↓)
datafusion / vortex-compact (0.977x ➖, 0↑ 1↓)
datafusion / parquet (0.999x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (1.031x ➖, 0↑ 1↓)
duckdb / vortex-compact (1.040x ➖, 0↑ 0↓)
duckdb / parquet (0.980x ➖, 0↑ 0↓)
|
Contributor
Benchmarks: Appian on NVMEVerdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.052x ➖, 0↑ 1↓)
datafusion / parquet (1.037x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (1.026x ➖, 0↑ 0↓)
duckdb / parquet (1.026x ➖, 0↑ 0↓)
duckdb / duckdb (1.015x ➖, 0↑ 0↓)
File Size Changes (4 files changed, -0.0% overall, 2↑ 2↓)
Totals:
|
Contributor
Benchmarks: Random AccessVortex (geomean): 0.879x ✅ How to read Verdict and Engines
unknown / unknown (0.972x ➖, 12↑ 3↓)
|
Contributor
|
We really don't want to do this? |
Contributor
Benchmarks: TPC-H SF=10 on S3Verdict: No clear signal (environment too noisy confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.051x ➖, 1↑ 2↓)
datafusion / vortex-compact (1.061x ➖, 0↑ 1↓)
datafusion / parquet (1.028x ➖, 1↑ 1↓)
duckdb / vortex-file-compressed (1.120x ➖, 0↑ 1↓)
duckdb / vortex-compact (1.099x ➖, 0↑ 1↓)
duckdb / parquet (1.169x ➖, 0↑ 1↓)
|
Contributor
Benchmarks: CompressionVortex (geomean): 1.071x ➖ How to read Verdict and Engines
unknown / unknown (1.068x ➖, 0↑ 18↓)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SharedArray prevents us from using FSST data in queries like
SELECT byte_length(str), from SharedArray we already get decompressed
VarBinView data.
Check what of performance impact is not using the array