Skip to content

Don't use SharedArray for dict values #8299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
myrrc wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Don't use SharedArray for dict values #8299

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions vortex-layout/src/layouts/dict/reader.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,10 +100,10 @@ impl DictReader {
)
.vortex_expect("must construct dict values array evaluation")
.map_err(Arc::new)
.map(move |array| {
let array = array?;
Ok(SharedArray::new(array).into_array())
})
//.map(move |array| {
// let array = array?;
// Ok(SharedArray::new(array).into_array())
//})
.boxed()
.shared()
})
Expand Down
Loading