refactor: code around only negative flags

Author: alexander-akait

packages/webpack-cli/src/webpack-cli.ts

@@ -873,17 +873,12 @@ class WebpackCLI {
         (optionForCommand as Option & { configs: ArgumentConfig[] }).configs = option.configs;
       }
 
-      command.addOption(optionForCommand);
-    } else if (mainOption.type.size === 0 && negativeOption) {
-      const optionForCommand = new Option(mainOption.flags, mainOption.description);
-
-      // Hide stub option
-      optionForCommand.hidden = option.hidden || false;
-      (optionForCommand as Option & { internal?: boolean }).internal = true;
-
       command.addOption(optionForCommand);
     }
 
+    // A situation arises when `mainOption.type.size === 0 && negativeOption`
+    // In this case, we don't create the option, since this means the option only has a negative value
+
     if (negativeOption) {
       const optionForCommand = new Option(negativeOption.flags, negativeOption.description).default(
         false,
@@ -1048,10 +1043,6 @@ class WebpackCLI {
         },
         visibleOptions: function visibleOptions(command) {
           return command.options.filter((option) => {
-            if ((option as Option & { internal?: boolean }).internal) {
-              return false;
-            }
-
             // Hide `--watch` option when developer use `webpack watch --help`
             if (
               (options[0] === "w" || options[0] === "watch") &&
@@ -1986,10 +1977,7 @@ class WebpackCLI {
             }
 
             for (const option of command.options) {
-              if (
-                !(option as Option & { internal?: boolean }).internal &&
-                distance(name, option.long?.slice(2) as string) < 3
-              ) {
+              if (distance(name, option.long?.slice(2) as string) < 3) {
                 this.logger.error(`Did you mean '--${option.name()}'?`);
               }
             }

test/build/core-flags/core-flags.test.js

@@ -196,6 +196,24 @@ describe("core flags", () => {
     });
   });
 
+  describe("only negative flags", () => {
+    it("should throw an error on set performance to true", async () => {
+      const { exitCode, stderr, stdout } = await run(__dirname, ["--performance"]);
+
+      expect(exitCode).toBe(2);
+      expect(stderr).toContain("Unknown option '--performance'");
+      expect(stdout).toBeFalsy();
+    });
+
+    it("should set performance to false", async () => {
+      const { exitCode, stderr, stdout } = await run(__dirname, ["--no-performance"]);
+
+      expect(exitCode).toBe(0);
+      expect(stderr).toBeFalsy();
+      expect(stdout).toContain("performance: false");
+    });
+  });
+
   describe("flags with multiple types", () => {
     it("should allow string value for `infrastructureLogging.debug`", async () => {
       const { exitCode, stderr, stdout } = await run(__dirname, [