fix: replace bare except clauses with specific exception types#5066
Open
mango766 wants to merge 1 commit into1Panel-dev:v2from
Open
fix: replace bare except clauses with specific exception types#5066mango766 wants to merge 1 commit into1Panel-dev:v2from
mango766 wants to merge 1 commit into1Panel-dev:v2from
Conversation
Bare `except:` clauses catch KeyboardInterrupt and SystemExit, which prevents proper Celery worker shutdown and can cause processes to hang. - `utils.py`: uuid.UUID() raises ValueError on invalid input, so catch (ValueError, AttributeError) instead of bare except - `base_tool_node.py`: json.loads() raises JSONDecodeError on invalid JSON, so catch (json.JSONDecodeError, TypeError, ValueError) instead Fixes 1Panel-dev#5065 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5065
Replace bare
except:clauses with specific exception types to prevent catchingKeyboardInterruptandSystemExit, which can prevent proper Celery worker shutdown and cause processes to hang.Changes
apps/ops/celery/utils.py: Changedexcept:toexcept (ValueError, AttributeError):in UUID validation (uuid.UUID()raisesValueErroron invalid input)apps/application/flow/step_node/tool_node/impl/base_tool_node.py: Changedexcept:toexcept (json.JSONDecodeError, TypeError, ValueError):in type validation (json.loads()raisesJSONDecodeErroron invalid JSON)Test plan