Skip to content

Conversation

@SurbhiJainUSC
Copy link
Collaborator

@SurbhiJainUSC SurbhiJainUSC commented Jan 14, 2026

Description

This PR refactors tests assets based on https://screenshot.googleplex.com/574uqLTPrQy8FuN

  • Move src/MaxText/test_assets to tests/assets/golden_logits
  • Move golden data generation scripts inside src/MaxText/scratch_code/ to tests/assets/logits_generation
  • Updated Github CI workflows to reflect this new tests assets path
  • Updated Dockerfiles to reflect this new tests assets path

Tests

Unit/integ tests

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@SurbhiJainUSC SurbhiJainUSC changed the title Move tests assets inside tests directory Move tests assets and logits generation script inside tests directory Jan 14, 2026
@SurbhiJainUSC SurbhiJainUSC changed the title Move tests assets and logits generation script inside tests directory Move test_assets and logits generation script inside tests directory Jan 14, 2026
@SurbhiJainUSC SurbhiJainUSC force-pushed the test_assets_restructure branch from 62ea7a6 to 6deffb4 Compare January 14, 2026 19:43
@github-actions
Copy link

🤖 Hi @SurbhiJainUSC, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

## 📋 Review Summary

This pull request effectively refactors the project structure by moving test assets and logits generation scripts into the tests directory. The changes are consistent and well-executed across the codebase, improving the separation between source code and test data.

🔍 General Feedback

  • The paths in CI workflows, Dockerfiles, and test files have been updated correctly to reflect the new file locations.
  • I've pointed out a minor inconsistency in the default path construction for MAXTEXT_TEST_ASSETS_ROOT in a couple of end-to-end test scripts. Using MAXTEXT_REPO_ROOT as the base would be more consistent with the rest of the changes.

Overall, this is a solid refactoring that improves the project's organization.

@SurbhiJainUSC SurbhiJainUSC force-pushed the test_assets_restructure branch 5 times, most recently from 606ad10 to 7e193c3 Compare January 14, 2026 20:07
@codecov
Copy link

codecov bot commented Jan 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Collaborator

@hengtaoguo hengtaoguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update these two lines regarding the test_image.jpg/test_video.mp4 path? This is the most critical one at the moment. Thanks!

self.image_path = os.path.join(MAXTEXT_REPO_ROOT, "src", "MaxText", "test_assets", "test_image.jpg")
self.video_path = os.path.join(MAXTEXT_REPO_ROOT, "src", "MaxText", "test_assets", "test_video.mp4")

There might be some other places referencing these static assets too:

https://github.com/search?q=repo%3AAI-Hypercomputer%2Fmaxtext+test_image.jpg&type=code

@SurbhiJainUSC
Copy link
Collaborator Author

Could you also update these two lines regarding the test_image.jpg/test_video.mp4 path? This is the most critical one at the moment. Thanks!

self.image_path = os.path.join(MAXTEXT_REPO_ROOT, "src", "MaxText", "test_assets", "test_image.jpg")
self.video_path = os.path.join(MAXTEXT_REPO_ROOT, "src", "MaxText", "test_assets", "test_video.mp4")

There might be some other places referencing these static assets too:

https://github.com/search?q=repo%3AAI-Hypercomputer%2Fmaxtext+test_image.jpg&type=code

Thank you Hengtao, updated.

@SurbhiJainUSC SurbhiJainUSC force-pushed the test_assets_restructure branch from 05cfc5b to 496bd26 Compare January 15, 2026 21:19
@copybara-service copybara-service bot merged commit d6729b0 into main Jan 16, 2026
32 checks passed
@copybara-service copybara-service bot deleted the test_assets_restructure branch January 16, 2026 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants