-
Notifications
You must be signed in to change notification settings - Fork 449
Move test_assets and logits generation script inside tests directory #2948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
62ea7a6 to
6deffb4
Compare
|
🤖 Hi @SurbhiJainUSC, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request effectively refactors the project structure by moving test assets and logits generation scripts into the tests directory. The changes are consistent and well-executed across the codebase, improving the separation between source code and test data.
🔍 General Feedback
- The paths in CI workflows, Dockerfiles, and test files have been updated correctly to reflect the new file locations.
- I've pointed out a minor inconsistency in the default path construction for
MAXTEXT_TEST_ASSETS_ROOTin a couple of end-to-end test scripts. UsingMAXTEXT_REPO_ROOTas the base would be more consistent with the rest of the changes.
Overall, this is a solid refactoring that improves the project's organization.
606ad10 to
7e193c3
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
hengtaoguo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also update these two lines regarding the test_image.jpg/test_video.mp4 path? This is the most critical one at the moment. Thanks!
maxtext/tests/check_qwen3_embedding_vs_reference.py
Lines 534 to 535 in 111cb6b
| self.image_path = os.path.join(MAXTEXT_REPO_ROOT, "src", "MaxText", "test_assets", "test_image.jpg") | |
| self.video_path = os.path.join(MAXTEXT_REPO_ROOT, "src", "MaxText", "test_assets", "test_video.mp4") |
There might be some other places referencing these static assets too:
https://github.com/search?q=repo%3AAI-Hypercomputer%2Fmaxtext+test_image.jpg&type=code
7e193c3 to
0dde132
Compare
Thank you Hengtao, updated. |
0dde132 to
05cfc5b
Compare
05cfc5b to
496bd26
Compare
Description
This PR refactors tests assets based on https://screenshot.googleplex.com/574uqLTPrQy8FuN
src/MaxText/test_assetstotests/assets/golden_logitssrc/MaxText/scratch_code/totests/assets/logits_generationTests
Unit/integ tests
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.