Skip to content

Conversation

@SurbhiJainUSC
Copy link
Collaborator

@SurbhiJainUSC SurbhiJainUSC commented Jan 15, 2026

Description

Move src/MaxText/distillation to src/maxtext/trainers/post_train/distillation as part of repo restructuring work as planned here: https://github.com/AI-Hypercomputer/maxtext/blob/main/RESTRUCTURE.md

Tests

python3 -m src.MaxText.distillation.train_distill \
src/MaxText/configs/distillation.yml \
run_name=$RUN_NAME \
base_output_directory=$BASE_OUTPUT_DIRECTORY \
checkpoint_period=2000 \
hf_access_token=$HF_TOKEN \
log_period=10 \
save_checkpoint_on_completion=True \
teacher_overrides.load_parameters_path=maxtext-model-checkpoints/llama3.1-8b/2025-01-17-04-13/scanned/0/items
python3 -m src.maxtext.trainers.post_train.distillation.train_distill \
src/MaxText/configs/distillation.yml \
run_name=$RUN_NAME \
base_output_directory=$BASE_OUTPUT_DIRECTORY \
checkpoint_period=2000 \
hf_access_token=$HF_TOKEN \
log_period=10 \
save_checkpoint_on_completion=True \
teacher_overrides.load_parameters_path=maxtext-model-checkpoints/llama3.1-8b/2025-01-17-04-13/scanned/0/items

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@SurbhiJainUSC SurbhiJainUSC force-pushed the distillation_restructure branch 2 times, most recently from 5445a78 to 432e882 Compare January 15, 2026 23:21
@codecov
Copy link

codecov bot commented Jan 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@SurbhiJainUSC SurbhiJainUSC force-pushed the distillation_restructure branch from 432e882 to 1bce907 Compare January 16, 2026 01:27
@shralex
Copy link
Collaborator

shralex commented Jan 16, 2026

@codecov-ai-reviewer review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants