Skip to content

add check interval for checking nse inside integrator#1857

Closed
zhichen3 wants to merge 9 commits into
AMReX-Astro:developmentfrom
zhichen3:nse_check_interval
Closed

add check interval for checking nse inside integrator#1857
zhichen3 wants to merge 9 commits into
AMReX-Astro:developmentfrom
zhichen3:nse_check_interval

Conversation

@zhichen3
Copy link
Copy Markdown
Collaborator

@zhichen3 zhichen3 commented Oct 9, 2025

No description provided.

@zingale
Copy link
Copy Markdown
Member

zingale commented May 27, 2026

do we still want this?

@zhichen3
Copy link
Copy Markdown
Collaborator Author

I tested with this pr before and it didn't help with subchandra. I think the current self-consistent NSE-check is reasonably optimized, and if the check itself outweighs benefit that it brings, then we probably just shouldn't use it. I think this method really shines when we have the quasi-statistical stuff hooked in where we work in a reduced system. This is something that I will come back to once I at least have a rough draft for my xrb paper.

At the meantime, I think a traditional temperature check might work now. It didn't work well before since there were a discrepancy between NSE-solution and the steady state solution. But now its fixed. I tested the simple temperature check awhile back with the Detonation problem and it worked really nicely -- not sure if I shared the plot. I was gonna test it with subchandra, but somehow got distracted. I should revisit this...

@zingale
Copy link
Copy Markdown
Member

zingale commented May 27, 2026

okay, then why don't you close this.

@zhichen3 zhichen3 closed this May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants