Skip to content

CMake: Replace FetchContent_Populate#135

Open
ax3l wants to merge 2 commits into
AMReX-Codes:mainfrom
ax3l:fix-cmake-fetch-content
Open

CMake: Replace FetchContent_Populate#135
ax3l wants to merge 2 commits into
AMReX-Codes:mainfrom
ax3l:fix-cmake-fetch-content

Conversation

@ax3l
Copy link
Copy Markdown
Member

@ax3l ax3l commented Aug 30, 2024

In CMake superbuilds, FetchContent_Populate is now deprecated. Use FetchContent_MakeAvailable instead.

  • Bump CMake to 2.24+ to have the latest behavioral changes in it. We anyway need a bump as we will soon rework the CUDA/HIP language support from AMReX to downstream.

See AMReX-Codes/pyamrex#359

@ax3l ax3l force-pushed the fix-cmake-fetch-content branch 4 times, most recently from 2b23d48 to 31ac1ec Compare August 30, 2024 03:09
@ax3l ax3l marked this pull request as ready for review August 30, 2024 03:26
@ax3l ax3l requested a review from WeiqunZhang August 30, 2024 03:26
@ax3l ax3l changed the title [WIP] CMake: Replace FetchContent_Populate CMake: Replace FetchContent_Populate Aug 30, 2024
@ax3l ax3l added the enhancement New feature or request label Aug 30, 2024
@ax3l ax3l force-pushed the fix-cmake-fetch-content branch from 739945c to d9a73e3 Compare August 30, 2024 03:58
@ax3l ax3l changed the title CMake: Replace FetchContent_Populate [WIP}CMake: Replace FetchContent_Populate Aug 30, 2024
@ax3l ax3l changed the title [WIP}CMake: Replace FetchContent_Populate [WIP] CMake: Replace FetchContent_Populate Aug 30, 2024
ax3l added 2 commits January 16, 2025 10:48
In CMake superbuilds, `FetchContent_Populate` is now deprecated.
Use `FetchContent_MakeAvailable` instead.
@ax3l ax3l force-pushed the fix-cmake-fetch-content branch from d9a73e3 to 1c2e6aa Compare January 16, 2025 18:48
@atmyers
Copy link
Copy Markdown
Member

atmyers commented Jul 16, 2025

Hi @ax3l - is this still WIP?

@ax3l ax3l changed the title [WIP] CMake: Replace FetchContent_Populate CMake: Replace FetchContent_Populate May 13, 2026
@ax3l
Copy link
Copy Markdown
Member Author

ax3l commented May 13, 2026

OH I think this should go in... let me retrigger CI

@ax3l ax3l closed this May 13, 2026
@ax3l ax3l reopened this May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants