Add scaling for non-cubic rectangular geometries, remove mean velocit…#170
Open
drummerdoc wants to merge 3 commits into
Open
Add scaling for non-cubic rectangular geometries, remove mean velocit…#170drummerdoc wants to merge 3 commits into
drummerdoc wants to merge 3 commits into
Conversation
…ies, and remove hardware of infile and variable names
WeiqunZhang
reviewed
Mar 10, 2026
Member
Author
|
I do not know how to fix the failing windows CI test. Perhaps @ax3l ? |
WeiqunZhang
requested changes
May 18, 2026
Member
WeiqunZhang
left a comment
WeiqunZhang
left a comment
There was a problem hiding this comment.
We will fix Windows CIs in a separate PR, because it's a separate issue.
|
|
||
| // For simplicity, we assume the domain is a cube, and we are not | ||
| // going to worry about scaling. | ||
| // For simplicity, we are not going to worry about scaling. |
Member
There was a problem hiding this comment.
Is this comment outdated now?
| } | ||
| } | ||
| if (ParallelDescriptor::IOProcessor()) { | ||
| std::ofstream ofs(outfile.c_str()); |
Member
There was a problem hiding this comment.
No need to use c_str, because ofstream takes std::string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add scaling for non-cubic rectangular geometries, remove mean velocities, and remove hardware of infile and variable names.