Add JunctionRef bindings for hyperedge routing#36
Open
kumilingus wants to merge 1 commit intoAksem:new-emsdk-and-embindfrom
Open
Add JunctionRef bindings for hyperedge routing#36kumilingus wants to merge 1 commit intoAksem:new-emsdk-and-embindfrom
kumilingus wants to merge 1 commit intoAksem:new-emsdk-and-embindfrom
Conversation
Expose JunctionRef class (constructor, position, setPositionFixed, positionFixed, recommendedPosition) and Router.deleteJunction via embind. Update TypeScript typings. Add node example demonstrating junction-based hyperedge routing. Closes Aksem#35 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #35.
Summary
JunctionRefembind bindings: constructor,position(),setPositionFixed(),positionFixed(),recommendedPosition()Router.deleteJunction()binding for cleanupdeleteJunctionNote
Unfortunately,
shapeBufferDistancedoesn't seem to have any effect on junction placement. The optimizer just keeps pulling it toward the minimum-length Steiner point no matter what.For now,
setPositionFixed(true)might be the only way to keep the junction where the developer wants it, though I'm not 100% sure there isn't something else I'm missing.