Add migration to move profile IDs from permalink to query param format #2766
+118
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change actor IDs to always use the query param format (?author=ID). When accessed via the old permalink URL, show movedTo pointing to the new ID. Add migration to send Move activity for blog user.
Eliminated the call to set_to with Remote_Actors::get_inboxes() when creating migration activities. This may be to adjust how recipients are handled or to prevent unnecessary inbox notifications.
Updated the 'Move' activity to set actor, origin, and object fields to the old blog ID format using the preferred username, ensuring correct identification during migration.
Updated calls to Outbox::add to use the add_to_outbox function with an added null parameter. This change likely reflects a refactor or update in the outbox handling API.
Changed the default value of the $offset parameter from 0 to 5 in the schedule_outbox_activity_for_federation method to adjust the scheduling behavior.
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
?author=ID) for actor IDs instead of permalink formatmovedTopointing to new ID when actor is accessed via old permalink URLACTIVITYPUB_CONTENT_VISIBILITY_PRIVATEfor all Move activitiesOther information:
Testing instructions:
activitypub_use_permalink_as_id_for_blogoption totruefor blog actor testingactivitypub_use_permalink_as_iduser option to'1'for user actor testingactivitypub_db_versionoption to trigger migration (e.g.,wp option update activitypub_db_version '7.5.0')movedTopoints to new query param IDChangelog entry
Changelog Entry Details
Significance
Type
Message
Migrate actor IDs from permalink format to query param format with Move activity support.