{POSTGRES} Split postgres flexible server commands from RDBMS #32598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
|
Hi @nasc17, |
❌AzureCLI-BreakingChangeTest
Please submit your Breaking Change Pre-announcement ASAP if you haven't already. Please note:
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
calvinhzy,
evelyn-ys and
yonzhan
nasc17
changed the title
evelyn-ys
reviewed
Jan 5, 2026
Member
nachoalonsoportillo
left a comment
nachoalonsoportillo
left a comment
There was a problem hiding this comment.
Shouldn't all files with rdbms in their names be aso renamed to postgresql?
nasc17
requested review from
bebound,
jiasli,
jsntcy,
kairu-ms,
necusjz and
zhoxing-ms
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR splits PostgreSQL flexible server commands from the shared RDBMS module into a dedicated PostgreSQL module, following the pattern established by the MySQL team. The change reorganizes code by moving PostgreSQL-specific validators, utilities, and test files from rdbms to postgresql to improve module maintainability.
Key Changes:
- Removed PostgreSQL-specific validators, utilities, and test code from the RDBMS module
- Created new PostgreSQL validators.py with moved validation logic
- Split test files into separate PostgreSQL test modules
- Updated imports and removed PostgreSQL client factory functions from RDBMS
Reviewed changes
Copilot reviewed 69 out of 124 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/rdbms/validators.py | Removed PostgreSQL flexible server validators and helper functions |
| src/azure-cli/azure/cli/command_modules/rdbms/tests/latest/test_rdbms_flexible_commands.py | Deleted entire test file (2965 lines) containing PostgreSQL tests |
| src/azure-cli/azure/cli/command_modules/rdbms/flexible_server_custom_common.py | Removed PostgreSQL-specific functions (github_actions_setup, version_upgrade) |
| src/azure-cli/azure/cli/command_modules/rdbms/custom.py | Removed PostgreSQL-specific variables and updated engine logic |
| src/azure-cli/azure/cli/command_modules/rdbms/_transformers.py | Removed postgres_table_transform_output_list_skus function |
| src/azure-cli/azure/cli/command_modules/rdbms/_params.py | Removed PostgreSQL flexible server parameters and command arguments |
| src/azure-cli/azure/cli/command_modules/rdbms/_flexible_server_util.py | Removed PostgreSQL-specific utility functions and constants |
| src/azure-cli/azure/cli/command_modules/rdbms/_flexible_server_location_capabilities_util.py | Removed PostgreSQL location capability functions |
| src/azure-cli/azure/cli/command_modules/rdbms/_client_factory.py | Removed PostgreSQL client factory functions |
| src/azure-cli/azure/cli/command_modules/rdbms/init.py | Removed PostgreSQL flexible server command loading and help imports |
| src/azure-cli/azure/cli/command_modules/postgresql/validators.py | New file with 803 lines of PostgreSQL validators moved from RDBMS |
| src/azure-cli/azure/cli/command_modules/postgresql/tests/latest/*.py | New test files split from RDBMS test suite |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
@evelyn-ys Please trigger checks |
mattboentoro
approved these changes
Jan 8, 2026
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
Author
|
@yonzhan @evelyn-ys Please trigger checks |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
Author
|
@yonzhan Please trigger checks |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az postgres flexible-serverDescription
Split postgres flexible-server related commands to its own folder within the module. This would allow from better maintenance of the module from our team.
Similar steps followed by MySQL team: #26531
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.