Add Built-in Marketplace feature with direct downloads#792
Add Built-in Marketplace feature with direct downloads#792shdan-in wants to merge 7 commits intoBabylonJS:masterfrom
Conversation
SKETCHFAB_CLIENT_ID needs to be setup in env for Sketchfab to work.It can be requested from Sketchfab support page. Submit following details:
For development I used mine. |
|
WOOOOOOOOOOOOW!! I have suggestions and questions and I'm open to debate:
For sketchfab, the client ID must be hidden or it can be seen once the app is packaged? I really see the value of it and we all want it!! We can proceed step by step. Also, did you use AI to generate it or you coded it by yourself or were you assited by AI? No judgement here don't worry just to know. Can't wait to have your feedbacks and ideas |
|
One other suggestion: it is not possible to load HDRi from Poly Haven right now. In case you could add it, you could directly convert them to .env (https://doc.babylonjs.com/features/featuresDeepDive/materials/using/HDREnvironment#what-is-a-env-tech-deep-dive) directly so it's more optimized for the engine and less heavy |
|
Thanks for all these suggestions, I will be adding these and more in future PRs, adding at once will make PR so big and harder to review for you too, so this only have Download functionality.
|
|
Thanks for your answers!! I did not understand "Also, current plugin implementation needs a browser too😄.". But I understand that it will still require the local webserver. Going through a plugin is not the solution then, keep your work in the core of the editor. I'm thinking what we can do. |
|
What we can do is merge this after v9 release, so release is not impacted and this can be shipped in next release? "Also, current plugin implementation needs a browser too😄" I meant we can add some plugin list to install from rather than manual npm package input |
FOR SURE!! And I already started it especially for the fab plugin as it is officially documented here: https://editor.babylonjs.com/documentation/plugins/fab But finally I opt to have markerplaces in the core of the Editor as you were right since the beginning 😂 |
It depends. If integration of marketplaces is enough separated from main core features of the editor, it can be released for the version 9. For me it's also an opportunity to communicate for incoming features that may be tagged "exprimental" |
Let me work on separation of functionality a bit more to ship it as experimental. (Thinking to add a toggle in Editor settings to enable experimental features) |
It's already done, you can use |
|
@julien-moreau Added HDRI support for PolyHaven, including direct converted import as ENV. |
That's awesome! Really thank you I'm starting reviewing this week-end! I already had a look and it's really promising |
Add Built-in Marketplace feature with direct downloads
Summary
This PR introduces a full built-in Marketplace feature to the editor with support for multiple content providers. It adds a unified browsing/import experience, provider-specific integrations (including authentication where needed), and a common provider architecture to make future marketplace sources easy to add. The goal is to let users search, preview, and import assets directly inside the editor without leaving their workflow.
Changes Made
Providers Included in this PR
Marketplace
Benefits