Skip to content

[WIP] Fix experience points increase when teleporting between worlds#2985

Closed
Copilot wants to merge 2 commits into
developfrom
copilot/fix-experience-points-increase
Closed

[WIP] Fix experience points increase when teleporting between worlds#2985
Copilot wants to merge 2 commits into
developfrom
copilot/fix-experience-points-increase

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 20, 2026

  • Understand the root cause: when switching worlds with advancement tracking enabled, re-granting advancements causes XP to increase
  • Add isOnLeaveResetAdvancements() to WorldSettings interface (default false)
  • Add isOnLeaveResetAdvancements(World) to IslandWorldManager
  • Add advancement storage (worldAdvancements) to Players data object
  • Implement advancement save/restore logic in JoinLeaveListener.onPlayerSwitchWorld with XP protection
  • Add tests for the new advancement handling
  • Run tests to validate changes

Copilot stopped work on behalf of tastybento due to an error May 20, 2026 21:56
Copilot AI requested a review from tastybento May 20, 2026 21:56
@tastybento tastybento marked this pull request as ready for review May 23, 2026 01:56
@tastybento tastybento closed this May 23, 2026
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When teleporting between a non-BentoBox world and a BentoBox world, experience points automatically increase.

2 participants