feat: add CMD+Q keyboard shortcut to Exit menu on macOS#4079
Open
sixzjd wants to merge 7 commits into
Open
Conversation
The Exit NativeMenuItem was missing a Gesture property, so pressing CMD+Q had no effect on macOS. Adding Gesture="CMD+Q" enables the standard keyboard shortcut for quitting the application.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Gesture = "CMD+Q"to the ExitNativeMenuItemin the macOS application menuProblem
On macOS, pressing Cmd+Q does nothing because:
DisableDefaultApplicationMenuItems = trueremoves the standard macOS Quit menuNativeMenuItemhas noGestureproperty setFix
One-line change in
src/BD.WTTS.Client.Avalonia/UI/App.axaml.cs:Note: The
DebugWindow.axamlalready usesGesture="CMD+Q"pattern (line 23), so this is consistent with the existing codebase.