[heesun-task] WEEK 02 Solutions#2412
Merged
SamTheKorean merged 4 commits intoDaleStudy:mainfrom Mar 15, 2026
Merged
Conversation
Contributor
|
다른 분들처럼 pr제목 앞에 [깃허브 아이디] 넣어주시면 좋을 것 같습니다! |
Contributor
|
문제가 pr에 연결되어 있는문제랑 다른것 같아요! 확인 부탁드려요. @heesun-task |
Contributor
Author
안녕하세요 오늘 업데이트해놓겠습니다! 감사합니다 Update: 수정했습니다 |
kangdaia
approved these changes
Mar 14, 2026
| s_dict = {} | ||
| for s_letter in s: | ||
| if s_letter in s_dict: | ||
| s_dict[s_letter] += 1 |
Contributor
There was a problem hiding this comment.
이 부분을 s_dict.get(s_letter, 0) + 1 방식으로 쓰면 한줄로 줄일 수 있을 것 같아요!
Contributor
There was a problem hiding this comment.
수고하셨어요!
- counter를 사용하면 (약간이지만) 빠르고 간단하게 쓰실 수 있어요. 물론 인터뷰나 실제 코딩 테스트를 보실때는 dict 방식으로 풀어서 쓰는게 설명하기 좋을 것 같네요.
- casefold를 고려하시면 좋을 것 같아요. 특수 문자가 섞여있는 언어의 경우는 문제가 생길 수 있어요.
- documentation을 쓰시는 것도 좋을 것 같아요. 시간복잡도와 공간복잡도를 써주셔서 좋은 것 같아요.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
답안 제출 문제
작성자 체크 리스트
In Review로 설정해주세요.검토자 체크 리스트
Important
본인 답안 제출 뿐만 아니라 다른 분 PR 하나 이상을 반드시 검토를 해주셔야 합니다!