Update Telemetry Key Normalization to Use Environment Variables#10823
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 64 metrics, 7 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~ccf8482295, baseline=1.61.0-SNAPSHOT~c8a3897d4a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.063 s) : 0, 1063229
Total [baseline] (11.046 s) : 0, 11045802
Agent [candidate] (1.062 s) : 0, 1061876
Total [candidate] (11.151 s) : 0, 11151057
section appsec
Agent [baseline] (1.253 s) : 0, 1253286
Total [baseline] (11.157 s) : 0, 11157484
Agent [candidate] (1.25 s) : 0, 1250206
Total [candidate] (11.256 s) : 0, 11255512
section iast
Agent [baseline] (1.237 s) : 0, 1236714
Total [baseline] (11.317 s) : 0, 11316714
Agent [candidate] (1.228 s) : 0, 1227706
Total [candidate] (11.371 s) : 0, 11370778
section profiling
Agent [baseline] (1.195 s) : 0, 1194627
Total [baseline] (11.1 s) : 0, 11100137
Agent [candidate] (1.192 s) : 0, 1191756
Total [candidate] (11.021 s) : 0, 11020914
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~ccf8482295, baseline=1.61.0-SNAPSHOT~c8a3897d4a
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.195 ms) : 0, 1195
crashtracking [candidate] (1.187 ms) : 0, 1187
BytebuddyAgent [baseline] (631.526 ms) : 0, 631526
BytebuddyAgent [candidate] (629.488 ms) : 0, 629488
AgentMeter [baseline] (29.311 ms) : 0, 29311
AgentMeter [candidate] (29.16 ms) : 0, 29160
GlobalTracer [baseline] (257.908 ms) : 0, 257908
GlobalTracer [candidate] (257.832 ms) : 0, 257832
AppSec [baseline] (31.72 ms) : 0, 31720
AppSec [candidate] (31.442 ms) : 0, 31442
Debugger [baseline] (59.644 ms) : 0, 59644
Debugger [candidate] (59.485 ms) : 0, 59485
Remote Config [baseline] (618.229 µs) : 0, 618
Remote Config [candidate] (611.764 µs) : 0, 612
Telemetry [baseline] (8.722 ms) : 0, 8722
Telemetry [candidate] (8.668 ms) : 0, 8668
Flare Poller [baseline] (6.494 ms) : 0, 6494
Flare Poller [candidate] (7.961 ms) : 0, 7961
section appsec
crashtracking [baseline] (1.198 ms) : 0, 1198
crashtracking [candidate] (1.21 ms) : 0, 1210
BytebuddyAgent [baseline] (663.031 ms) : 0, 663031
BytebuddyAgent [candidate] (662.936 ms) : 0, 662936
AgentMeter [baseline] (12.116 ms) : 0, 12116
AgentMeter [candidate] (12.017 ms) : 0, 12017
GlobalTracer [baseline] (259.378 ms) : 0, 259378
GlobalTracer [candidate] (258.202 ms) : 0, 258202
IAST [baseline] (24.16 ms) : 0, 24160
IAST [candidate] (23.928 ms) : 0, 23928
AppSec [baseline] (177.831 ms) : 0, 177831
AppSec [candidate] (176.877 ms) : 0, 176877
Debugger [baseline] (65.945 ms) : 0, 65945
Debugger [candidate] (65.562 ms) : 0, 65562
Remote Config [baseline] (577.411 µs) : 0, 577
Remote Config [candidate] (564.978 µs) : 0, 565
Telemetry [baseline] (9.085 ms) : 0, 9085
Telemetry [candidate] (9.04 ms) : 0, 9040
Flare Poller [baseline] (3.66 ms) : 0, 3660
Flare Poller [candidate] (3.608 ms) : 0, 3608
section iast
crashtracking [baseline] (1.196 ms) : 0, 1196
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (802.865 ms) : 0, 802865
BytebuddyAgent [candidate] (796.65 ms) : 0, 796650
AgentMeter [baseline] (11.418 ms) : 0, 11418
AgentMeter [candidate] (11.343 ms) : 0, 11343
GlobalTracer [baseline] (249.114 ms) : 0, 249114
GlobalTracer [candidate] (247.667 ms) : 0, 247667
IAST [baseline] (25.337 ms) : 0, 25337
IAST [candidate] (25.122 ms) : 0, 25122
AppSec [baseline] (26.582 ms) : 0, 26582
AppSec [candidate] (26.393 ms) : 0, 26393
Debugger [baseline] (65.118 ms) : 0, 65118
Debugger [candidate] (64.446 ms) : 0, 64446
Remote Config [baseline] (521.585 µs) : 0, 522
Remote Config [candidate] (513.51 µs) : 0, 514
Telemetry [baseline] (13.824 ms) : 0, 13824
Telemetry [candidate] (13.806 ms) : 0, 13806
Flare Poller [baseline] (4.615 ms) : 0, 4615
Flare Poller [candidate] (4.604 ms) : 0, 4604
section profiling
crashtracking [baseline] (1.173 ms) : 0, 1173
crashtracking [candidate] (1.183 ms) : 0, 1183
BytebuddyAgent [baseline] (690.451 ms) : 0, 690451
BytebuddyAgent [candidate] (688.276 ms) : 0, 688276
AgentMeter [baseline] (8.692 ms) : 0, 8692
AgentMeter [candidate] (8.727 ms) : 0, 8727
GlobalTracer [baseline] (217.621 ms) : 0, 217621
GlobalTracer [candidate] (217.317 ms) : 0, 217317
AppSec [baseline] (32.397 ms) : 0, 32397
AppSec [candidate] (32.386 ms) : 0, 32386
Debugger [baseline] (64.325 ms) : 0, 64325
Debugger [candidate] (62.781 ms) : 0, 62781
Remote Config [baseline] (585.329 µs) : 0, 585
Remote Config [candidate] (594.834 µs) : 0, 595
Telemetry [baseline] (9.867 ms) : 0, 9867
Telemetry [candidate] (11.505 ms) : 0, 11505
Flare Poller [baseline] (3.557 ms) : 0, 3557
Flare Poller [candidate] (3.567 ms) : 0, 3567
ProfilingAgent [baseline] (94.63 ms) : 0, 94630
ProfilingAgent [candidate] (94.29 ms) : 0, 94290
Profiling [baseline] (95.206 ms) : 0, 95206
Profiling [candidate] (94.857 ms) : 0, 94857
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~ccf8482295, baseline=1.61.0-SNAPSHOT~c8a3897d4a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.06 s) : 0, 1059814
Total [baseline] (8.884 s) : 0, 8883840
Agent [candidate] (1.062 s) : 0, 1062346
Total [candidate] (8.873 s) : 0, 8873441
section iast
Agent [baseline] (1.228 s) : 0, 1228056
Total [baseline] (9.599 s) : 0, 9598750
Agent [candidate] (1.225 s) : 0, 1225157
Total [candidate] (9.529 s) : 0, 9529370
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~ccf8482295, baseline=1.61.0-SNAPSHOT~c8a3897d4a
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.194 ms) : 0, 1194
crashtracking [candidate] (1.197 ms) : 0, 1197
BytebuddyAgent [baseline] (629.556 ms) : 0, 629556
BytebuddyAgent [candidate] (629.479 ms) : 0, 629479
AgentMeter [baseline] (29.132 ms) : 0, 29132
AgentMeter [candidate] (29.214 ms) : 0, 29214
GlobalTracer [baseline] (257.279 ms) : 0, 257279
GlobalTracer [candidate] (258.065 ms) : 0, 258065
AppSec [baseline] (31.542 ms) : 0, 31542
AppSec [candidate] (31.575 ms) : 0, 31575
Debugger [baseline] (58.562 ms) : 0, 58562
Debugger [candidate] (58.75 ms) : 0, 58750
Remote Config [baseline] (629.851 µs) : 0, 630
Remote Config [candidate] (607.131 µs) : 0, 607
Telemetry [baseline] (8.618 ms) : 0, 8618
Telemetry [candidate] (8.725 ms) : 0, 8725
Flare Poller [baseline] (7.248 ms) : 0, 7248
Flare Poller [candidate] (8.663 ms) : 0, 8663
section iast
crashtracking [baseline] (1.195 ms) : 0, 1195
crashtracking [candidate] (1.189 ms) : 0, 1189
BytebuddyAgent [baseline] (797.079 ms) : 0, 797079
BytebuddyAgent [candidate] (795.361 ms) : 0, 795361
AgentMeter [baseline] (11.332 ms) : 0, 11332
AgentMeter [candidate] (11.305 ms) : 0, 11305
GlobalTracer [baseline] (247.406 ms) : 0, 247406
GlobalTracer [candidate] (247.375 ms) : 0, 247375
IAST [baseline] (25.149 ms) : 0, 25149
IAST [candidate] (25.109 ms) : 0, 25109
AppSec [baseline] (26.311 ms) : 0, 26311
AppSec [candidate] (26.333 ms) : 0, 26333
Debugger [baseline] (63.098 ms) : 0, 63098
Debugger [candidate] (62.381 ms) : 0, 62381
Remote Config [baseline] (515.708 µs) : 0, 516
Remote Config [candidate] (519.347 µs) : 0, 519
Telemetry [baseline] (14.911 ms) : 0, 14911
Telemetry [candidate] (14.748 ms) : 0, 14748
Flare Poller [baseline] (4.984 ms) : 0, 4984
Flare Poller [candidate] (4.873 ms) : 0, 4873
LoadParameters
See matching parameters
SummaryFound 4 performance improvements and 1 performance regressions! Performance is the same for 15 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~ccf8482295, baseline=1.61.0-SNAPSHOT~c8a3897d4a
dateFormat X
axisFormat %s
section baseline
no_agent (18.912 ms) : 18723, 19100
. : milestone, 18912,
appsec (18.811 ms) : 18622, 19000
. : milestone, 18811,
code_origins (17.701 ms) : 17524, 17878
. : milestone, 17701,
iast (17.809 ms) : 17633, 17984
. : milestone, 17809,
profiling (18.842 ms) : 18653, 19032
. : milestone, 18842,
tracing (18.235 ms) : 18051, 18419
. : milestone, 18235,
section candidate
no_agent (17.409 ms) : 17231, 17588
. : milestone, 17409,
appsec (18.467 ms) : 18279, 18655
. : milestone, 18467,
code_origins (17.808 ms) : 17632, 17985
. : milestone, 17808,
iast (18.093 ms) : 17911, 18274
. : milestone, 18093,
profiling (18.559 ms) : 18374, 18745
. : milestone, 18559,
tracing (18.045 ms) : 17864, 18227
. : milestone, 18045,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~ccf8482295, baseline=1.61.0-SNAPSHOT~c8a3897d4a
dateFormat X
axisFormat %s
section baseline
no_agent (1.2 ms) : 1188, 1212
. : milestone, 1200,
iast (3.182 ms) : 3139, 3224
. : milestone, 3182,
iast_FULL (6.177 ms) : 6114, 6240
. : milestone, 6177,
iast_GLOBAL (3.603 ms) : 3551, 3655
. : milestone, 3603,
profiling (1.972 ms) : 1955, 1989
. : milestone, 1972,
tracing (1.778 ms) : 1763, 1794
. : milestone, 1778,
section candidate
no_agent (1.175 ms) : 1163, 1187
. : milestone, 1175,
iast (3.07 ms) : 3029, 3111
. : milestone, 3070,
iast_FULL (5.597 ms) : 5542, 5652
. : milestone, 5597,
iast_GLOBAL (3.611 ms) : 3552, 3671
. : milestone, 3611,
profiling (2.239 ms) : 2217, 2261
. : milestone, 2239,
tracing (1.821 ms) : 1805, 1836
. : milestone, 1821,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~ccf8482295, baseline=1.61.0-SNAPSHOT~c8a3897d4a
dateFormat X
axisFormat %s
section baseline
no_agent (14.999 s) : 14999000, 14999000
. : milestone, 14999000,
appsec (15.126 s) : 15126000, 15126000
. : milestone, 15126000,
iast (17.663 s) : 17663000, 17663000
. : milestone, 17663000,
iast_GLOBAL (17.928 s) : 17928000, 17928000
. : milestone, 17928000,
profiling (14.707 s) : 14707000, 14707000
. : milestone, 14707000,
tracing (15.166 s) : 15166000, 15166000
. : milestone, 15166000,
section candidate
no_agent (15.243 s) : 15243000, 15243000
. : milestone, 15243000,
appsec (14.871 s) : 14871000, 14871000
. : milestone, 14871000,
iast (18.187 s) : 18187000, 18187000
. : milestone, 18187000,
iast_GLOBAL (17.704 s) : 17704000, 17704000
. : milestone, 17704000,
profiling (14.938 s) : 14938000, 14938000
. : milestone, 14938000,
tracing (14.937 s) : 14937000, 14937000
. : milestone, 14937000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~ccf8482295, baseline=1.61.0-SNAPSHOT~c8a3897d4a
dateFormat X
axisFormat %s
section baseline
no_agent (1.471 ms) : 1459, 1482
. : milestone, 1471,
appsec (3.738 ms) : 3520, 3955
. : milestone, 3738,
iast (2.254 ms) : 2185, 2324
. : milestone, 2254,
iast_GLOBAL (2.3 ms) : 2230, 2370
. : milestone, 2300,
profiling (2.503 ms) : 2338, 2668
. : milestone, 2503,
tracing (2.061 ms) : 2007, 2115
. : milestone, 2061,
section candidate
no_agent (1.473 ms) : 1462, 1485
. : milestone, 1473,
appsec (3.805 ms) : 3583, 4026
. : milestone, 3805,
iast (2.258 ms) : 2189, 2327
. : milestone, 2258,
iast_GLOBAL (2.296 ms) : 2227, 2366
. : milestone, 2296,
profiling (2.082 ms) : 2027, 2137
. : milestone, 2082,
tracing (2.067 ms) : 2014, 2121
. : milestone, 2067,
|
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
Build pipeline has failing jobs for d09cccc: What to do next?
DetailsSince those jobs are not marked as being allowed to fail, the pipeline will most likely fail. |
|
/merge |
|
View all feedbacks in Devflow UI.
PR already in the queue with status queued |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
0a45dd7
into
master
Note: This PR is opened in favor of #10788, which was closed due to Git tag issues which ran system-tests that were supposed to be disabled for specific tracer versions.
What Does This Do
One major pain-point for developers is that they need to manually enable intake to accept new configurations added to the tracers in order to receive telemetry for these newly added configs. The configuration team would like to automate this process for developers, automatically opening PRs in dd-go to add telemetry normalization in intake when new configurations are added to any of the dd-trace* libraries.
Since each tracer sends telemetry keys in a different format, we need to first standardize what is being sent. The common format among all tracers is environment variables. Thus, this PR updates the normalization of telemetry keys being sent from the current status (lowercase and
_) to using the environment variable version of the configurations.Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.