Prevent retransforming record with type annotation#10824
Prevent retransforming record with type annotation#10824gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intomasterfrom
Conversation
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 8 metrics, 7 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (336.855 µs) : 265, 409
. : milestone, 337,
basic (283.887 µs) : 273, 295
. : milestone, 284,
loop (8.948 ms) : 8925, 8970
. : milestone, 8948,
section candidate
noprobe (333.084 µs) : 271, 395
. : milestone, 333,
basic (281.062 µs) : 274, 288
. : milestone, 281,
loop (8.955 ms) : 8948, 8962
. : milestone, 8955,
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 62 metrics, 8 unstable metrics.
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~b2b51d152e, baseline=1.61.0-SNAPSHOT~fd65c0aa59
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.062 s) : 0, 1061736
Total [baseline] (11.052 s) : 0, 11052306
Agent [candidate] (1.061 s) : 0, 1060660
Total [candidate] (11.165 s) : 0, 11165485
section appsec
Agent [baseline] (1.241 s) : 0, 1240673
Total [baseline] (11.119 s) : 0, 11119071
Agent [candidate] (1.245 s) : 0, 1245497
Total [candidate] (11.164 s) : 0, 11163829
section iast
Agent [baseline] (1.227 s) : 0, 1227193
Total [baseline] (11.299 s) : 0, 11298690
Agent [candidate] (1.227 s) : 0, 1226906
Total [candidate] (11.394 s) : 0, 11393764
section profiling
Agent [baseline] (1.182 s) : 0, 1182095
Total [baseline] (11.042 s) : 0, 11041882
Agent [candidate] (1.181 s) : 0, 1180528
Total [candidate] (11.031 s) : 0, 11030558
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~b2b51d152e, baseline=1.61.0-SNAPSHOT~fd65c0aa59
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.182 ms) : 0, 1182
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (627.312 ms) : 0, 627312
BytebuddyAgent [candidate] (626.919 ms) : 0, 626919
AgentMeter [baseline] (29.399 ms) : 0, 29399
AgentMeter [candidate] (29.125 ms) : 0, 29125
GlobalTracer [baseline] (258.126 ms) : 0, 258126
GlobalTracer [candidate] (257.668 ms) : 0, 257668
AppSec [baseline] (31.769 ms) : 0, 31769
AppSec [candidate] (31.66 ms) : 0, 31660
Debugger [baseline] (59.788 ms) : 0, 59788
Debugger [candidate] (60.21 ms) : 0, 60210
Remote Config [baseline] (619.504 µs) : 0, 620
Remote Config [candidate] (595.412 µs) : 0, 595
Telemetry [baseline] (8.765 ms) : 0, 8765
Telemetry [candidate] (8.685 ms) : 0, 8685
Flare Poller [baseline] (8.777 ms) : 0, 8777
Flare Poller [candidate] (8.789 ms) : 0, 8789
section appsec
crashtracking [baseline] (1.19 ms) : 0, 1190
crashtracking [candidate] (1.189 ms) : 0, 1189
BytebuddyAgent [baseline] (654.536 ms) : 0, 654536
BytebuddyAgent [candidate] (657.479 ms) : 0, 657479
AgentMeter [baseline] (12.041 ms) : 0, 12041
AgentMeter [candidate] (12.046 ms) : 0, 12046
GlobalTracer [baseline] (256.956 ms) : 0, 256956
GlobalTracer [candidate] (257.705 ms) : 0, 257705
IAST [baseline] (23.935 ms) : 0, 23935
IAST [candidate] (24.078 ms) : 0, 24078
AppSec [baseline] (176.839 ms) : 0, 176839
AppSec [candidate] (177.207 ms) : 0, 177207
Debugger [baseline] (65.776 ms) : 0, 65776
Debugger [candidate] (66.259 ms) : 0, 66259
Remote Config [baseline] (564.121 µs) : 0, 564
Remote Config [candidate] (564.771 µs) : 0, 565
Telemetry [baseline] (8.938 ms) : 0, 8938
Telemetry [candidate] (9.115 ms) : 0, 9115
Flare Poller [baseline] (3.679 ms) : 0, 3679
Flare Poller [candidate] (3.642 ms) : 0, 3642
section iast
crashtracking [baseline] (1.191 ms) : 0, 1191
crashtracking [candidate] (1.194 ms) : 0, 1194
BytebuddyAgent [baseline] (795.589 ms) : 0, 795589
BytebuddyAgent [candidate] (795.305 ms) : 0, 795305
AgentMeter [baseline] (11.344 ms) : 0, 11344
AgentMeter [candidate] (11.342 ms) : 0, 11342
GlobalTracer [baseline] (247.426 ms) : 0, 247426
GlobalTracer [candidate] (247.222 ms) : 0, 247222
IAST [baseline] (25.144 ms) : 0, 25144
IAST [candidate] (25.203 ms) : 0, 25203
AppSec [baseline] (26.543 ms) : 0, 26543
AppSec [candidate] (26.46 ms) : 0, 26460
Debugger [baseline] (65.615 ms) : 0, 65615
Debugger [candidate] (70.451 ms) : 0, 70451
Remote Config [baseline] (517.929 µs) : 0, 518
Remote Config [candidate] (521.786 µs) : 0, 522
Telemetry [baseline] (13.333 ms) : 0, 13333
Telemetry [candidate] (9.69 ms) : 0, 9690
Flare Poller [baseline] (4.436 ms) : 0, 4436
Flare Poller [candidate] (3.44 ms) : 0, 3440
section profiling
crashtracking [baseline] (1.162 ms) : 0, 1162
crashtracking [candidate] (1.168 ms) : 0, 1168
BytebuddyAgent [baseline] (681.922 ms) : 0, 681922
BytebuddyAgent [candidate] (681.231 ms) : 0, 681231
AgentMeter [baseline] (8.645 ms) : 0, 8645
AgentMeter [candidate] (8.685 ms) : 0, 8685
GlobalTracer [baseline] (215.66 ms) : 0, 215660
GlobalTracer [candidate] (215.294 ms) : 0, 215294
AppSec [baseline] (31.964 ms) : 0, 31964
AppSec [candidate] (31.904 ms) : 0, 31904
Debugger [baseline] (62.206 ms) : 0, 62206
Debugger [candidate] (63.494 ms) : 0, 63494
Remote Config [baseline] (596.886 µs) : 0, 597
Remote Config [candidate] (580.597 µs) : 0, 581
Telemetry [baseline] (9.871 ms) : 0, 9871
Telemetry [candidate] (9.74 ms) : 0, 9740
Flare Poller [baseline] (5.078 ms) : 0, 5078
Flare Poller [candidate] (4.272 ms) : 0, 4272
ProfilingAgent [baseline] (94.006 ms) : 0, 94006
ProfilingAgent [candidate] (93.412 ms) : 0, 93412
Profiling [baseline] (94.578 ms) : 0, 94578
Profiling [candidate] (93.964 ms) : 0, 93964
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~b2b51d152e, baseline=1.61.0-SNAPSHOT~fd65c0aa59
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.067 s) : 0, 1066656
Total [baseline] (8.896 s) : 0, 8895888
Agent [candidate] (1.056 s) : 0, 1056449
Total [candidate] (8.797 s) : 0, 8796787
section iast
Agent [baseline] (1.226 s) : 0, 1225957
Total [baseline] (9.557 s) : 0, 9557034
Agent [candidate] (1.234 s) : 0, 1234194
Total [candidate] (9.564 s) : 0, 9563956
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~b2b51d152e, baseline=1.61.0-SNAPSHOT~fd65c0aa59
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.21 ms) : 0, 1210
crashtracking [candidate] (1.208 ms) : 0, 1208
BytebuddyAgent [baseline] (631.475 ms) : 0, 631475
BytebuddyAgent [candidate] (626.719 ms) : 0, 626719
AgentMeter [baseline] (29.463 ms) : 0, 29463
AgentMeter [candidate] (28.959 ms) : 0, 28959
GlobalTracer [baseline] (259.041 ms) : 0, 259041
GlobalTracer [candidate] (256.623 ms) : 0, 256623
AppSec [baseline] (31.999 ms) : 0, 31999
AppSec [candidate] (31.489 ms) : 0, 31489
Debugger [baseline] (59.163 ms) : 0, 59163
Debugger [candidate] (58.985 ms) : 0, 58985
Remote Config [baseline] (618.61 µs) : 0, 619
Remote Config [candidate] (590.844 µs) : 0, 591
Telemetry [baseline] (8.781 ms) : 0, 8781
Telemetry [candidate] (8.635 ms) : 0, 8635
Flare Poller [baseline] (8.72 ms) : 0, 8720
Flare Poller [candidate] (7.226 ms) : 0, 7226
section iast
crashtracking [baseline] (1.203 ms) : 0, 1203
crashtracking [candidate] (1.209 ms) : 0, 1209
BytebuddyAgent [baseline] (795.391 ms) : 0, 795391
BytebuddyAgent [candidate] (801.917 ms) : 0, 801917
AgentMeter [baseline] (11.339 ms) : 0, 11339
AgentMeter [candidate] (11.55 ms) : 0, 11550
GlobalTracer [baseline] (247.429 ms) : 0, 247429
GlobalTracer [candidate] (248.437 ms) : 0, 248437
IAST [baseline] (25.254 ms) : 0, 25254
IAST [candidate] (25.289 ms) : 0, 25289
AppSec [baseline] (26.449 ms) : 0, 26449
AppSec [candidate] (26.591 ms) : 0, 26591
Debugger [baseline] (62.561 ms) : 0, 62561
Debugger [candidate] (62.832 ms) : 0, 62832
Remote Config [baseline] (509.955 µs) : 0, 510
Remote Config [candidate] (536.53 µs) : 0, 537
Telemetry [baseline] (14.898 ms) : 0, 14898
Telemetry [candidate] (14.817 ms) : 0, 14817
Flare Poller [baseline] (4.855 ms) : 0, 4855
Flare Poller [candidate] (4.824 ms) : 0, 4824
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 4 performance regressions! Performance is the same for 12 metrics, 17 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~b2b51d152e, baseline=1.61.0-SNAPSHOT~fd65c0aa59
dateFormat X
axisFormat %s
section baseline
no_agent (1.182 ms) : 1171, 1194
. : milestone, 1182,
iast (3.184 ms) : 3143, 3224
. : milestone, 3184,
iast_FULL (5.957 ms) : 5898, 6017
. : milestone, 5957,
iast_GLOBAL (3.358 ms) : 3303, 3413
. : milestone, 3358,
profiling (2.008 ms) : 1990, 2026
. : milestone, 2008,
tracing (1.792 ms) : 1778, 1806
. : milestone, 1792,
section candidate
no_agent (1.177 ms) : 1166, 1188
. : milestone, 1177,
iast (3.283 ms) : 3239, 3327
. : milestone, 3283,
iast_FULL (5.723 ms) : 5666, 5780
. : milestone, 5723,
iast_GLOBAL (3.576 ms) : 3517, 3635
. : milestone, 3576,
profiling (2.434 ms) : 2409, 2458
. : milestone, 2434,
tracing (1.829 ms) : 1813, 1845
. : milestone, 1829,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~b2b51d152e, baseline=1.61.0-SNAPSHOT~fd65c0aa59
dateFormat X
axisFormat %s
section baseline
no_agent (17.97 ms) : 17785, 18156
. : milestone, 17970,
appsec (18.734 ms) : 18542, 18925
. : milestone, 18734,
code_origins (17.947 ms) : 17772, 18123
. : milestone, 17947,
iast (17.835 ms) : 17653, 18017
. : milestone, 17835,
profiling (18.637 ms) : 18452, 18822
. : milestone, 18637,
tracing (18.502 ms) : 18314, 18691
. : milestone, 18502,
section candidate
no_agent (18.383 ms) : 18196, 18569
. : milestone, 18383,
appsec (19.836 ms) : 19629, 20042
. : milestone, 19836,
code_origins (17.904 ms) : 17727, 18080
. : milestone, 17904,
iast (17.981 ms) : 17801, 18161
. : milestone, 17981,
profiling (18.688 ms) : 18502, 18874
. : milestone, 18688,
tracing (17.822 ms) : 17646, 17998
. : milestone, 17822,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~b2b51d152e, baseline=1.61.0-SNAPSHOT~fd65c0aa59
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1462, 1485
. : milestone, 1474,
appsec (3.811 ms) : 3589, 4034
. : milestone, 3811,
iast (2.268 ms) : 2198, 2338
. : milestone, 2268,
iast_GLOBAL (2.3 ms) : 2230, 2369
. : milestone, 2300,
profiling (2.084 ms) : 2030, 2139
. : milestone, 2084,
tracing (2.06 ms) : 2007, 2113
. : milestone, 2060,
section candidate
no_agent (1.471 ms) : 1460, 1483
. : milestone, 1471,
appsec (3.75 ms) : 3533, 3968
. : milestone, 3750,
iast (2.258 ms) : 2189, 2326
. : milestone, 2258,
iast_GLOBAL (2.304 ms) : 2235, 2373
. : milestone, 2304,
profiling (2.105 ms) : 2049, 2161
. : milestone, 2105,
tracing (2.074 ms) : 2020, 2128
. : milestone, 2074,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~b2b51d152e, baseline=1.61.0-SNAPSHOT~fd65c0aa59
dateFormat X
axisFormat %s
section baseline
no_agent (14.991 s) : 14991000, 14991000
. : milestone, 14991000,
appsec (14.706 s) : 14706000, 14706000
. : milestone, 14706000,
iast (18.075 s) : 18075000, 18075000
. : milestone, 18075000,
iast_GLOBAL (17.692 s) : 17692000, 17692000
. : milestone, 17692000,
profiling (14.782 s) : 14782000, 14782000
. : milestone, 14782000,
tracing (14.93 s) : 14930000, 14930000
. : milestone, 14930000,
section candidate
no_agent (14.795 s) : 14795000, 14795000
. : milestone, 14795000,
appsec (15.233 s) : 15233000, 15233000
. : milestone, 15233000,
iast (18.005 s) : 18005000, 18005000
. : milestone, 18005000,
iast_GLOBAL (17.686 s) : 17686000, 17686000
. : milestone, 17686000,
profiling (14.742 s) : 14742000, 14742000
. : milestone, 14742000,
tracing (14.977 s) : 14977000, 14977000
. : milestone, 14977000,
|
To avoid JVM bug, we detect and prevent retransformation of record with type annotation on record component. see https://bugs.openjdk.org/browse/JDK-8376185
dbe2e3e to
344c6d2
Compare
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
3745249
into
master
What Does This Do
To avoid JVM bug, we detect and prevent retransformation of record with type annotation on record component.
see https://bugs.openjdk.org/browse/JDK-8376185
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: DEBUG-5279
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.