Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 65 metrics, 6 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~3bee6c3843, baseline=1.61.0-SNAPSHOT~8185dcf699
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.069 s) : 0, 1068922
Total [baseline] (8.892 s) : 0, 8891929
Agent [candidate] (1.065 s) : 0, 1065187
Total [candidate] (8.855 s) : 0, 8855206
section iast
Agent [baseline] (1.225 s) : 0, 1225056
Total [baseline] (9.586 s) : 0, 9586439
Agent [candidate] (1.227 s) : 0, 1226870
Total [candidate] (9.653 s) : 0, 9652622
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~3bee6c3843, baseline=1.61.0-SNAPSHOT~8185dcf699
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.214 ms) : 0, 1214
crashtracking [candidate] (1.216 ms) : 0, 1216
BytebuddyAgent [baseline] (633.124 ms) : 0, 633124
BytebuddyAgent [candidate] (632.337 ms) : 0, 632337
AgentMeter [baseline] (29.314 ms) : 0, 29314
AgentMeter [candidate] (29.245 ms) : 0, 29245
GlobalTracer [baseline] (258.549 ms) : 0, 258549
GlobalTracer [candidate] (258.674 ms) : 0, 258674
AppSec [baseline] (31.781 ms) : 0, 31781
AppSec [candidate] (31.837 ms) : 0, 31837
Debugger [baseline] (59.061 ms) : 0, 59061
Debugger [candidate] (59.055 ms) : 0, 59055
Remote Config [baseline] (622.81 µs) : 0, 623
Remote Config [candidate] (614.342 µs) : 0, 614
Telemetry [baseline] (8.696 ms) : 0, 8696
Telemetry [candidate] (8.688 ms) : 0, 8688
Flare Poller [baseline] (10.347 ms) : 0, 10347
Flare Poller [candidate] (7.252 ms) : 0, 7252
section iast
crashtracking [baseline] (1.199 ms) : 0, 1199
crashtracking [candidate] (1.207 ms) : 0, 1207
BytebuddyAgent [baseline] (794.404 ms) : 0, 794404
BytebuddyAgent [candidate] (795.695 ms) : 0, 795695
AgentMeter [baseline] (11.298 ms) : 0, 11298
AgentMeter [candidate] (11.352 ms) : 0, 11352
GlobalTracer [baseline] (247.358 ms) : 0, 247358
GlobalTracer [candidate] (247.539 ms) : 0, 247539
IAST [baseline] (25.149 ms) : 0, 25149
IAST [candidate] (25.173 ms) : 0, 25173
AppSec [baseline] (26.353 ms) : 0, 26353
AppSec [candidate] (26.35 ms) : 0, 26350
Debugger [baseline] (62.9 ms) : 0, 62900
Debugger [candidate] (62.983 ms) : 0, 62983
Remote Config [baseline] (517.532 µs) : 0, 518
Remote Config [candidate] (514.07 µs) : 0, 514
Telemetry [baseline] (14.811 ms) : 0, 14811
Telemetry [candidate] (14.934 ms) : 0, 14934
Flare Poller [baseline] (4.946 ms) : 0, 4946
Flare Poller [candidate] (4.929 ms) : 0, 4929
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~3bee6c3843, baseline=1.61.0-SNAPSHOT~8185dcf699
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.067 s) : 0, 1067094
Total [baseline] (11.1 s) : 0, 11100204
Agent [candidate] (1.061 s) : 0, 1060548
Total [candidate] (11.146 s) : 0, 11146135
section appsec
Agent [baseline] (1.246 s) : 0, 1245602
Total [baseline] (11.285 s) : 0, 11284997
Agent [candidate] (1.255 s) : 0, 1255225
Total [candidate] (11.207 s) : 0, 11207313
section iast
Agent [baseline] (1.23 s) : 0, 1229712
Total [baseline] (11.446 s) : 0, 11446212
Agent [candidate] (1.229 s) : 0, 1228741
Total [candidate] (11.325 s) : 0, 11324855
section profiling
Agent [baseline] (1.179 s) : 0, 1179426
Total [baseline] (11.092 s) : 0, 11092209
Agent [candidate] (1.183 s) : 0, 1183258
Total [candidate] (11.081 s) : 0, 11080510
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~3bee6c3843, baseline=1.61.0-SNAPSHOT~8185dcf699
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.215 ms) : 0, 1215
crashtracking [candidate] (1.203 ms) : 0, 1203
BytebuddyAgent [baseline] (632.078 ms) : 0, 632078
BytebuddyAgent [candidate] (629.982 ms) : 0, 629982
AgentMeter [baseline] (29.314 ms) : 0, 29314
AgentMeter [candidate] (29.204 ms) : 0, 29204
GlobalTracer [baseline] (258.648 ms) : 0, 258648
GlobalTracer [candidate] (257.888 ms) : 0, 257888
AppSec [baseline] (31.762 ms) : 0, 31762
AppSec [candidate] (31.642 ms) : 0, 31642
Debugger [baseline] (59.735 ms) : 0, 59735
Debugger [candidate] (59.469 ms) : 0, 59469
Remote Config [baseline] (621.556 µs) : 0, 622
Remote Config [candidate] (602.869 µs) : 0, 603
Telemetry [baseline] (8.842 ms) : 0, 8842
Telemetry [candidate] (8.7 ms) : 0, 8700
Flare Poller [baseline] (8.658 ms) : 0, 8658
Flare Poller [candidate] (5.77 ms) : 0, 5770
section appsec
crashtracking [baseline] (1.189 ms) : 0, 1189
crashtracking [candidate] (1.212 ms) : 0, 1212
BytebuddyAgent [baseline] (656.786 ms) : 0, 656786
BytebuddyAgent [candidate] (663.473 ms) : 0, 663473
AgentMeter [baseline] (12.088 ms) : 0, 12088
AgentMeter [candidate] (12.219 ms) : 0, 12219
GlobalTracer [baseline] (258.149 ms) : 0, 258149
GlobalTracer [candidate] (259.828 ms) : 0, 259828
IAST [baseline] (23.995 ms) : 0, 23995
IAST [candidate] (24.213 ms) : 0, 24213
AppSec [baseline] (177.546 ms) : 0, 177546
AppSec [candidate] (178.559 ms) : 0, 178559
Debugger [baseline] (66.359 ms) : 0, 66359
Debugger [candidate] (66.109 ms) : 0, 66109
Remote Config [baseline] (569.757 µs) : 0, 570
Remote Config [candidate] (568.014 µs) : 0, 568
Telemetry [baseline] (9.023 ms) : 0, 9023
Telemetry [candidate] (9.009 ms) : 0, 9009
Flare Poller [baseline] (3.664 ms) : 0, 3664
Flare Poller [candidate] (3.623 ms) : 0, 3623
section iast
crashtracking [baseline] (1.193 ms) : 0, 1193
crashtracking [candidate] (1.199 ms) : 0, 1199
BytebuddyAgent [baseline] (795.837 ms) : 0, 795837
BytebuddyAgent [candidate] (796.526 ms) : 0, 796526
AgentMeter [baseline] (11.347 ms) : 0, 11347
AgentMeter [candidate] (11.338 ms) : 0, 11338
GlobalTracer [baseline] (248.948 ms) : 0, 248948
GlobalTracer [candidate] (248.016 ms) : 0, 248016
IAST [baseline] (25.35 ms) : 0, 25350
IAST [candidate] (25.15 ms) : 0, 25150
AppSec [baseline] (26.698 ms) : 0, 26698
AppSec [candidate] (26.518 ms) : 0, 26518
Debugger [baseline] (64.55 ms) : 0, 64550
Debugger [candidate] (65.06 ms) : 0, 65060
Remote Config [baseline] (523.267 µs) : 0, 523
Remote Config [candidate] (1.147 ms) : 0, 1147
Telemetry [baseline] (14.416 ms) : 0, 14416
Telemetry [candidate] (13.276 ms) : 0, 13276
Flare Poller [baseline] (4.778 ms) : 0, 4778
Flare Poller [candidate] (4.436 ms) : 0, 4436
section profiling
crashtracking [baseline] (1.171 ms) : 0, 1171
crashtracking [candidate] (1.168 ms) : 0, 1168
BytebuddyAgent [baseline] (681.076 ms) : 0, 681076
BytebuddyAgent [candidate] (682.808 ms) : 0, 682808
AgentMeter [baseline] (8.629 ms) : 0, 8629
AgentMeter [candidate] (8.661 ms) : 0, 8661
GlobalTracer [baseline] (215.054 ms) : 0, 215054
GlobalTracer [candidate] (215.739 ms) : 0, 215739
AppSec [baseline] (31.759 ms) : 0, 31759
AppSec [candidate] (32.031 ms) : 0, 32031
Debugger [baseline] (65.329 ms) : 0, 65329
Debugger [candidate] (64.618 ms) : 0, 64618
Remote Config [baseline] (581.024 µs) : 0, 581
Remote Config [candidate] (606.084 µs) : 0, 606
Telemetry [baseline] (8.193 ms) : 0, 8193
Telemetry [candidate] (8.245 ms) : 0, 8245
Flare Poller [baseline] (3.467 ms) : 0, 3467
Flare Poller [candidate] (4.239 ms) : 0, 4239
ProfilingAgent [baseline] (93.698 ms) : 0, 93698
ProfilingAgent [candidate] (94.413 ms) : 0, 94413
Profiling [baseline] (94.257 ms) : 0, 94257
Profiling [candidate] (94.979 ms) : 0, 94979
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 0 performance regressions! Performance is the same for 19 metrics, 15 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~3bee6c3843, baseline=1.61.0-SNAPSHOT~8185dcf699
dateFormat X
axisFormat %s
section baseline
no_agent (1.204 ms) : 1192, 1217
. : milestone, 1204,
iast (3.181 ms) : 3136, 3226
. : milestone, 3181,
iast_FULL (5.922 ms) : 5863, 5981
. : milestone, 5922,
iast_GLOBAL (3.613 ms) : 3560, 3665
. : milestone, 3613,
profiling (2.226 ms) : 2205, 2247
. : milestone, 2226,
tracing (1.783 ms) : 1769, 1797
. : milestone, 1783,
section candidate
no_agent (1.17 ms) : 1159, 1182
. : milestone, 1170,
iast (3.113 ms) : 3074, 3151
. : milestone, 3113,
iast_FULL (5.842 ms) : 5784, 5900
. : milestone, 5842,
iast_GLOBAL (3.52 ms) : 3465, 3575
. : milestone, 3520,
profiling (2.006 ms) : 1988, 2025
. : milestone, 2006,
tracing (1.813 ms) : 1798, 1827
. : milestone, 1813,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~3bee6c3843, baseline=1.61.0-SNAPSHOT~8185dcf699
dateFormat X
axisFormat %s
section baseline
no_agent (19.324 ms) : 19129, 19518
. : milestone, 19324,
appsec (18.742 ms) : 18551, 18934
. : milestone, 18742,
code_origins (18.201 ms) : 18023, 18380
. : milestone, 18201,
iast (18.554 ms) : 18369, 18739
. : milestone, 18554,
profiling (19.007 ms) : 18813, 19200
. : milestone, 19007,
tracing (17.995 ms) : 17815, 18175
. : milestone, 17995,
section candidate
no_agent (18.124 ms) : 17939, 18308
. : milestone, 18124,
appsec (18.548 ms) : 18356, 18739
. : milestone, 18548,
code_origins (18.137 ms) : 17954, 18320
. : milestone, 18137,
iast (17.87 ms) : 17691, 18048
. : milestone, 17870,
profiling (19.138 ms) : 18949, 19327
. : milestone, 19138,
tracing (17.748 ms) : 17573, 17923
. : milestone, 17748,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~3bee6c3843, baseline=1.61.0-SNAPSHOT~8185dcf699
dateFormat X
axisFormat %s
section baseline
no_agent (1.477 ms) : 1466, 1489
. : milestone, 1477,
appsec (3.806 ms) : 3585, 4027
. : milestone, 3806,
iast (2.261 ms) : 2192, 2330
. : milestone, 2261,
iast_GLOBAL (2.295 ms) : 2225, 2364
. : milestone, 2295,
profiling (2.077 ms) : 2022, 2131
. : milestone, 2077,
tracing (2.075 ms) : 2021, 2129
. : milestone, 2075,
section candidate
no_agent (1.473 ms) : 1461, 1484
. : milestone, 1473,
appsec (2.527 ms) : 2472, 2582
. : milestone, 2527,
iast (2.246 ms) : 2177, 2315
. : milestone, 2246,
iast_GLOBAL (2.3 ms) : 2231, 2370
. : milestone, 2300,
profiling (2.092 ms) : 2037, 2147
. : milestone, 2092,
tracing (2.056 ms) : 2003, 2109
. : milestone, 2056,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~3bee6c3843, baseline=1.61.0-SNAPSHOT~8185dcf699
dateFormat X
axisFormat %s
section baseline
no_agent (15.573 s) : 15573000, 15573000
. : milestone, 15573000,
appsec (14.937 s) : 14937000, 14937000
. : milestone, 14937000,
iast (17.945 s) : 17945000, 17945000
. : milestone, 17945000,
iast_GLOBAL (17.84 s) : 17840000, 17840000
. : milestone, 17840000,
profiling (14.933 s) : 14933000, 14933000
. : milestone, 14933000,
tracing (14.961 s) : 14961000, 14961000
. : milestone, 14961000,
section candidate
no_agent (15.418 s) : 15418000, 15418000
. : milestone, 15418000,
appsec (15.08 s) : 15080000, 15080000
. : milestone, 15080000,
iast (18.165 s) : 18165000, 18165000
. : milestone, 18165000,
iast_GLOBAL (17.656 s) : 17656000, 17656000
. : milestone, 17656000,
profiling (15.155 s) : 15155000, 15155000
. : milestone, 15155000,
tracing (14.862 s) : 14862000, 14862000
. : milestone, 14862000,
|
|
In a separate PR, I'm going to try to create a benchmark to show why this happens. |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
PR can't be merged according to github policy |
What Does This Do
Use forEach in CoreTracer.write to avoid ArrayList$Itr allocation
Motivation
In span creation stress test: 16 threads x 10,000,000 traces x 2 spans, saves 5 GiB of allocation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.