Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 4 performance improvements and 2 performance regressions! Performance is the same for 55 metrics, 10 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~013df99afb, baseline=1.61.0-SNAPSHOT~8185dcf699
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.064 s) : 0, 1063680
Total [baseline] (8.826 s) : 0, 8825845
Agent [candidate] (1.062 s) : 0, 1062053
Total [candidate] (8.853 s) : 0, 8853304
section iast
Agent [baseline] (1.233 s) : 0, 1233252
Total [baseline] (9.538 s) : 0, 9538217
Agent [candidate] (1.224 s) : 0, 1224448
Total [candidate] (9.608 s) : 0, 9608057
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~013df99afb, baseline=1.61.0-SNAPSHOT~8185dcf699
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.208 ms) : 0, 1208
crashtracking [candidate] (1.206 ms) : 0, 1206
BytebuddyAgent [baseline] (632.012 ms) : 0, 632012
BytebuddyAgent [candidate] (631.188 ms) : 0, 631188
AgentMeter [baseline] (29.394 ms) : 0, 29394
AgentMeter [candidate] (29.223 ms) : 0, 29223
GlobalTracer [baseline] (258.183 ms) : 0, 258183
GlobalTracer [candidate] (258.233 ms) : 0, 258233
AppSec [baseline] (31.757 ms) : 0, 31757
AppSec [candidate] (31.786 ms) : 0, 31786
Debugger [baseline] (59.05 ms) : 0, 59050
Debugger [candidate] (59.031 ms) : 0, 59031
Remote Config [baseline] (629.242 µs) : 0, 629
Remote Config [candidate] (600.156 µs) : 0, 600
Telemetry [baseline] (8.682 ms) : 0, 8682
Telemetry [candidate] (8.169 ms) : 0, 8169
Flare Poller [baseline] (6.518 ms) : 0, 6518
Flare Poller [candidate] (6.461 ms) : 0, 6461
section iast
crashtracking [baseline] (1.201 ms) : 0, 1201
crashtracking [candidate] (1.213 ms) : 0, 1213
BytebuddyAgent [baseline] (801.309 ms) : 0, 801309
BytebuddyAgent [candidate] (793.946 ms) : 0, 793946
AgentMeter [baseline] (11.567 ms) : 0, 11567
AgentMeter [candidate] (11.319 ms) : 0, 11319
GlobalTracer [baseline] (248.235 ms) : 0, 248235
GlobalTracer [candidate] (247.32 ms) : 0, 247320
IAST [baseline] (25.273 ms) : 0, 25273
IAST [candidate] (25.364 ms) : 0, 25364
AppSec [baseline] (26.579 ms) : 0, 26579
AppSec [candidate] (26.478 ms) : 0, 26478
Debugger [baseline] (62.66 ms) : 0, 62660
Debugger [candidate] (64.857 ms) : 0, 64857
Remote Config [baseline] (512.341 µs) : 0, 512
Remote Config [candidate] (523.01 µs) : 0, 523
Telemetry [baseline] (14.813 ms) : 0, 14813
Telemetry [candidate] (12.87 ms) : 0, 12870
Flare Poller [baseline] (4.872 ms) : 0, 4872
Flare Poller [candidate] (4.483 ms) : 0, 4483
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~013df99afb, baseline=1.61.0-SNAPSHOT~8185dcf699
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.065 s) : 0, 1064684
Total [baseline] (11.079 s) : 0, 11079460
Agent [candidate] (1.057 s) : 0, 1056862
Total [candidate] (11.135 s) : 0, 11134797
section appsec
Agent [baseline] (1.245 s) : 0, 1245238
Total [baseline] (11.105 s) : 0, 11105168
Agent [candidate] (1.249 s) : 0, 1249195
Total [candidate] (11.237 s) : 0, 11236634
section iast
Agent [baseline] (1.227 s) : 0, 1226667
Total [baseline] (11.319 s) : 0, 11319201
Agent [candidate] (1.241 s) : 0, 1241302
Total [candidate] (11.416 s) : 0, 11416173
section profiling
Agent [baseline] (1.183 s) : 0, 1183179
Total [baseline] (11.107 s) : 0, 11106578
Agent [candidate] (1.179 s) : 0, 1178607
Total [candidate] (11.074 s) : 0, 11074378
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~013df99afb, baseline=1.61.0-SNAPSHOT~8185dcf699
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.198 ms) : 0, 1198
crashtracking [candidate] (1.207 ms) : 0, 1207
BytebuddyAgent [baseline] (631.078 ms) : 0, 631078
BytebuddyAgent [candidate] (628.505 ms) : 0, 628505
AgentMeter [baseline] (29.311 ms) : 0, 29311
AgentMeter [candidate] (29.033 ms) : 0, 29033
GlobalTracer [baseline] (258.226 ms) : 0, 258226
GlobalTracer [candidate] (256.772 ms) : 0, 256772
AppSec [baseline] (31.641 ms) : 0, 31641
AppSec [candidate] (31.666 ms) : 0, 31666
Debugger [baseline] (59.665 ms) : 0, 59665
Debugger [candidate] (59.369 ms) : 0, 59369
Remote Config [baseline] (620.742 µs) : 0, 621
Remote Config [candidate] (588.449 µs) : 0, 588
Telemetry [baseline] (8.751 ms) : 0, 8751
Telemetry [candidate] (8.0 ms) : 0, 8000
Flare Poller [baseline] (7.993 ms) : 0, 7993
Flare Poller [candidate] (5.788 ms) : 0, 5788
section appsec
crashtracking [baseline] (1.188 ms) : 0, 1188
crashtracking [candidate] (1.206 ms) : 0, 1206
BytebuddyAgent [baseline] (656.824 ms) : 0, 656824
BytebuddyAgent [candidate] (660.288 ms) : 0, 660288
AgentMeter [baseline] (12.088 ms) : 0, 12088
AgentMeter [candidate] (12.076 ms) : 0, 12076
GlobalTracer [baseline] (258.355 ms) : 0, 258355
GlobalTracer [candidate] (258.572 ms) : 0, 258572
IAST [baseline] (23.988 ms) : 0, 23988
IAST [candidate] (24.288 ms) : 0, 24288
AppSec [baseline] (177.908 ms) : 0, 177908
AppSec [candidate] (177.953 ms) : 0, 177953
Debugger [baseline] (65.586 ms) : 0, 65586
Debugger [candidate] (65.938 ms) : 0, 65938
Remote Config [baseline] (572.384 µs) : 0, 572
Remote Config [candidate] (607.944 µs) : 0, 608
Telemetry [baseline] (8.885 ms) : 0, 8885
Telemetry [candidate] (8.277 ms) : 0, 8277
Flare Poller [baseline] (3.628 ms) : 0, 3628
Flare Poller [candidate] (3.61 ms) : 0, 3610
section iast
crashtracking [baseline] (1.199 ms) : 0, 1199
crashtracking [candidate] (1.202 ms) : 0, 1202
BytebuddyAgent [baseline] (795.597 ms) : 0, 795597
BytebuddyAgent [candidate] (806.111 ms) : 0, 806111
AgentMeter [baseline] (11.358 ms) : 0, 11358
AgentMeter [candidate] (11.505 ms) : 0, 11505
GlobalTracer [baseline] (247.182 ms) : 0, 247182
GlobalTracer [candidate] (250.538 ms) : 0, 250538
IAST [baseline] (25.021 ms) : 0, 25021
IAST [candidate] (25.671 ms) : 0, 25671
AppSec [baseline] (26.371 ms) : 0, 26371
AppSec [candidate] (26.932 ms) : 0, 26932
Debugger [baseline] (64.332 ms) : 0, 64332
Debugger [candidate] (68.657 ms) : 0, 68657
Remote Config [baseline] (521.296 µs) : 0, 521
Remote Config [candidate] (540.487 µs) : 0, 540
Telemetry [baseline] (14.275 ms) : 0, 14275
Telemetry [candidate] (10.232 ms) : 0, 10232
Flare Poller [baseline] (4.778 ms) : 0, 4778
Flare Poller [candidate] (3.664 ms) : 0, 3664
section profiling
crashtracking [baseline] (1.172 ms) : 0, 1172
crashtracking [candidate] (1.165 ms) : 0, 1165
BytebuddyAgent [baseline] (683.709 ms) : 0, 683709
BytebuddyAgent [candidate] (679.979 ms) : 0, 679979
AgentMeter [baseline] (8.675 ms) : 0, 8675
AgentMeter [candidate] (8.618 ms) : 0, 8618
GlobalTracer [baseline] (215.7 ms) : 0, 215700
GlobalTracer [candidate] (215.277 ms) : 0, 215277
AppSec [baseline] (32.009 ms) : 0, 32009
AppSec [candidate] (32.19 ms) : 0, 32190
Debugger [baseline] (64.602 ms) : 0, 64602
Debugger [candidate] (62.926 ms) : 0, 62926
Remote Config [baseline] (580.57 µs) : 0, 581
Remote Config [candidate] (580.408 µs) : 0, 580
Telemetry [baseline] (8.929 ms) : 0, 8929
Telemetry [candidate] (9.234 ms) : 0, 9234
Flare Poller [baseline] (3.488 ms) : 0, 3488
Flare Poller [candidate] (4.253 ms) : 0, 4253
ProfilingAgent [baseline] (93.378 ms) : 0, 93378
ProfilingAgent [candidate] (93.686 ms) : 0, 93686
Profiling [baseline] (93.95 ms) : 0, 93950
Profiling [candidate] (94.24 ms) : 0, 94240
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 4 performance regressions! Performance is the same for 14 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~013df99afb, baseline=1.61.0-SNAPSHOT~8185dcf699
dateFormat X
axisFormat %s
section baseline
no_agent (19.994 ms) : 19788, 20200
. : milestone, 19994,
appsec (19.503 ms) : 19303, 19704
. : milestone, 19503,
code_origins (18.364 ms) : 18176, 18551
. : milestone, 18364,
iast (18.487 ms) : 18305, 18670
. : milestone, 18487,
profiling (19.933 ms) : 19734, 20132
. : milestone, 19933,
tracing (18.622 ms) : 18434, 18810
. : milestone, 18622,
section candidate
no_agent (18.26 ms) : 18072, 18448
. : milestone, 18260,
appsec (19.208 ms) : 19010, 19406
. : milestone, 19208,
code_origins (18.438 ms) : 18253, 18622
. : milestone, 18438,
iast (18.053 ms) : 17870, 18237
. : milestone, 18053,
profiling (21.267 ms) : 21047, 21486
. : milestone, 21267,
tracing (18.037 ms) : 17858, 18216
. : milestone, 18037,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~013df99afb, baseline=1.61.0-SNAPSHOT~8185dcf699
dateFormat X
axisFormat %s
section baseline
no_agent (1.324 ms) : 1310, 1337
. : milestone, 1324,
iast (3.496 ms) : 3441, 3552
. : milestone, 3496,
iast_FULL (6.328 ms) : 6262, 6393
. : milestone, 6328,
iast_GLOBAL (3.752 ms) : 3685, 3819
. : milestone, 3752,
profiling (2.408 ms) : 2385, 2432
. : milestone, 2408,
tracing (1.923 ms) : 1907, 1939
. : milestone, 1923,
section candidate
no_agent (1.284 ms) : 1271, 1296
. : milestone, 1284,
iast (3.527 ms) : 3474, 3579
. : milestone, 3527,
iast_FULL (6.547 ms) : 6478, 6617
. : milestone, 6547,
iast_GLOBAL (3.775 ms) : 3705, 3846
. : milestone, 3775,
profiling (2.734 ms) : 2705, 2762
. : milestone, 2734,
tracing (1.966 ms) : 1949, 1982
. : milestone, 1966,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~013df99afb, baseline=1.61.0-SNAPSHOT~8185dcf699
dateFormat X
axisFormat %s
section baseline
no_agent (1.476 ms) : 1465, 1488
. : milestone, 1476,
appsec (3.814 ms) : 3592, 4036
. : milestone, 3814,
iast (2.262 ms) : 2193, 2331
. : milestone, 2262,
iast_GLOBAL (2.306 ms) : 2236, 2375
. : milestone, 2306,
profiling (2.541 ms) : 2373, 2709
. : milestone, 2541,
tracing (2.093 ms) : 2038, 2147
. : milestone, 2093,
section candidate
no_agent (1.478 ms) : 1467, 1490
. : milestone, 1478,
appsec (3.804 ms) : 3582, 4026
. : milestone, 3804,
iast (2.267 ms) : 2198, 2336
. : milestone, 2267,
iast_GLOBAL (2.307 ms) : 2238, 2376
. : milestone, 2307,
profiling (2.095 ms) : 2040, 2150
. : milestone, 2095,
tracing (2.078 ms) : 2025, 2132
. : milestone, 2078,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~013df99afb, baseline=1.61.0-SNAPSHOT~8185dcf699
dateFormat X
axisFormat %s
section baseline
no_agent (14.998 s) : 14998000, 14998000
. : milestone, 14998000,
appsec (15.175 s) : 15175000, 15175000
. : milestone, 15175000,
iast (18.369 s) : 18369000, 18369000
. : milestone, 18369000,
iast_GLOBAL (17.787 s) : 17787000, 17787000
. : milestone, 17787000,
profiling (14.858 s) : 14858000, 14858000
. : milestone, 14858000,
tracing (15.017 s) : 15017000, 15017000
. : milestone, 15017000,
section candidate
no_agent (15.538 s) : 15538000, 15538000
. : milestone, 15538000,
appsec (15.13 s) : 15130000, 15130000
. : milestone, 15130000,
iast (18.086 s) : 18086000, 18086000
. : milestone, 18086000,
iast_GLOBAL (18.005 s) : 18005000, 18005000
. : milestone, 18005000,
profiling (14.945 s) : 14945000, 14945000
. : milestone, 14945000,
tracing (15.141 s) : 15141000, 15141000
. : milestone, 15141000,
|
dd-trace-core/src/main/java/datadog/trace/common/metrics/SerializingMetricWriter.java
Outdated
Show resolved
Hide resolved
dd-trace-core/src/main/java/datadog/trace/common/metrics/SerializingMetricWriter.java
Outdated
Show resolved
Hide resolved
dd-trace-core/src/test/groovy/datadog/trace/common/metrics/SerializingMetricWriterTest.groovy
Outdated
Show resolved
Hide resolved
|
Thanks for that omission in the stats |
3807b33 to
926d4bb
Compare
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
The merge request has been interrupted because the build 102610314 took longer than expected. The current limit for the base branch 'master' is 120 minutes. |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in Use ⏳ Processing |
What Does This Do
Add the GitCommitSha missing field to the Client Stats payload when the info is available
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.