Change MethodParameters detection reporting#10849
Conversation
When MethodParameters is detected we bail out instrumentation but report diagnostics message as error. Logging is now in debug instead of warning or error
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (312.85 µs) : 287, 338
. : milestone, 313,
basic (276.648 µs) : 270, 283
. : milestone, 277,
loop (8.948 ms) : 8942, 8953
. : milestone, 8948,
section candidate
noprobe (323.744 µs) : 278, 370
. : milestone, 324,
basic (278.571 µs) : 271, 286
. : milestone, 279,
loop (8.942 ms) : 8937, 8947
. : milestone, 8942,
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 62 metrics, 9 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~c7b9bcaa7d, baseline=1.61.0-SNAPSHOT~52d1e1902e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.061 s) : 0, 1060530
Total [baseline] (8.843 s) : 0, 8842768
Agent [candidate] (1.059 s) : 0, 1058602
Total [candidate] (8.849 s) : 0, 8849475
section iast
Agent [baseline] (1.227 s) : 0, 1226851
Total [baseline] (9.628 s) : 0, 9628315
Agent [candidate] (1.231 s) : 0, 1231406
Total [candidate] (9.583 s) : 0, 9583263
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~c7b9bcaa7d, baseline=1.61.0-SNAPSHOT~52d1e1902e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.217 ms) : 0, 1217
crashtracking [candidate] (1.192 ms) : 0, 1192
BytebuddyAgent [baseline] (630.65 ms) : 0, 630650
BytebuddyAgent [candidate] (626.532 ms) : 0, 626532
AgentMeter [baseline] (28.888 ms) : 0, 28888
AgentMeter [candidate] (29.077 ms) : 0, 29077
GlobalTracer [baseline] (256.401 ms) : 0, 256401
GlobalTracer [candidate] (256.972 ms) : 0, 256972
AppSec [baseline] (31.476 ms) : 0, 31476
AppSec [candidate] (31.583 ms) : 0, 31583
Debugger [baseline] (58.535 ms) : 0, 58535
Debugger [candidate] (58.601 ms) : 0, 58601
Remote Config [baseline] (608.847 µs) : 0, 609
Remote Config [candidate] (613.216 µs) : 0, 613
Telemetry [baseline] (8.622 ms) : 0, 8622
Telemetry [candidate] (8.612 ms) : 0, 8612
Flare Poller [baseline] (7.862 ms) : 0, 7862
Flare Poller [candidate] (9.408 ms) : 0, 9408
section iast
crashtracking [baseline] (1.204 ms) : 0, 1204
crashtracking [candidate] (1.205 ms) : 0, 1205
BytebuddyAgent [baseline] (796.361 ms) : 0, 796361
BytebuddyAgent [candidate] (799.923 ms) : 0, 799923
AgentMeter [baseline] (11.559 ms) : 0, 11559
AgentMeter [candidate] (11.572 ms) : 0, 11572
GlobalTracer [baseline] (246.932 ms) : 0, 246932
GlobalTracer [candidate] (248.045 ms) : 0, 248045
IAST [baseline] (25.267 ms) : 0, 25267
IAST [candidate] (25.34 ms) : 0, 25340
AppSec [baseline] (26.456 ms) : 0, 26456
AppSec [candidate] (26.497 ms) : 0, 26497
Debugger [baseline] (62.697 ms) : 0, 62697
Debugger [candidate] (62.561 ms) : 0, 62561
Remote Config [baseline] (1.179 ms) : 0, 1179
Remote Config [candidate] (508.311 µs) : 0, 508
Telemetry [baseline] (14.337 ms) : 0, 14337
Telemetry [candidate] (14.733 ms) : 0, 14733
Flare Poller [baseline] (4.727 ms) : 0, 4727
Flare Poller [candidate] (4.871 ms) : 0, 4871
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~c7b9bcaa7d, baseline=1.61.0-SNAPSHOT~52d1e1902e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.065 s) : 0, 1065247
Total [baseline] (11.229 s) : 0, 11229220
Agent [candidate] (1.066 s) : 0, 1066343
Total [candidate] (11.029 s) : 0, 11029405
section appsec
Agent [baseline] (1.245 s) : 0, 1244527
Total [baseline] (11.135 s) : 0, 11134942
Agent [candidate] (1.245 s) : 0, 1245067
Total [candidate] (11.122 s) : 0, 11122367
section iast
Agent [baseline] (1.232 s) : 0, 1231831
Total [baseline] (11.385 s) : 0, 11385457
Agent [candidate] (1.226 s) : 0, 1226101
Total [candidate] (11.351 s) : 0, 11350638
section profiling
Agent [baseline] (1.188 s) : 0, 1187549
Total [baseline] (11.027 s) : 0, 11026717
Agent [candidate] (1.188 s) : 0, 1187779
Total [candidate] (11.125 s) : 0, 11124693
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~c7b9bcaa7d, baseline=1.61.0-SNAPSHOT~52d1e1902e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.207 ms) : 0, 1207
crashtracking [candidate] (1.208 ms) : 0, 1208
BytebuddyAgent [baseline] (631.764 ms) : 0, 631764
BytebuddyAgent [candidate] (632.22 ms) : 0, 632220
AgentMeter [baseline] (29.346 ms) : 0, 29346
AgentMeter [candidate] (29.218 ms) : 0, 29218
GlobalTracer [baseline] (258.174 ms) : 0, 258174
GlobalTracer [candidate] (258.107 ms) : 0, 258107
AppSec [baseline] (31.785 ms) : 0, 31785
AppSec [candidate] (31.673 ms) : 0, 31673
Debugger [baseline] (59.554 ms) : 0, 59554
Debugger [candidate] (59.612 ms) : 0, 59612
Remote Config [baseline] (611.476 µs) : 0, 611
Remote Config [candidate] (630.684 µs) : 0, 631
Telemetry [baseline] (8.636 ms) : 0, 8636
Telemetry [candidate] (8.691 ms) : 0, 8691
Flare Poller [baseline] (7.964 ms) : 0, 7964
Flare Poller [candidate] (8.757 ms) : 0, 8757
section appsec
crashtracking [baseline] (1.194 ms) : 0, 1194
crashtracking [candidate] (1.193 ms) : 0, 1193
BytebuddyAgent [baseline] (656.527 ms) : 0, 656527
BytebuddyAgent [candidate] (657.456 ms) : 0, 657456
AgentMeter [baseline] (12.052 ms) : 0, 12052
AgentMeter [candidate] (12.096 ms) : 0, 12096
GlobalTracer [baseline] (257.683 ms) : 0, 257683
GlobalTracer [candidate] (257.889 ms) : 0, 257889
IAST [baseline] (23.91 ms) : 0, 23910
IAST [candidate] (23.894 ms) : 0, 23894
AppSec [baseline] (177.765 ms) : 0, 177765
AppSec [candidate] (177.452 ms) : 0, 177452
Debugger [baseline] (65.877 ms) : 0, 65877
Debugger [candidate] (65.717 ms) : 0, 65717
Remote Config [baseline] (574.55 µs) : 0, 575
Remote Config [candidate] (564.365 µs) : 0, 564
Telemetry [baseline] (9.095 ms) : 0, 9095
Telemetry [candidate] (8.881 ms) : 0, 8881
Flare Poller [baseline] (3.636 ms) : 0, 3636
Flare Poller [candidate] (3.614 ms) : 0, 3614
section iast
crashtracking [baseline] (1.197 ms) : 0, 1197
crashtracking [candidate] (1.196 ms) : 0, 1196
BytebuddyAgent [baseline] (799.465 ms) : 0, 799465
BytebuddyAgent [candidate] (795.414 ms) : 0, 795414
AgentMeter [baseline] (11.576 ms) : 0, 11576
AgentMeter [candidate] (11.351 ms) : 0, 11351
GlobalTracer [baseline] (247.799 ms) : 0, 247799
GlobalTracer [candidate] (247.63 ms) : 0, 247630
IAST [baseline] (25.258 ms) : 0, 25258
IAST [candidate] (25.072 ms) : 0, 25072
AppSec [baseline] (26.594 ms) : 0, 26594
AppSec [candidate] (26.471 ms) : 0, 26471
Debugger [baseline] (64.294 ms) : 0, 64294
Debugger [candidate] (64.184 ms) : 0, 64184
Remote Config [baseline] (515.43 µs) : 0, 515
Remote Config [candidate] (512.8 µs) : 0, 513
Telemetry [baseline] (14.23 ms) : 0, 14230
Telemetry [candidate] (13.655 ms) : 0, 13655
Flare Poller [baseline] (4.716 ms) : 0, 4716
Flare Poller [candidate] (4.526 ms) : 0, 4526
section profiling
crashtracking [baseline] (1.186 ms) : 0, 1186
crashtracking [candidate] (1.184 ms) : 0, 1184
BytebuddyAgent [baseline] (686.057 ms) : 0, 686057
BytebuddyAgent [candidate] (685.909 ms) : 0, 685909
AgentMeter [baseline] (8.716 ms) : 0, 8716
AgentMeter [candidate] (8.714 ms) : 0, 8714
GlobalTracer [baseline] (216.239 ms) : 0, 216239
GlobalTracer [candidate] (216.433 ms) : 0, 216433
AppSec [baseline] (32.186 ms) : 0, 32186
AppSec [candidate] (32.272 ms) : 0, 32272
Debugger [baseline] (64.908 ms) : 0, 64908
Debugger [candidate] (63.365 ms) : 0, 63365
Remote Config [baseline] (601.787 µs) : 0, 602
Remote Config [candidate] (590.174 µs) : 0, 590
Telemetry [baseline] (8.966 ms) : 0, 8966
Telemetry [candidate] (10.571 ms) : 0, 10571
Flare Poller [baseline] (3.513 ms) : 0, 3513
Flare Poller [candidate] (3.495 ms) : 0, 3495
ProfilingAgent [baseline] (94.093 ms) : 0, 94093
ProfilingAgent [candidate] (94.052 ms) : 0, 94052
Profiling [baseline] (94.662 ms) : 0, 94662
Profiling [candidate] (94.627 ms) : 0, 94627
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 2 performance regressions! Performance is the same for 17 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~c7b9bcaa7d, baseline=1.61.0-SNAPSHOT~52d1e1902e
dateFormat X
axisFormat %s
section baseline
no_agent (18.687 ms) : 18497, 18877
. : milestone, 18687,
appsec (18.227 ms) : 18043, 18411
. : milestone, 18227,
code_origins (18.117 ms) : 17939, 18295
. : milestone, 18117,
iast (17.722 ms) : 17545, 17900
. : milestone, 17722,
profiling (18.471 ms) : 18282, 18659
. : milestone, 18471,
tracing (17.834 ms) : 17655, 18013
. : milestone, 17834,
section candidate
no_agent (18.013 ms) : 17828, 18198
. : milestone, 18013,
appsec (18.394 ms) : 18209, 18579
. : milestone, 18394,
code_origins (17.621 ms) : 17444, 17798
. : milestone, 17621,
iast (18.052 ms) : 17871, 18234
. : milestone, 18052,
profiling (19.776 ms) : 19576, 19975
. : milestone, 19776,
tracing (18.015 ms) : 17834, 18197
. : milestone, 18015,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~c7b9bcaa7d, baseline=1.61.0-SNAPSHOT~52d1e1902e
dateFormat X
axisFormat %s
section baseline
no_agent (1.188 ms) : 1176, 1199
. : milestone, 1188,
iast (3.107 ms) : 3068, 3146
. : milestone, 3107,
iast_FULL (5.988 ms) : 5927, 6049
. : milestone, 5988,
iast_GLOBAL (3.602 ms) : 3541, 3662
. : milestone, 3602,
profiling (2.251 ms) : 2230, 2272
. : milestone, 2251,
tracing (1.86 ms) : 1843, 1877
. : milestone, 1860,
section candidate
no_agent (1.18 ms) : 1169, 1192
. : milestone, 1180,
iast (3.118 ms) : 3075, 3161
. : milestone, 3118,
iast_FULL (5.828 ms) : 5770, 5886
. : milestone, 5828,
iast_GLOBAL (3.531 ms) : 3477, 3585
. : milestone, 3531,
profiling (2.198 ms) : 2178, 2217
. : milestone, 2198,
tracing (1.874 ms) : 1857, 1891
. : milestone, 1874,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~c7b9bcaa7d, baseline=1.61.0-SNAPSHOT~52d1e1902e
dateFormat X
axisFormat %s
section baseline
no_agent (15.618 s) : 15618000, 15618000
. : milestone, 15618000,
appsec (15.256 s) : 15256000, 15256000
. : milestone, 15256000,
iast (18.404 s) : 18404000, 18404000
. : milestone, 18404000,
iast_GLOBAL (17.716 s) : 17716000, 17716000
. : milestone, 17716000,
profiling (14.838 s) : 14838000, 14838000
. : milestone, 14838000,
tracing (15.302 s) : 15302000, 15302000
. : milestone, 15302000,
section candidate
no_agent (15.368 s) : 15368000, 15368000
. : milestone, 15368000,
appsec (14.836 s) : 14836000, 14836000
. : milestone, 14836000,
iast (18.215 s) : 18215000, 18215000
. : milestone, 18215000,
iast_GLOBAL (17.87 s) : 17870000, 17870000
. : milestone, 17870000,
profiling (15.429 s) : 15429000, 15429000
. : milestone, 15429000,
tracing (15.143 s) : 15143000, 15143000
. : milestone, 15143000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~c7b9bcaa7d, baseline=1.61.0-SNAPSHOT~52d1e1902e
dateFormat X
axisFormat %s
section baseline
no_agent (1.473 ms) : 1461, 1485
. : milestone, 1473,
appsec (2.498 ms) : 2444, 2552
. : milestone, 2498,
iast (2.246 ms) : 2177, 2314
. : milestone, 2246,
iast_GLOBAL (2.297 ms) : 2228, 2366
. : milestone, 2297,
profiling (2.086 ms) : 2031, 2141
. : milestone, 2086,
tracing (2.054 ms) : 2001, 2107
. : milestone, 2054,
section candidate
no_agent (1.471 ms) : 1459, 1482
. : milestone, 1471,
appsec (3.782 ms) : 3559, 4004
. : milestone, 3782,
iast (2.251 ms) : 2182, 2320
. : milestone, 2251,
iast_GLOBAL (2.298 ms) : 2229, 2367
. : milestone, 2298,
profiling (2.098 ms) : 2041, 2154
. : milestone, 2098,
tracing (2.074 ms) : 2020, 2128
. : milestone, 2074,
|
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
Gitlab pipeline didn't start... Please retry. You can get help from #ci-infra-support Error: gitlab pipeline not started DDCI change request: 2450716742819014164 |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
This PR is rejected because it was updated |
5f496d1 to
c7b9bca
Compare
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
The merge request has been interrupted because the build 102699718 took longer than expected. The current limit for the base branch 'master' is 120 minutes. Possible reasons:
|
What Does This Do
When MethodParameters is detected we bail out instrumentation but report diagnostics message as error.
Logging is now in debug instead of warning or error
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: DEBUG-5275
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.