fix(iast): update no vulnerabilities assertion#10850
Draft
manuel-alvarez-alvarez wants to merge 1 commit intomasterfrom
Draft
fix(iast): update no vulnerabilities assertion#10850manuel-alvarez-alvarez wants to merge 1 commit intomasterfrom
manuel-alvarez-alvarez wants to merge 1 commit intomasterfrom
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 63 metrics, 8 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~f8fbe2ebae, baseline=1.61.0-SNAPSHOT~c8e410d922
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1055033
Total [baseline] (8.863 s) : 0, 8862827
Agent [candidate] (1.055 s) : 0, 1055080
Total [candidate] (8.84 s) : 0, 8839606
section iast
Agent [baseline] (1.227 s) : 0, 1227163
Total [baseline] (9.574 s) : 0, 9574276
Agent [candidate] (1.225 s) : 0, 1224877
Total [candidate] (9.546 s) : 0, 9546429
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~f8fbe2ebae, baseline=1.61.0-SNAPSHOT~c8e410d922
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.197 ms) : 0, 1197
crashtracking [candidate] (1.199 ms) : 0, 1199
BytebuddyAgent [baseline] (625.561 ms) : 0, 625561
BytebuddyAgent [candidate] (628.64 ms) : 0, 628640
AgentMeter [baseline] (29.082 ms) : 0, 29082
AgentMeter [candidate] (29.025 ms) : 0, 29025
GlobalTracer [baseline] (255.868 ms) : 0, 255868
GlobalTracer [candidate] (256.48 ms) : 0, 256480
AppSec [baseline] (31.411 ms) : 0, 31411
AppSec [candidate] (31.512 ms) : 0, 31512
Debugger [baseline] (58.48 ms) : 0, 58480
Debugger [candidate] (58.803 ms) : 0, 58803
Remote Config [baseline] (617.45 µs) : 0, 617
Remote Config [candidate] (623.975 µs) : 0, 624
Telemetry [baseline] (8.685 ms) : 0, 8685
Telemetry [candidate] (8.626 ms) : 0, 8626
Flare Poller [baseline] (8.018 ms) : 0, 8018
Flare Poller [candidate] (4.197 ms) : 0, 4197
section iast
crashtracking [baseline] (1.218 ms) : 0, 1218
crashtracking [candidate] (1.196 ms) : 0, 1196
BytebuddyAgent [baseline] (796.061 ms) : 0, 796061
BytebuddyAgent [candidate] (795.359 ms) : 0, 795359
AgentMeter [baseline] (11.337 ms) : 0, 11337
AgentMeter [candidate] (11.333 ms) : 0, 11333
GlobalTracer [baseline] (247.937 ms) : 0, 247937
GlobalTracer [candidate] (247.044 ms) : 0, 247044
IAST [baseline] (25.206 ms) : 0, 25206
IAST [candidate] (25.105 ms) : 0, 25105
AppSec [baseline] (26.424 ms) : 0, 26424
AppSec [candidate] (26.345 ms) : 0, 26345
Debugger [baseline] (62.685 ms) : 0, 62685
Debugger [candidate] (62.577 ms) : 0, 62577
Remote Config [baseline] (514.178 µs) : 0, 514
Remote Config [candidate] (509.881 µs) : 0, 510
Telemetry [baseline] (14.824 ms) : 0, 14824
Telemetry [candidate] (14.586 ms) : 0, 14586
Flare Poller [baseline] (4.904 ms) : 0, 4904
Flare Poller [candidate] (4.847 ms) : 0, 4847
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~f8fbe2ebae, baseline=1.61.0-SNAPSHOT~c8e410d922
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.063 s) : 0, 1062789
Total [baseline] (11.003 s) : 0, 11002836
Agent [candidate] (1.067 s) : 0, 1066810
Total [candidate] (11.088 s) : 0, 11087571
section appsec
Agent [baseline] (1.245 s) : 0, 1244806
Total [baseline] (11.14 s) : 0, 11140129
Agent [candidate] (1.25 s) : 0, 1250443
Total [candidate] (11.202 s) : 0, 11201681
section iast
Agent [baseline] (1.236 s) : 0, 1236271
Total [baseline] (11.341 s) : 0, 11340880
Agent [candidate] (1.233 s) : 0, 1233059
Total [candidate] (11.306 s) : 0, 11306043
section profiling
Agent [baseline] (1.182 s) : 0, 1182052
Total [baseline] (10.966 s) : 0, 10965509
Agent [candidate] (1.187 s) : 0, 1187383
Total [candidate] (10.984 s) : 0, 10984224
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~f8fbe2ebae, baseline=1.61.0-SNAPSHOT~c8e410d922
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.194 ms) : 0, 1194
crashtracking [candidate] (1.196 ms) : 0, 1196
BytebuddyAgent [baseline] (629.389 ms) : 0, 629389
BytebuddyAgent [candidate] (632.621 ms) : 0, 632621
AgentMeter [baseline] (29.183 ms) : 0, 29183
AgentMeter [candidate] (29.283 ms) : 0, 29283
GlobalTracer [baseline] (257.758 ms) : 0, 257758
GlobalTracer [candidate] (258.226 ms) : 0, 258226
AppSec [baseline] (31.538 ms) : 0, 31538
AppSec [candidate] (31.74 ms) : 0, 31740
Debugger [baseline] (59.505 ms) : 0, 59505
Debugger [candidate] (59.718 ms) : 0, 59718
Remote Config [baseline] (619.707 µs) : 0, 620
Remote Config [candidate] (625.343 µs) : 0, 625
Telemetry [baseline] (8.74 ms) : 0, 8740
Telemetry [candidate] (8.651 ms) : 0, 8651
Flare Poller [baseline] (8.769 ms) : 0, 8769
Flare Poller [candidate] (8.62 ms) : 0, 8620
section appsec
crashtracking [baseline] (1.201 ms) : 0, 1201
crashtracking [candidate] (1.192 ms) : 0, 1192
BytebuddyAgent [baseline] (657.586 ms) : 0, 657586
BytebuddyAgent [candidate] (660.687 ms) : 0, 660687
AgentMeter [baseline] (12.114 ms) : 0, 12114
AgentMeter [candidate] (12.179 ms) : 0, 12179
GlobalTracer [baseline] (258.007 ms) : 0, 258007
GlobalTracer [candidate] (258.897 ms) : 0, 258897
IAST [baseline] (23.916 ms) : 0, 23916
IAST [candidate] (24.126 ms) : 0, 24126
AppSec [baseline] (177.005 ms) : 0, 177005
AppSec [candidate] (177.618 ms) : 0, 177618
Debugger [baseline] (65.652 ms) : 0, 65652
Debugger [candidate] (66.156 ms) : 0, 66156
Remote Config [baseline] (571.015 µs) : 0, 571
Remote Config [candidate] (573.474 µs) : 0, 573
Telemetry [baseline] (9.032 ms) : 0, 9032
Telemetry [candidate] (8.997 ms) : 0, 8997
Flare Poller [baseline] (3.617 ms) : 0, 3617
Flare Poller [candidate] (3.657 ms) : 0, 3657
section iast
crashtracking [baseline] (1.205 ms) : 0, 1205
crashtracking [candidate] (1.19 ms) : 0, 1190
BytebuddyAgent [baseline] (801.914 ms) : 0, 801914
BytebuddyAgent [candidate] (801.368 ms) : 0, 801368
AgentMeter [baseline] (11.613 ms) : 0, 11613
AgentMeter [candidate] (11.635 ms) : 0, 11635
GlobalTracer [baseline] (248.673 ms) : 0, 248673
GlobalTracer [candidate] (247.739 ms) : 0, 247739
IAST [baseline] (25.376 ms) : 0, 25376
IAST [candidate] (25.129 ms) : 0, 25129
AppSec [baseline] (26.678 ms) : 0, 26678
AppSec [candidate] (26.529 ms) : 0, 26529
Debugger [baseline] (64.888 ms) : 0, 64888
Debugger [candidate] (64.557 ms) : 0, 64557
Remote Config [baseline] (523.029 µs) : 0, 523
Remote Config [candidate] (516.389 µs) : 0, 516
Telemetry [baseline] (14.464 ms) : 0, 14464
Telemetry [candidate] (13.712 ms) : 0, 13712
Flare Poller [baseline] (4.775 ms) : 0, 4775
Flare Poller [candidate] (4.548 ms) : 0, 4548
section profiling
crashtracking [baseline] (1.181 ms) : 0, 1181
crashtracking [candidate] (1.179 ms) : 0, 1179
BytebuddyAgent [baseline] (682.303 ms) : 0, 682303
BytebuddyAgent [candidate] (686.792 ms) : 0, 686792
AgentMeter [baseline] (8.672 ms) : 0, 8672
AgentMeter [candidate] (8.697 ms) : 0, 8697
GlobalTracer [baseline] (215.631 ms) : 0, 215631
GlobalTracer [candidate] (216.083 ms) : 0, 216083
AppSec [baseline] (31.985 ms) : 0, 31985
AppSec [candidate] (32.062 ms) : 0, 32062
Debugger [baseline] (63.776 ms) : 0, 63776
Debugger [candidate] (63.233 ms) : 0, 63233
Remote Config [baseline] (603.609 µs) : 0, 604
Remote Config [candidate] (576.071 µs) : 0, 576
Telemetry [baseline] (9.618 ms) : 0, 9618
Telemetry [candidate] (9.69 ms) : 0, 9690
Flare Poller [baseline] (3.474 ms) : 0, 3474
Flare Poller [candidate] (4.281 ms) : 0, 4281
ProfilingAgent [baseline] (94.009 ms) : 0, 94009
ProfilingAgent [candidate] (93.688 ms) : 0, 93688
Profiling [baseline] (94.574 ms) : 0, 94574
Profiling [candidate] (94.248 ms) : 0, 94248
LoadParameters
See matching parameters
SummaryFound 4 performance improvements and 2 performance regressions! Performance is the same for 15 metrics, 15 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~f8fbe2ebae, baseline=1.61.0-SNAPSHOT~c8e410d922
dateFormat X
axisFormat %s
section baseline
no_agent (19.503 ms) : 19304, 19703
. : milestone, 19503,
appsec (18.455 ms) : 18269, 18642
. : milestone, 18455,
code_origins (17.802 ms) : 17624, 17980
. : milestone, 17802,
iast (18.746 ms) : 18554, 18939
. : milestone, 18746,
profiling (18.918 ms) : 18731, 19106
. : milestone, 18918,
tracing (17.617 ms) : 17441, 17793
. : milestone, 17617,
section candidate
no_agent (18.023 ms) : 17842, 18204
. : milestone, 18023,
appsec (18.874 ms) : 18682, 19067
. : milestone, 18874,
code_origins (17.908 ms) : 17731, 18085
. : milestone, 17908,
iast (17.622 ms) : 17446, 17797
. : milestone, 17622,
profiling (19.667 ms) : 19465, 19869
. : milestone, 19667,
tracing (17.679 ms) : 17505, 17853
. : milestone, 17679,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~f8fbe2ebae, baseline=1.61.0-SNAPSHOT~c8e410d922
dateFormat X
axisFormat %s
section baseline
no_agent (1.186 ms) : 1174, 1197
. : milestone, 1186,
iast (3.342 ms) : 3307, 3376
. : milestone, 3342,
iast_FULL (5.7 ms) : 5644, 5756
. : milestone, 5700,
iast_GLOBAL (3.691 ms) : 3629, 3753
. : milestone, 3691,
profiling (2.247 ms) : 2227, 2267
. : milestone, 2247,
tracing (1.8 ms) : 1785, 1815
. : milestone, 1800,
section candidate
no_agent (1.169 ms) : 1158, 1181
. : milestone, 1169,
iast (3.204 ms) : 3162, 3246
. : milestone, 3204,
iast_FULL (5.744 ms) : 5688, 5800
. : milestone, 5744,
iast_GLOBAL (3.713 ms) : 3643, 3783
. : milestone, 3713,
profiling (2.344 ms) : 2320, 2367
. : milestone, 2344,
tracing (1.776 ms) : 1761, 1790
. : milestone, 1776,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~f8fbe2ebae, baseline=1.61.0-SNAPSHOT~c8e410d922
dateFormat X
axisFormat %s
section baseline
no_agent (1.466 ms) : 1454, 1477
. : milestone, 1466,
appsec (2.547 ms) : 2490, 2604
. : milestone, 2547,
iast (2.248 ms) : 2179, 2317
. : milestone, 2248,
iast_GLOBAL (2.282 ms) : 2213, 2351
. : milestone, 2282,
profiling (2.5 ms) : 2333, 2666
. : milestone, 2500,
tracing (2.044 ms) : 1991, 2097
. : milestone, 2044,
section candidate
no_agent (1.468 ms) : 1457, 1480
. : milestone, 1468,
appsec (3.775 ms) : 3556, 3995
. : milestone, 3775,
iast (2.24 ms) : 2171, 2308
. : milestone, 2240,
iast_GLOBAL (2.286 ms) : 2217, 2355
. : milestone, 2286,
profiling (2.09 ms) : 2034, 2147
. : milestone, 2090,
tracing (2.056 ms) : 2003, 2109
. : milestone, 2056,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~f8fbe2ebae, baseline=1.61.0-SNAPSHOT~c8e410d922
dateFormat X
axisFormat %s
section baseline
no_agent (15.677 s) : 15677000, 15677000
. : milestone, 15677000,
appsec (15.219 s) : 15219000, 15219000
. : milestone, 15219000,
iast (17.729 s) : 17729000, 17729000
. : milestone, 17729000,
iast_GLOBAL (17.79 s) : 17790000, 17790000
. : milestone, 17790000,
profiling (14.91 s) : 14910000, 14910000
. : milestone, 14910000,
tracing (15.052 s) : 15052000, 15052000
. : milestone, 15052000,
section candidate
no_agent (15.057 s) : 15057000, 15057000
. : milestone, 15057000,
appsec (14.984 s) : 14984000, 14984000
. : milestone, 14984000,
iast (18.522 s) : 18522000, 18522000
. : milestone, 18522000,
iast_GLOBAL (18.0 s) : 18000000, 18000000
. : milestone, 18000000,
profiling (15.297 s) : 15297000, 15297000
. : milestone, 15297000,
tracing (15.069 s) : 15069000, 15069000
. : milestone, 15069000,
|
95502fa to
3ed8261
Compare
3ed8261 to
f8fbe2e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Fixes the
noVulnerabilityassertion helper inAbstractIastServerSmokeTestso that it correctly collects vulnerabilities before asserting none match.Motivation
Additional Notes
flaky testbecause this was the root cause of intermittent false-negatives in IAST smoke tests.Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.