-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add .NET to feature flagging server SDK documentation #33826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
- Create dotnet.md page with OpenFeature integration guide - Update feature_flags_server.html partial to include .NET SDK card - Follow same structure as other OpenFeature SDKs (Go, Python, Java)
Preview links (active after the
|
|
Thanks @leoromanovsky, I've created DOCS-13097 for documentation team review |
| {{< code-block lang="csharp" >}} | ||
| using OpenFeature.Model; | ||
|
|
||
| var evalCtx = EvaluationContext.Builder() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks to be missing the setEvaluationContext call?
Also, might be good to note that the evaluation context should be built once and set, and only rebuilt/reset if it changes.
typotter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 lgtm, one note
- reorder so dot (.) comes before letters - resize tiles
What does this PR do? What is the motivation?
Merge instructions
Merge readiness:
For Datadog employees:
Your branch name MUST follow the
<name>/<description>convention and include the forward slash (/). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.
Additional notes