Skip to content

Conversation

@api-clients-generation-pipeline
Copy link
Contributor

Copy link
Contributor

@buraizu buraizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flagging a typo and made one other minor suggestion

data_source:
$ref: '#/components/schemas/MonitorFormulaAndFunctionDataQualityDataSource'
filter:
description: Filter expression used to match on data entities. Uses Aastra
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: Filter expression used to match on data entities. Uses Aastra
description: Filter expression used to match on data entities. Uses Astra

type: string
scope:
description: 'Optional scoping expression to further filter metrics. Uses
metrics filter syntax.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
metrics filter syntax.
metric filter syntax.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants