-
Notifications
You must be signed in to change notification settings - Fork 12
chore(deps): update dependency org.junit-pioneer:junit-pioneer to v2 #500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dd-octo-sts
wants to merge
2
commits into
main
Choose a base branch
from
engraver-auto-version-upgrade/renovate/major-junit.pioneer
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2
−2
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This repo still targets Java 8 bytecode and documents/routs cross-JDK test runs through
JAVA_TEST_HOME(ProfilerTestPlugincallssetExecutable(PlatformUtils.testJavaExecutable()), and the tests import@RetryingTestin manyddprof-testclasses). JUnit Pioneer 2.x raised its runtime baseline to JDK 11, so whenJAVA_TEST_HOMEpoints to a JDK 8 runtime for the supportedtestDebugcross-JDK run, the test JVM will discover/load Java 11-only Pioneer classes and fail withUnsupportedClassVersionErrorbefore those tests can run. Please keep this dependency on the 1.x line unless the Java 8 test path is intentionally dropped.Useful? React with 👍 / 👎.