DataGrid: Fix the banded Columns' vertical borders (T1318812) by Alyar666 · Pull Request #32802 · DevExpress/DevExtreme

Alyar666 · 2026-03-05T13:48:38Z

No description provided.

Copilot

Pull request overview

Copilot reviewed 25 out of 25 changed files in this pull request and generated 3 comments.

packages/devextreme/js/__internal/grids/grid_core/column_headers/m_column_headers.ts

packages/devextreme/js/__internal/grids/grid_core/sticky_columns/m_sticky_columns.ts

Copilot

Pull request overview

Copilot reviewed 18 out of 18 changed files in this pull request and generated no new comments.

Copilot

Pull request overview

Copilot reviewed 18 out of 159 changed files in this pull request and generated 4 comments.

packages/devextreme/js/__internal/grids/grid_core/column_headers/m_column_headers.ts

packages/devextreme/js/__internal/grids/grid_core/sticky_columns/m_sticky_columns.ts

packages/devextreme/js/__internal/grids/grid_core/column_headers/m_column_headers.ts

Copilot

Pull request overview

Copilot reviewed 18 out of 162 changed files in this pull request and generated 1 comment.

packages/devextreme/js/__internal/grids/grid_core/column_headers/m_column_headers.ts

… selectors The border-left/border-right rules for multi-row headers incorrectly targeted all .dx-row elements inside the headers container. This caused filter row cells to get unexpected borders when band columns were present and showColumnHeaders was false. Narrowing the selector to .dx-header-row ensures only actual header rows are affected.

Copilot

Pull request overview

Copilot reviewed 18 out of 178 changed files in this pull request and generated 1 comment.

packages/devextreme/js/__internal/grids/grid_core/__tests__/__mock__/model/grid_core.ts

Copilot

Pull request overview

Copilot reviewed 18 out of 179 changed files in this pull request and generated 1 comment.

packages/devextreme/js/__internal/grids/grid_core/__tests__/__mock__/model/grid_core.ts

…8812)

…T1318812)

…pecificity

Copilot

Pull request overview

Copilot reviewed 24 out of 185 changed files in this pull request and generated 1 comment.

Copilot · 2026-03-25T14:09:30Z

packages/devextreme/js/__internal/grids/grid_core/views/m_columns_view.ts

+  protected needToUpdateFirstCellClasses(): boolean {
+    const hasHidingColumnsQueue = !!this._adaptiveColumnsController
+      ?.getHidingColumnsQueue()?.length;
+
+    return hasHidingColumnsQueue;
+  }


needToUpdateFirstCellClasses() only checks getHidingColumnsQueue().length. When adaptivity has already hidden columns (e.g. _hiddenColumns is non-empty) or when columns are being shown back (queue can be empty), the first-cell class may still need recalculation, but this method will return false and skip updates. Consider also checking this._adaptiveColumnsController?.hasHiddenColumns() (or another reliable signal that the first visible column may have changed).

…s (T1318812)

…ers (T1318812) - Override _getVisibleColumnIndex in ColumnHeadersView to pass rowIndex to getVisibleIndex - Type _getVisibleColumnIndex signature across base and derived classes - Fix _getCellElement to handle missing cells with fallback to empty jQuery set

Copilot

Pull request overview

Copilot reviewed 25 out of 186 changed files in this pull request and generated 1 comment.

Copilot · 2026-03-25T23:04:57Z

packages/devextreme/js/__internal/grids/grid_core/views/m_columns_view.ts

+  protected updateFirstCellClasses(): void {
+    const rows = this._getRows();
+
+    rows.forEach((row, index) => {
+      const rowIndex = row.rowType === 'header' ? index : null;
+      const firstColumn = this._columnsController.getFirstColumn(rowIndex);
+
+      if (firstColumn) {
+        const $cell = this._getCellElement(index, `index:${firstColumn.index}`);
+
+        this.toggleFirstCellClass($cell, true);
+      }
+    });


updateFirstCellClasses only toggles the first-cell class on the new first column, but it never removes the class from the previously-first cell in each row. After multiple visibility/width changes (e.g., column hiding/unhiding in adaptive mode), multiple cells in the same row can keep dx-*-first-cell, which will break border logic. Consider clearing the first-cell class for all cells in the row first (or tracking the previous first column and toggling it off) before enabling it for the current first column.

…iew (T1318812)

…lectors (T1318812)

Copilot

Pull request overview

Copilot reviewed 25 out of 188 changed files in this pull request and generated 2 comments.

Copilot · 2026-03-27T07:57:54Z

packages/devextreme-scss/scss/widgets/material/gridBase/layout/cell.scss

+  .dx-rtl .dx-#{$widget-name}-headers.dx-header-multi-row .dx-header-row:not(.dx-column-lines) > td:not(
+    .dx-#{$widget-name}-first-cell,
+    .dx-#{$widget-name}-hidden-column,
+    .dx-command-adaptive-hidden
+    .dx-#{$widget-name}-sticky-column-border-right,
+    .dx-#{$widget-name}-column-no-border
+  ) {


In the RTL multi-row header selector, the :not(...) list is missing a comma after .dx-command-adaptive-hidden. As written, it becomes a descendant selector (.dx-command-adaptive-hidden .dx-...-sticky-column-border-right) instead of two separate exclusions, which will produce incorrect border rules in RTL (and may invalidate the selector in some preprocessors). Add the missing comma so all exclusions are separate selectors.

Copilot · 2026-03-27T07:57:55Z

e2e/testcafe-devextreme/tests/dataGrid/helpers/domUtils.ts

+  for (const { rowIndex, cells } of expectedRows) {
+    const summaryRow = dataGrid.getFooterRow();
+
+    // eslint-disable-next-line no-restricted-syntax
+    for (const { columnIndex, name, expected: [leftWidth, rightWidth] } of cells) {
+      const element = summaryRow.child('td');
+
+      const borderLeft = await element.getStyleProperty('border-left-width');
+      const borderRight = await element.getStyleProperty('border-right-width');
+


checkSummaryCellBorders ignores rowIndex and columnIndex: it always reads styles from summaryRow.child('td') (the first footer cell). This makes the helper incorrectly validate only the first summary cell even when multiple columns are provided. Use the columnIndex to select the correct cell (e.g., summaryRow.child('td').nth(columnIndex) / find('td').nth(...)) and, if multiple footer rows are possible, also use rowIndex.

Alyar666 self-assigned this Mar 5, 2026

Copilot AI review requested due to automatic review settings March 5, 2026 13:48

Alyar666 requested a review from a team as a code owner March 5, 2026 13:48

Alyar666 added skip-cache force all tests 26_1 labels Mar 5, 2026

Copilot started reviewing on behalf of Alyar666 March 5, 2026 13:49 View session

This comment was marked as outdated.

Sign in to view

Copilot AI review requested due to automatic review settings March 10, 2026 13:15

Alyar666 force-pushed the T1318812_26_1_attempt_3 branch from 88936f8 to ccd2691 Compare March 10, 2026 13:15

Copilot started reviewing on behalf of Alyar666 March 10, 2026 13:16 View session

Copilot AI reviewed Mar 10, 2026

View reviewed changes

Alyar666 force-pushed the T1318812_26_1_attempt_3 branch from ccd2691 to 2899a74 Compare March 16, 2026 09:55

Copilot AI review requested due to automatic review settings March 16, 2026 10:24

Copilot started reviewing on behalf of Alyar666 March 16, 2026 10:25 View session

This comment was marked as outdated.

Sign in to view

Alyar666 force-pushed the T1318812_26_1_attempt_3 branch from 77856d4 to d98ceff Compare March 17, 2026 09:24

Copilot AI review requested due to automatic review settings March 17, 2026 12:10

Copilot started reviewing on behalf of Alyar666 March 17, 2026 12:10 View session

This comment was marked as outdated.

Sign in to view

Alyar666 force-pushed the T1318812_26_1_attempt_3 branch from 04062b7 to a784fb8 Compare March 17, 2026 22:03

Copilot AI review requested due to automatic review settings March 17, 2026 22:03

Copilot started reviewing on behalf of Alyar666 March 17, 2026 22:04 View session

Copilot AI reviewed Mar 17, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings March 18, 2026 17:22

Copilot started reviewing on behalf of Alyar666 March 18, 2026 17:27 View session

Copilot AI reviewed Mar 18, 2026

View reviewed changes

Alyar added 3 commits March 19, 2026 01:15

Revert the fix for T1282595

74f3dfe

separate TestCafe tests into functional and visual tests

2062535

Move first-header class logic from sticky_columns to column_headers

486f91e

Alyar666 force-pushed the T1318812_26_1_attempt_3 branch from be6ac0c to f9562be Compare March 18, 2026 21:15

Copilot AI reviewed Mar 18, 2026

View reviewed changes

packages/devextreme/js/__internal/grids/grid_core/column_headers/m_column_headers.ts Outdated Show resolved Hide resolved

Alyar added 3 commits March 19, 2026 02:31

Update etalons (part 3)

242505a

Update etalons (part 4)

86f6c2f

Copilot AI review requested due to automatic review settings March 19, 2026 08:36

Copilot AI reviewed Mar 19, 2026

View reviewed changes

packages/devextreme/js/__internal/grids/grid_core/__tests__/__mock__/model/grid_core.ts Show resolved Hide resolved

Alyar added 2 commits March 19, 2026 13:47

Update etalons (part 5)

0929754

Fix copilot comments

1031c96

Copilot AI review requested due to automatic review settings March 19, 2026 15:10

Copilot AI reviewed Mar 19, 2026

View reviewed changes

packages/devextreme/js/__internal/grids/grid_core/__tests__/__mock__/model/grid_core.ts Show resolved Hide resolved

Alyar added 5 commits March 20, 2026 17:38

fix: pass rowIndex to getVisibleIndex in _getVisibleColumnIndex (T131…

512ca28

…8812)

add e2e test

130956a

fix: banded columns vertical borders and adaptivity border handling (…

a988d41

…T1318812)

fix extra RTL border in sticky columns caused by increased selector s…

c1f3ff9

…pecificity

Fix rowType check in _setFirstCellClass for header rows

ee23684

Copilot AI review requested due to automatic review settings March 25, 2026 14:02

Copilot started reviewing on behalf of Alyar666 March 25, 2026 14:03 View session

Copilot AI reviewed Mar 25, 2026

View reviewed changes

Alyar added 2 commits March 26, 2026 02:12

fix: use column index identifier for _getCellElement in banded column…

0ac0b9d

…s (T1318812)

Copilot AI review requested due to automatic review settings March 25, 2026 23:00

Copilot started reviewing on behalf of Alyar666 March 25, 2026 23:00 View session

Copilot AI reviewed Mar 25, 2026

View reviewed changes

Alyar added 3 commits March 26, 2026 03:59

Update etalons (part 6)

7b9216a

fix: clear stale first-cell classes before recalculating in columns v…

0e87a35

…iew (T1318812)

fix: exclude hidden and adaptive columns from banded header border se…

16b2b71

…lectors (T1318812)

Copilot AI review requested due to automatic review settings March 27, 2026 07:53

Copilot started reviewing on behalf of Alyar666 March 27, 2026 07:54 View session

Copilot AI reviewed Mar 27, 2026

View reviewed changes

Conversation

Alyar666 commented Mar 5, 2026

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants