DataGrid - Fix lookup filter changing to "(All)" after searching twice in another column (T1284002)#32969
Merged
markallenramirez merged 4 commits intoDevExpress:26_1from Mar 24, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an end-to-end regression test to ensure DataGrid filter row lookup selections are preserved when the user types into another column’s filter editor multiple times (T1284002).
Changes:
- Added
SelectBoxusage in the filter row functional TestCafe suite. - Added a new TestCafe test that selects a lookup filter value, types into a text filter twice, and asserts the lookup filter remains unchanged.
e2e/testcafe-devextreme/tests/dataGrid/common/filterRow/functional.ts
Outdated
Show resolved
Hide resolved
e2e/testcafe-devextreme/tests/dataGrid/common/filterRow/functional.ts
Outdated
Show resolved
Hide resolved
packages/devextreme/js/__internal/grids/grid_core/filter/m_filter_row.ts
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a DataGrid filter row regression where a lookup filter editor could reset its displayed value to “(All)” after repeated searching in another column when syncLookupFilterValues is enabled.
Changes:
- Preserve the lookup filter editor’s currently selected item when refreshing the wrapped lookup
dataSource. - Add a TestCafe regression test covering the “search twice in another column” scenario (T1284002).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
packages/devextreme/js/__internal/grids/grid_core/filter/m_filter_row.ts |
Adjusts lookup filter editor update logic during syncLookupFilterValues dataSource refresh. |
e2e/testcafe-devextreme/tests/dataGrid/common/filterRow/functional.ts |
Adds an E2E regression test reproducing and validating the reported issue. |
packages/devextreme/js/__internal/grids/grid_core/filter/m_filter_row.ts
Show resolved
Hide resolved
Raushen
approved these changes
Mar 24, 2026
anna-shakhova
approved these changes
Mar 24, 2026
markallenramirez
added a commit
to markallenramirez/DevExtreme
that referenced
this pull request
Mar 24, 2026
…e in another column (T1284002) (DevExpress#32969) (cherry picked from commit 62b597f)
markallenramirez
added a commit
to markallenramirez/DevExtreme
that referenced
this pull request
Mar 24, 2026
…e in another column (T1284002) (DevExpress#32969) (cherry picked from commit 62b597f)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.