Scheduler - Create isolated AppointmentPopup test environment by aleksei-semikozov · Pull Request #33002 · DevExpress/DevExtreme

aleksei-semikozov · 2026-03-20T18:05:35Z

No description provided.

Copilot

Pull request overview

Adds an isolated Jest (JSDOM) test harness for the Scheduler AppointmentPopup, allowing the popup + form to be instantiated and asserted without creating a full Scheduler instance.

Changes:

Added a new appointment_popup.test.ts suite that validates basic popup rendering, form binding, and Save/Cancel behavior.
Introduced a dedicated createAppointmentPopup test helper and centralized cleanup via disposeAppointmentPopups.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
packages/devextreme/js/__internal/scheduler/tests/appointment_popup.test.ts	New isolated AppointmentPopup tests covering rendering, data binding, and Save/Cancel actions.
packages/devextreme/js/__internal/scheduler/tests/mock/create_appointment_popup.ts	New helper to construct an `AppointmentPopup` + `AppointmentForm` with minimal scheduler proxies and deterministic cleanup.

Copilot · 2026-03-23T15:29:52Z

packages/devextreme/js/__internal/scheduler/__tests__/appointment_popup.test.ts

+
+describe('Isolated AppointmentPopup environment', () => {
+  beforeEach(() => {
+    fx.off = true;


Consider calling setupSchedulerTestEnvironment() (or at least stubbing DOMComponent.prototype._isVisible) in beforeEach. Most other Scheduler jsdom tests do this to avoid :visible returning false in JSDOM, which can make overlay/popup rendering and visibility-dependent logic flaky.

Suggested change

fx.off = true;

fx.off = true;

setupSchedulerTestEnvironment();

Copilot · 2026-03-23T15:29:53Z

packages/devextreme/js/__internal/scheduler/__tests__/__mock__/create_appointment_popup.ts

+interface CreateAppointmentPopupOptions {
+  appointmentData?: Record<string, unknown>;
+  action?: number;
+  editing?: Record<string, unknown>;
+  firstDayOfWeek?: number;
+  startDayHour?: number;
+  onAppointmentFormOpening?: (...args: unknown[]) => void;
+  addAppointment?: jest.Mock;
+  updateAppointment?: jest.Mock;
+}


The option types here are very generic (Record<string, unknown>, number), which reduces the value of these helpers and can hide breaking changes in the popup contract. Consider typing appointmentData as Partial<SafeAppointment> (or similar) and action as a union of ACTION_TO_APPOINTMENT values, and tightening editing to the scheduler editing config shape used by AppointmentPopup/AppointmentForm.

Copilot

Pull request overview

Copilot reviewed 1 out of 4 changed files in this pull request and generated 1 comment.

Copilot · 2026-03-24T11:32:58Z

...s/devextreme/js/__internal/scheduler/appointment_popup/appointment_popup.integration.test.ts

+  it('should call custom onContentReady and onInitialized and preserving default', async () => {
+    const onContentReady = jest.fn();
+    const onInitialized = jest.fn();
+    const { scheduler, POM } = await createScheduler({
+      ...getDefaultConfig(),
+      ...{
+        editing: {
+          form: {
+            onContentReady,
+            onInitialized,
+          },
+        },
+      },
+    });
+
+    scheduler.showAppointmentPopup();
+
+    POM.popup.selectRepeatValue('weekly');
+
+    expect(POM.popup.isMainGroupVisible()).toBe(false);
+    expect(POM.popup.isRecurrenceGroupVisible()).toBe(true);
+
+    expect(onContentReady).toHaveBeenCalled();
+    expect(onInitialized).toHaveBeenCalled();
+  });
+


This test appears duplicated: the same "should call custom onContentReady and onInitialized and preserving default" case exists both inside the "Basic form customization" describe and again immediately after it. Keeping both adds runtime and makes failures harder to interpret; consider removing the duplicate or changing it to cover a distinct scenario.

Suggested change

it('should call custom onContentReady and onInitialized and preserving default', async () => {

const onContentReady = jest.fn();

const onInitialized = jest.fn();

const { scheduler, POM } = await createScheduler({

...getDefaultConfig(),

...{

editing: {

form: {

onContentReady,

onInitialized,

},

},

},

});

scheduler.showAppointmentPopup();

POM.popup.selectRepeatValue('weekly');

expect(POM.popup.isMainGroupVisible()).toBe(false);

expect(POM.popup.isRecurrenceGroupVisible()).toBe(true);

expect(onContentReady).toHaveBeenCalled();

expect(onInitialized).toHaveBeenCalled();

});

… integration tests

Copilot

Pull request overview

Copilot reviewed 1 out of 3 changed files in this pull request and generated 2 comments.

Copilot · 2026-03-24T21:08:15Z

packages/devextreme/js/__internal/scheduler/__tests__/__mock__/create_appointment_popup.ts

+  const selector = `.dx-overlay-wrapper.${APPOINTMENT_POPUP_CLASS}`;
+  const overlayWrapper = document.querySelector(
+    selector,
+  ) as HTMLDivElement;
+
+  if (!overlayWrapper) {
+    throw new Error(
+      'AppointmentPopup overlay wrapper not found in DOM',
+    );


createAppointmentPopup locates the overlay wrapper via document.querySelector(...), which will return the first matching wrapper. If multiple AppointmentPopups are created in the same test without calling disposeAppointmentPopups() in between, this can bind the POM to the wrong popup instance. Consider selecting the most recently created wrapper (e.g., querySelectorAll + last) or deriving the wrapper from popup.popup.$element() to make the helper robust for multiple instances.

Copilot · 2026-03-24T21:08:15Z

...s/devextreme/js/__internal/scheduler/appointment_popup/appointment_popup.integration.test.ts

+  it('should call custom onContentReady and onInitialized and preserving default', async () => {
+    const onContentReady = jest.fn();
+    const onInitialized = jest.fn();
+    const { scheduler, POM } = await createScheduler({
+      ...getDefaultConfig(),
+      ...{
+        editing: {
+          form: {
+            onContentReady,
+            onInitialized,
+          },
+        },
+      },
+    });
+
+    scheduler.showAppointmentPopup();


This file contains the same test case (should call custom onContentReady and onInitialized and preserving default) twice, which adds redundant coverage and extra runtime. Please remove one of the duplicates or differentiate them if they are meant to validate different behavior.

aleksei-semikozov added the 26_1 label Mar 20, 2026

aleksei-semikozov self-assigned this Mar 20, 2026

aleksei-semikozov force-pushed the worktree-scheduler-popup-env-3718 branch from d9420d7 to 1385ce5 Compare March 20, 2026 20:23

aleksei-semikozov marked this pull request as ready for review March 23, 2026 15:21

aleksei-semikozov requested a review from a team as a code owner March 23, 2026 15:21

Copilot AI review requested due to automatic review settings March 23, 2026 15:21

Copilot started reviewing on behalf of aleksei-semikozov March 23, 2026 15:22 View session

Copilot AI reviewed Mar 23, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings March 24, 2026 11:28

Copilot started reviewing on behalf of aleksei-semikozov March 24, 2026 11:29 View session

Copilot AI reviewed Mar 24, 2026

View reviewed changes

Tucchhaa previously approved these changes Mar 24, 2026

View reviewed changes

aleksei-semikozov added 4 commits March 24, 2026 18:01

Scheduler - Create isolated AppointmentPopup test environment

6c64ccf

Scheduler - Fix lint errors in create_appointment_popup

bef9bb2

Scheduler - Move isolated popup test to appointment_popup dir, rename…

13b38f1

… integration tests

Scheduler - Revert customize_form_items rename, it is a unit test

749fea5

Copilot AI review requested due to automatic review settings March 24, 2026 21:03

aleksei-semikozov dismissed Tucchhaa’s stale review via 749fea5 March 24, 2026 21:03

aleksei-semikozov force-pushed the worktree-scheduler-popup-env-3718 branch from d58be59 to 749fea5 Compare March 24, 2026 21:03

Copilot started reviewing on behalf of aleksei-semikozov March 24, 2026 21:03 View session

Copilot AI reviewed Mar 24, 2026

View reviewed changes

Tucchhaa approved these changes Mar 25, 2026

View reviewed changes

aleksei-semikozov merged commit 3c22167 into DevExpress:26_1 Mar 25, 2026
106 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Scheduler - Create isolated AppointmentPopup test environment#33002

Scheduler - Create isolated AppointmentPopup test environment#33002
aleksei-semikozov merged 4 commits intoDevExpress:26_1from
aleksei-semikozov:worktree-scheduler-popup-env-3718

aleksei-semikozov commented Mar 20, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 23, 2026

Uh oh!

Copilot AI Mar 23, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 24, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 24, 2026

Uh oh!

Copilot AI Mar 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	fx.off = true;
	fx.off = true;
	setupSchedulerTestEnvironment();

Conversation

aleksei-semikozov commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

aleksei-semikozov commented Mar 20, 2026 •

edited

Loading