Skip to content

Demos: Update old dates & remove +1 from mask in Editors#33024

Open
r-farkhutdinov wants to merge 3 commits intoDevExpress:26_1from
r-farkhutdinov:26_1_demos_dates_update
Open

Demos: Update old dates & remove +1 from mask in Editors#33024
r-farkhutdinov wants to merge 3 commits intoDevExpress:26_1from
r-farkhutdinov:26_1_demos_dates_update

Conversation

@r-farkhutdinov
Copy link
Contributor

No description provided.

@r-farkhutdinov r-farkhutdinov self-assigned this Mar 24, 2026
@r-farkhutdinov r-farkhutdinov requested a review from a team as a code owner March 24, 2026 14:15
@r-farkhutdinov r-farkhutdinov requested a review from a team as a code owner March 24, 2026 14:15
Copilot AI review requested due to automatic review settings March 24, 2026 14:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates DevExtreme demo sources to keep sample data current and simplify phone input masks by removing the hard-coded +1 prefix across several editor demos.

Changes:

  • Removed +1 from phone mask patterns in Validation/TextBox/EditorAppearanceVariants demos (jQuery/Vue/React/Angular).
  • Refreshed RangeSelector EmbeddedChart demo dates (2011–2012 → 2024–2025).
  • Updated DateBox Formatting demo sample date/placeholder strings (2018 → 2025).

Reviewed changes

Copilot reviewed 29 out of 29 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
apps/demos/Demos/Validation/Overview/jQuery/index.js Updates phone mask to exclude +1.
apps/demos/Demos/Validation/Overview/Vue/App.vue Updates phone mask to exclude +1.
apps/demos/Demos/Validation/Overview/ReactJs/App.js Updates phone mask to exclude +1.
apps/demos/Demos/Validation/Overview/React/App.tsx Updates phone mask to exclude +1.
apps/demos/Demos/Validation/Overview/Angular/app/app.component.html Updates phone mask to exclude +1.
apps/demos/Demos/TextBox/Overview/jQuery/index.js Updates TextBox mask to exclude +1.
apps/demos/Demos/TextBox/Overview/Vue/App.vue Updates TextBox mask to exclude +1.
apps/demos/Demos/TextBox/Overview/ReactJs/App.js Updates TextBox mask to exclude +1.
apps/demos/Demos/TextBox/Overview/React/App.tsx Updates TextBox mask to exclude +1.
apps/demos/Demos/TextBox/Overview/Angular/app/app.component.html Updates TextBox mask to exclude +1.
apps/demos/Demos/RangeSelector/EmbeddedChart/jQuery/index.js Refreshes EmbeddedChart sample dates and selected range.
apps/demos/Demos/RangeSelector/EmbeddedChart/Vue/data.ts Refreshes EmbeddedChart Vue datasource dates.
apps/demos/Demos/RangeSelector/EmbeddedChart/Vue/App.vue Refreshes EmbeddedChart Vue selected range.
apps/demos/Demos/RangeSelector/EmbeddedChart/ReactJs/data.js Refreshes EmbeddedChart ReactJs datasource dates.
apps/demos/Demos/RangeSelector/EmbeddedChart/ReactJs/App.js Refreshes EmbeddedChart ReactJs selected range.
apps/demos/Demos/RangeSelector/EmbeddedChart/React/data.ts Refreshes EmbeddedChart React datasource dates.
apps/demos/Demos/RangeSelector/EmbeddedChart/React/App.tsx Refreshes EmbeddedChart React selected range.
apps/demos/Demos/RangeSelector/EmbeddedChart/Angular/app/app.component.ts Refreshes EmbeddedChart Angular datasource and selected range.
apps/demos/Demos/DateBox/Formatting/jQuery/index.js Updates DateBox formatting demo sample date/placeholders to 2025.
apps/demos/Demos/DateBox/Formatting/Vue/App.vue Updates DateBox formatting demo sample date/placeholders to 2025.
apps/demos/Demos/DateBox/Formatting/ReactJs/App.js Updates DateBox formatting demo sample date/placeholders to 2025.
apps/demos/Demos/DateBox/Formatting/React/App.tsx Updates DateBox formatting demo sample date/placeholders to 2025.
apps/demos/Demos/DateBox/Formatting/Angular/app/app.component.ts Updates DateBox formatting demo sample date to 2025.
apps/demos/Demos/DateBox/Formatting/Angular/app/app.component.html Updates DateBox formatting demo placeholders to 2025.
apps/demos/Demos/Common/EditorAppearanceVariants/jQuery/index.js Removes +1 from phone mask in EditorAppearanceVariants (jQuery).
apps/demos/Demos/Common/EditorAppearanceVariants/Vue/App.vue Removes +1 from phone mask in EditorAppearanceVariants (Vue).
apps/demos/Demos/Common/EditorAppearanceVariants/ReactJs/App.js Removes +1 from phone mask in EditorAppearanceVariants (ReactJs).
apps/demos/Demos/Common/EditorAppearanceVariants/React/App.tsx Removes +1 from phone mask in EditorAppearanceVariants (React).
apps/demos/Demos/Common/EditorAppearanceVariants/Angular/app/app.component.html Removes +1 from phone mask in EditorAppearanceVariants (Angular).
Comments suppressed due to low confidence (1)

apps/demos/Demos/Common/EditorAppearanceVariants/jQuery/index.js:81

  • maskRules defines a custom X rule, but the mask uses only 0 placeholders ((000) 000-0000), so the custom rule is never applied. Either update the mask to use X where the rule should apply (e.g., first digit of the area code), or remove the unused maskRules to avoid misleading behavior in the demo.
    mask: '(000) 000-0000',
    inputAttr: { 'aria-label': 'Phone' },
    maskRules: {
      X: /[02-9]/,
    },

marker-dao
marker-dao previously approved these changes Mar 24, 2026
Copilot AI review requested due to automatic review settings March 24, 2026 15:34
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 29 out of 62 changed files in this pull request and generated 4 comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants