Demos: Update old dates & remove +1 from mask in Editors#33024
Open
r-farkhutdinov wants to merge 3 commits intoDevExpress:26_1from
Open
Demos: Update old dates & remove +1 from mask in Editors#33024r-farkhutdinov wants to merge 3 commits intoDevExpress:26_1from
r-farkhutdinov wants to merge 3 commits intoDevExpress:26_1from
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates DevExtreme demo sources to keep sample data current and simplify phone input masks by removing the hard-coded +1 prefix across several editor demos.
Changes:
- Removed
+1from phonemaskpatterns in Validation/TextBox/EditorAppearanceVariants demos (jQuery/Vue/React/Angular). - Refreshed RangeSelector EmbeddedChart demo dates (2011–2012 → 2024–2025).
- Updated DateBox Formatting demo sample date/placeholder strings (2018 → 2025).
Reviewed changes
Copilot reviewed 29 out of 29 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/demos/Demos/Validation/Overview/jQuery/index.js | Updates phone mask to exclude +1. |
| apps/demos/Demos/Validation/Overview/Vue/App.vue | Updates phone mask to exclude +1. |
| apps/demos/Demos/Validation/Overview/ReactJs/App.js | Updates phone mask to exclude +1. |
| apps/demos/Demos/Validation/Overview/React/App.tsx | Updates phone mask to exclude +1. |
| apps/demos/Demos/Validation/Overview/Angular/app/app.component.html | Updates phone mask to exclude +1. |
| apps/demos/Demos/TextBox/Overview/jQuery/index.js | Updates TextBox mask to exclude +1. |
| apps/demos/Demos/TextBox/Overview/Vue/App.vue | Updates TextBox mask to exclude +1. |
| apps/demos/Demos/TextBox/Overview/ReactJs/App.js | Updates TextBox mask to exclude +1. |
| apps/demos/Demos/TextBox/Overview/React/App.tsx | Updates TextBox mask to exclude +1. |
| apps/demos/Demos/TextBox/Overview/Angular/app/app.component.html | Updates TextBox mask to exclude +1. |
| apps/demos/Demos/RangeSelector/EmbeddedChart/jQuery/index.js | Refreshes EmbeddedChart sample dates and selected range. |
| apps/demos/Demos/RangeSelector/EmbeddedChart/Vue/data.ts | Refreshes EmbeddedChart Vue datasource dates. |
| apps/demos/Demos/RangeSelector/EmbeddedChart/Vue/App.vue | Refreshes EmbeddedChart Vue selected range. |
| apps/demos/Demos/RangeSelector/EmbeddedChart/ReactJs/data.js | Refreshes EmbeddedChart ReactJs datasource dates. |
| apps/demos/Demos/RangeSelector/EmbeddedChart/ReactJs/App.js | Refreshes EmbeddedChart ReactJs selected range. |
| apps/demos/Demos/RangeSelector/EmbeddedChart/React/data.ts | Refreshes EmbeddedChart React datasource dates. |
| apps/demos/Demos/RangeSelector/EmbeddedChart/React/App.tsx | Refreshes EmbeddedChart React selected range. |
| apps/demos/Demos/RangeSelector/EmbeddedChart/Angular/app/app.component.ts | Refreshes EmbeddedChart Angular datasource and selected range. |
| apps/demos/Demos/DateBox/Formatting/jQuery/index.js | Updates DateBox formatting demo sample date/placeholders to 2025. |
| apps/demos/Demos/DateBox/Formatting/Vue/App.vue | Updates DateBox formatting demo sample date/placeholders to 2025. |
| apps/demos/Demos/DateBox/Formatting/ReactJs/App.js | Updates DateBox formatting demo sample date/placeholders to 2025. |
| apps/demos/Demos/DateBox/Formatting/React/App.tsx | Updates DateBox formatting demo sample date/placeholders to 2025. |
| apps/demos/Demos/DateBox/Formatting/Angular/app/app.component.ts | Updates DateBox formatting demo sample date to 2025. |
| apps/demos/Demos/DateBox/Formatting/Angular/app/app.component.html | Updates DateBox formatting demo placeholders to 2025. |
| apps/demos/Demos/Common/EditorAppearanceVariants/jQuery/index.js | Removes +1 from phone mask in EditorAppearanceVariants (jQuery). |
| apps/demos/Demos/Common/EditorAppearanceVariants/Vue/App.vue | Removes +1 from phone mask in EditorAppearanceVariants (Vue). |
| apps/demos/Demos/Common/EditorAppearanceVariants/ReactJs/App.js | Removes +1 from phone mask in EditorAppearanceVariants (ReactJs). |
| apps/demos/Demos/Common/EditorAppearanceVariants/React/App.tsx | Removes +1 from phone mask in EditorAppearanceVariants (React). |
| apps/demos/Demos/Common/EditorAppearanceVariants/Angular/app/app.component.html | Removes +1 from phone mask in EditorAppearanceVariants (Angular). |
Comments suppressed due to low confidence (1)
apps/demos/Demos/Common/EditorAppearanceVariants/jQuery/index.js:81
maskRulesdefines a customXrule, but the mask uses only0placeholders ((000) 000-0000), so the custom rule is never applied. Either update the mask to useXwhere the rule should apply (e.g., first digit of the area code), or remove the unusedmaskRulesto avoid misleading behavior in the demo.
mask: '(000) 000-0000',
inputAttr: { 'aria-label': 'Phone' },
maskRules: {
X: /[02-9]/,
},
apps/demos/Demos/Common/EditorAppearanceVariants/Angular/app/app.component.html
Show resolved
Hide resolved
marker-dao
previously approved these changes
Mar 24, 2026
marker-dao
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.