Broadcast autogenerated timestamp output dir name#721
Merged
Conversation
When the `--output-folder-name` flag is used there's no possibility of the different processes having a different output folder name, this value is only able to be different for different processes when generating a timestamp. Hence, the broadcast is only done for the case of an automatically generated timestamp output folder name.
dkazanc
approved these changes
May 29, 2026
Collaborator
dkazanc
left a comment
dkazanc
left a comment
There was a problem hiding this comment.
Thanks @yousefmoazzam , a nice and useful change. It certainly makes sense to broadcast the timestamp.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to guard against the possibility that multiple processes have a different timestamp output dir name, due to one or more of the processes being slower than rank 0 and reaching the timestamp-generation line later than rank 0.
Checklist
user-release-notelabel in order to include this PR in the "NotableChanges for Users" section in release notes