Skip to content

Add i18n support for the updated settings, home, sidebar, and git UI flows#581

Open
DamnCrab wants to merge 1 commit intoDimillian:mainfrom
DamnCrab:main
Open

Add i18n support for the updated settings, home, sidebar, and git UI flows#581
DamnCrab wants to merge 1 commit intoDimillian:mainfrom
DamnCrab:main

Conversation

@DamnCrab
Copy link

@DamnCrab DamnCrab commented Mar 24, 2026 

## Summary

This PR adds i18n support for UI areas that were updated in recent upstream changes.

Most of the work is in settings, home, sidebar, composer, and git-related UI. Recent refactors introduced new user-facing text and moved some existing UI into new components, so this PR adds localization support for those updated surfaces.

## What’s included

- added i18n support for newly introduced UI text
- connected translated strings in refactored components
- kept localization coverage consistent across settings, home, sidebar, composer, and git-related views
- adjusted locale-sensitive tests so translated behavior continues to be validated reliably

## What’s not included

To keep this PR focused and easier to review, I left out fork-only GitHub Actions changes and other unrelated maintenance work.

## Validation

- `npm run typecheck`
- `npm test`

@DamnCrab
feat: sync upstream UI refactor and preserve i18n coverage
dc09a64 
Bring the fork back on top of upstream/main while keeping only the
translation-related work that is suitable for an upstream PR.
What changed:
- adopt the upstream sidebar/composer/home/git UI refactors instead of
  keeping the older fork-only structure
- re-apply i18n integration on top of the new upstream component split
- add the missing locale keys required by the upstream UI changes
- update locale-sensitive tests so they validate translated behavior
  without depending on one specific relative-time wording
- drop fork-only GitHub Actions workflow changes from the final diff
Why:
- keep the PR reviewable for upstream by reducing history noise
- make the fork compatible with the latest upstream UI architecture
- ensure translated strings remain complete after the upstream refactor
chatgpt-codex-connector[bot]
chatgpt-codex-connector bot reviewed Mar 24, 2026
View reviewed changes
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dc09a642a6

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/features/settings/components/sections/SettingsDisplaySection.tsx
if (nextLang) {
void i18n.changeLanguage(nextLang);
} else {
void i18n.changeLanguage(undefined);
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Clear cached language when selecting system default

Choosing the “System default” option sets language to null but calls i18n.changeLanguage(undefined) without clearing the cached i18nextLng key. Since src/i18n.ts configures detection order as localStorage before navigator, the previous explicit language remains sticky across restarts, so users cannot actually return to OS language once they have picked a language. Clear the detector cache (or bypass localStorage for this case) when nextLang is null.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@DamnCrab