Remove continuous singletons from double-sided rows#2962
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## latest #2962 +/- ##
========================================
Coverage 72.94% 72.94%
========================================
Files 426 426
Lines 102185 102300 +115
Branches 16443 16460 +17
========================================
+ Hits 74540 74627 +87
- Misses 27369 27397 +28
Partials 276 276 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
This is great, @Opt-Mucca! I would like to experiment with this a llittle more. Also, there is |
|
@fwesselm I was worried that I was missing something, so please make any changes you want. |
|
@Opt-Mucca I've merge the fix for
|
|
This is now draft until the maths has been checked and the error-checking code has been removed |
General idea: We currently have no explicit reduction for a column
s, with0cost, and that only appears in a single double-sided rowb_0 <= a^Tx + cs <= b_1. Dual fixing removes all cases whereb_0 == -kHighsInforb_1 == kHighsInf, but the column is left alone ifb_0andb_1are finite. Removing the column may allow additional reductions to be made.Motivation: I was playing around with an instance, trying to figure out why HiGHS wasn't making a reduction, and thought this would help (spoiler: it did not), but while doing so I stumbled upon an old TODO in the code with the exact suggestion.
@fwesselm Three major questions:
shas infinite bounds, but in theory we could handle that here. The issue is I'm not sure what to do with infinite values in postsolve.Edit: Need to look into the failing tests (they're passing locally.....). Windows does not like this change at all.