Add CORDEX domain target grids for regridding#3096
Conversation
|
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3096 +/- ##
==========================================
- Coverage 96.14% 96.01% -0.13%
==========================================
Files 267 267
Lines 15771 15803 +32
==========================================
+ Hits 15163 15174 +11
- Misses 608 629 +21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Looks like a great start! Could you take a look at the checklist? A few things to do would be
- sign the CLA
- add a unit test
- add documentation
Usually you can find advice on how to go about that in the pull request template, but in case you missed it you can find it here: https://github.com/ESMValGroup/ESMValCore/blob/main/.github/pull_request_template.md
| Dummy cube with rotated-pole dimension coordinates and geographical | ||
| auxiliary coordinates matching the official domain specification. | ||
| """ | ||
| domain = cx.cordex_domain(domain_name, bounds=True) |
There was a problem hiding this comment.
Maybe you could simplify this code by using ncdata.iris_xarray.cubes_to_xarray to convert the xarray.Dataset to an iris.cube.Cube directly?
Description
Adds support for using standard CORDEX domain names, such as
EUR-11, astarget_gridvalues in theregridpreprocessor.Previously,
target_grid: EUR-11was treated as anMxNgrid specification and failed with:Close #3088