fix local zarr#650
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request modifies the early return condition in the LandingHome component's useEffect hook to check if initStore starts with 'local:' instead of 'local'. However, this change introduces a bug where local NetCDF files will no longer trigger the early return, resulting in their metadata being overwritten by the previously active Zarr store. It is recommended to update the condition to check for 'local', 'local:', and whether useNC is active.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
while adding functionality for local servers I had a name clash (added a bug)
local:vslocal, wherelocalis a global state use when uploading local netCDF or Zarr stores. For now this fixes the issue of opening in those cases. We should have more descriptive names in the future.