Bugfix: no run names in ReportFilter.#4848
Open
feyruzb wants to merge 2 commits into
Open
Conversation
Collaborator
|
Please check if this fix is needed with the run filter issue fix from PR #4850. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes improvements to how filter presets are saved and managed in the report filtering UI, particularly ensuring that selected run names are correctly serialized with presets and refining some filter lifecycle methods.
Improvements to preset saving and serialization:
reportFilterand explicitly adds the selected run names (runName) to it, ensuring that run selections are preserved when serializing and restoring presets.selectedItemsproperty is now exposed from theBaselineRunFiltercomponent, making it accessible to parent components for preset management.Refinements to filter lifecycle and UI updates:
updateUrl()was removed from thegetFilterPresetfunction, to prevent unnecessary URL updates when applying a preset.updateAllFilters()was removed fromclearToolbarSilently, to streamline the clearing process and avoid redundant updates.