Skip to content

Bugfix: no run names in ReportFilter.#4848

Open
feyruzb wants to merge 2 commits into
Ericsson:masterfrom
feyruzb:bugfix/no-run-names
Open

Bugfix: no run names in ReportFilter.#4848
feyruzb wants to merge 2 commits into
Ericsson:masterfrom
feyruzb:bugfix/no-run-names

Conversation

@feyruzb
Copy link
Copy Markdown
Collaborator

@feyruzb feyruzb commented May 14, 2026

This pull request makes improvements to how filter presets are saved and managed in the report filtering UI, particularly ensuring that selected run names are correctly serialized with presets and refining some filter lifecycle methods.

Improvements to preset saving and serialization:

  • When saving a filter preset, the code now clones the current reportFilter and explicitly adds the selected run names (runName) to it, ensuring that run selections are preserved when serializing and restoring presets.
  • The selectedItems property is now exposed from the BaselineRunFilter component, making it accessible to parent components for preset management.

Refinements to filter lifecycle and UI updates:

  • The call to updateUrl() was removed from the getFilterPreset function, to prevent unnecessary URL updates when applying a preset.
  • The call to updateAllFilters() was removed from clearToolbarSilently, to streamline the clearing process and avoid redundant updates.

@feyruzb feyruzb added this to the release 6.29.0 milestone May 14, 2026
@feyruzb feyruzb self-assigned this May 14, 2026
@feyruzb feyruzb requested review from bruntib and vodorok as code owners May 14, 2026 14:26
@gulyasgergely902
Copy link
Copy Markdown
Collaborator

Please check if this fix is needed with the run filter issue fix from PR #4850.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants