fix: break VoiceOver grouping on iOS so task checkbox is independently focusable by Krishna2323 · Pull Request #91530 · Expensify/App

Krishna2323 · 2026-05-24T07:00:42Z

Explanation of Change

Fixed Issues

$ #77574
PROPOSAL:

Tests

Here are the test steps:

Prerequisites:

Have a task created in a chat (e.g., "Take a test drive")
Enable VoiceOver on iOS

iOS (Primary fix):

Open a chat containing a task
Enable VoiceOver
Swipe to navigate to the task action
Verify the checkbox is independently focusable and announced as "Not checked, Task: <title>, checkbox, double tap to toggle"
Swipe again to the title area
Verify it's announced as "Task: <title>, button, double tap to activate"
Double tap the checkbox to toggle completion
Verify the state updates correctly

Android:

Open a chat containing a task
Enable TalkBack
Navigate to the task action
Verify the checkbox and title are still individually focusable (no regression)
Verify the accessibility label reads "Task: <title>" instead of raw HTML

Web:

Open a chat containing a task
Tab through the chat messages
Verify the task row is still focusable as a single element (no change from before)
Verify long press / right-click context menu still works on the task row

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests
Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

…y focusable Signed-off-by: krishna2323 <belivethatkg@gmail.com>

codecov · 2026-05-24T07:09:02Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
...libs/shouldBreakAccessibilityGrouping/index.ios.ts	`100.00% <100.00%> (ø)`
src/pages/inbox/report/PureReportActionItem.tsx	`91.95% <100.00%> (+0.08%)`	⬆️
src/libs/shouldBreakAccessibilityGrouping/index.ts	`0.00% <0.00%> (ø)`
src/components/ReportActionItem/TaskPreview.tsx	`82.05% <66.66%> (-4.52%)`	⬇️
src/components/ReportActionItem/TaskView.tsx	`0.00% <0.00%> (ø)`
... and 135 files with indirect coverage changes

…sions on other platforms Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 · 2026-05-24T23:24:50Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 37a3806a51

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

mkhutornyi · 2026-05-25T02:11:02Z

Mostly looks good.

Just one issue found.

After toggle checkbox, old checked state is announced. This happens on both pages.

Checkbox is in unchecked state
Screen reader announces "..., unchecked"
Toggle checkbox by double tap. Now checkbox is in checked state
Screen reader still announces "..., unchecked" instead of "..., checked"
Toggle checkbox again. Now checkbox is in unchecked state
Screen reader announces "..., checked" instead of "..., unchecked"

…fter toggle Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 · 2026-05-25T02:48:09Z

@mkhutornyi could you please check again?

mkhutornyi · 2026-05-25T02:52:17Z

                    )}
                    <PressableWithSecondaryInteraction
                        ref={popoverAnchorRef}
+                        accessible={shouldBreakAccessibilityGrouping() && isCreatedTaskReportAction(action) ? false : undefined}


As setting false here, no pressed feedback. I'm afraid QA will mark this as regression

Screen.Recording.2026-05-25.at.3.50.00.AM.mov

production:

Screen.Recording.2026-05-25.at.3.51.11.AM.mov

Tried to fix that, could you please check?

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

mkhutornyi · 2026-05-25T11:26:34Z

+    const [prevIsTaskCompletedFromOnyx, setPrevIsTaskCompletedFromOnyx] = useState(isTaskCompletedFromOnyx);
+    const [isTaskCompleted, setIsTaskCompleted] = useState(isTaskCompletedFromOnyx);


Double states for the same state variable seems workaround to me

Now local state is only used when shouldBreakGrouping && isScreenReaderActive (iOS + VoiceOver).

mkhutornyi · 2026-05-25T11:31:33Z

+    const [prevIsTaskCompletedFromOnyx, setPrevIsTaskCompletedFromOnyx] = useState(isTaskCompletedFromOnyx);
+    const [isTaskCompleted, setIsTaskCompleted] = useState(isTaskCompletedFromOnyx);
+
+    if (prevIsTaskCompletedFromOnyx !== isTaskCompletedFromOnyx) {
+        setPrevIsTaskCompletedFromOnyx(isTaskCompletedFromOnyx);
+        setIsTaskCompleted(isTaskCompletedFromOnyx);
+    }


This local state update logic now runs on every platform, not just iOS.
If completeTask/reopenTask ever fails or is queued offline and the underlying Onyx state doesn't flip, the local state might read "checked" briefly until the next re-render syncs back. Please verify this case.
And consider scoping this to shouldBreakGrouping only.

Scoped. setLocalIsTaskCompleted is only called on iOS + VoiceOver. On all other platforms, isTaskCompleted resolves directly to the Onyx value.

…le click check Signed-off-by: krishna2323 <belivethatkg@gmail.com>

…edback for title area Signed-off-by: krishna2323 <belivethatkg@gmail.com>

melvin-bot · 2026-05-28T05:22:51Z

@mkhutornyi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Krishna2323 · 2026-05-28T05:24:25Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9523a108e8

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

mkhutornyi · 2026-05-28T08:56:11Z

                                            <View style={[styles.flexRow, styles.flex1]}>
                                                <Checkbox
                                                    onPress={callFunctionIfActionIsAllowed(() => {
-                                                        // If we're already navigating to these task editing pages, early return not to mark as completed, otherwise we would have not found page.


Please restore this comment

mkhutornyi · 2026-05-28T09:13:47Z

    const iconWrapperStyle = StyleUtils.getTaskPreviewIconWrapper(hasAssignee ? avatarSize : undefined);

    const shouldShowGreenDotIndicator = isOpenTaskReport(taskContextReport, action) && isReportManager(taskContextReport);
+    const taskAccessibilityLabel = taskTitleWithoutImage ? `${translate('task.task')}: ${taskTitleWithoutImage}` : translate('task.task');


Raw html is announced here.

mkhutornyi · 2026-05-28T09:16:56Z

When double tap "Take a test drive", it opens test drive modal instead of navigating to detail page.

…comment Signed-off-by: krishna2323 <belivethatkg@gmail.com>

joekaufmanexpensify

Fine for product

fix: break VoiceOver grouping on iOS so task checkbox is independentl…

c4b9452

…y focusable Signed-off-by: krishna2323 <belivethatkg@gmail.com>

melvin-bot Bot assigned Krishna2323 May 24, 2026

fix: conditionally render inner pressable only on iOS to avoid regres…

37a3806

…sions on other platforms Signed-off-by: krishna2323 <belivethatkg@gmail.com>

chatgpt-codex-connector Bot reviewed May 24, 2026

View reviewed changes

Comment thread src/components/ReportActionItem/TaskPreview.tsx Outdated

Krishna2323 mentioned this pull request May 24, 2026

[$250] Screen Reader: New Chat: Checkbox announced as variable, without role or state #77574

Open

fix: use local state for checkbox to announce correct checked state a…

8e10ec2

…fter toggle Signed-off-by: krishna2323 <belivethatkg@gmail.com>

mkhutornyi reviewed May 25, 2026

View reviewed changes

fix: only break accessibility grouping when screen reader is active

2bd995f

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

mkhutornyi reviewed May 25, 2026

View reviewed changes

Krishna2323 added 3 commits May 28, 2026 09:36

Merge branch 'main' into fix/77574-task-checkbox-accessibility

a7cc4a0

fix: scope local checkbox state to screen reader and remove unreachab…

661fac7

…le click check Signed-off-by: krishna2323 <belivethatkg@gmail.com>

fix: use View with accessibilityActions instead of PressableWithoutFe…

9523a10

…edback for title area Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 marked this pull request as ready for review May 28, 2026 05:22

Krishna2323 requested review from a team as code owners May 28, 2026 05:22

melvin-bot Bot requested review from joekaufmanexpensify and mkhutornyi and removed request for a team May 28, 2026 05:22

melvin-bot Bot removed the request for review from a team May 28, 2026 05:22

chatgpt-codex-connector Bot reviewed May 28, 2026

View reviewed changes

Comment thread src/components/ReportActionItem/TaskView.tsx Outdated

fix: mark task title as disabled for VoiceOver when not interactive

72a67fd

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

mkhutornyi reviewed May 28, 2026

View reviewed changes

fix: use plain text for task accessibility label and restore removed …

e51b279

…comment Signed-off-by: krishna2323 <belivethatkg@gmail.com>

joekaufmanexpensify approved these changes May 29, 2026

View reviewed changes

		const [prevIsTaskCompletedFromOnyx, setPrevIsTaskCompletedFromOnyx] = useState(isTaskCompletedFromOnyx);
		const [isTaskCompleted, setIsTaskCompleted] = useState(isTaskCompletedFromOnyx);

Conversation

Krishna2323 commented May 24, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented May 24, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Krishna2323 commented May 24, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

mkhutornyi commented May 25, 2026

Uh oh!

Krishna2323 commented May 25, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented May 28, 2026

Uh oh!

Krishna2323 commented May 28, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mkhutornyi commented May 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov Bot commented May 24, 2026 •

edited by github-actions Bot

Loading

mkhutornyi commented May 28, 2026 •

edited

Loading