refactor: update GitHub installation completion message#7202
Open
mustafajw07 wants to merge 1 commit intoFlagsmith:mainfrom
Open
refactor: update GitHub installation completion message#7202mustafajw07 wants to merge 1 commit intoFlagsmith:mainfrom
mustafajw07 wants to merge 1 commit intoFlagsmith:mainfrom
Conversation
|
@mustafajw07 is attempting to deploy a commit to the Flagsmith Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
@mustafajw07 Thanks for your contribution! I'm afraid, however, this patch does not meet the Acceptance Criteria specified in #7143 yet. If you'd be so kind also, please add a screenshot to the PR description — that makes it easier to review! Note the window size of the screenshot, given this page opens as a small popup containing the GitHub OAuth flow (see issue examples). |
Author
Apologies, i will take i look again. |
Zaimwa9
approved these changes
Apr 13, 2026
Zaimwa9
requested changes
Apr 13, 2026
Contributor
Zaimwa9
left a comment
There was a problem hiding this comment.
Removing my approval after reading the threads, my bad
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Contributes to 7143
Updated the GitHub integration setup completion view in
GitHubSetupPageto correctly match the required UI acceptance criteria:<h1>Installation Completed</h1>layout.How did you test this code?
Tested manually on the local frontend dev server:
ENV=local npm run dev.localStorage.setItem('githubIntegrationSetupFromFlagsmith', 'install');/github-setup.