refactor: Migrate react-select to semantic color tokens#7214
Draft
talissoncosta wants to merge 1 commit intomainfrom
Draft
refactor: Migrate react-select to semantic color tokens#7214talissoncosta wants to merge 1 commit intomainfrom
talissoncosta wants to merge 1 commit intomainfrom
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/if required so people know about the feature.Changes
Contributes to the design system migration — replaces SCSS variables with semantic CSS custom properties.
Problem
_react-select.scssused SCSS variables ($input-bg-dark, $bg-dark200, etc.) with a separate.dark {}block for dark mode.CustomOptionusedgetDarkMode()+ hardcoded hex values.CustomMultiValueused all inline styles. Dark mode didn't work in Storybook because the.darkclass wasn't always propagated.Solution
_react-select.scss:
var(--color-surface-default),var(--color-surface-hover),var(--color-text-default), etc.).dark {}block — tokens resolve differently per theme automaticallyCustomOption:
d-flex,align-items-center,gap-2,px-3,py-2)getDarkMode()+ hardcoded colours withbg-surface-hovertoken classColorSwatchfor colour dotgetDarkModeimportCustomMultiValue:
rounded-sm,text-white,text-nowrap,text-truncate)btn-close-whitefor remove buttonToken mapping
How did you test this code?
npm run storybook→ Components/MultiSelect — all 7 variants render in light and dark modeENV=local npm run dev— Select dropdowns throughout the app look correct in both themes🤖 Generated with Claude Code