Skip to content

Conversation

@cstns
Copy link
Contributor

@cstns cstns commented Jan 9, 2026

Description

Tidying up after the expert release before the holidays where it was found that menu items that were teleported to the body of the page either overflowed outside the viewport or had their widths impacted.

Menu width and positioning is measured and adjusted in a cohesive manner across components.

This PR improves overflow detection and collision detection and fixes menu widths while serving a starting point for the following work on the kebab menu.

As a quick fix, I also addressed the teleports in these components and correctly placed them in the teleported slot so they produce their effects.

Related Issue(s)

pre-requisite for #6374

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production
  • Link to Changelog Entry PR, or note why one is not needed.

Labels

  • Includes a DB migration? -> add the area:migration label

@cstns cstns self-assigned this Jan 9, 2026
@cstns cstns marked this pull request as draft January 9, 2026 17:28
@codecov
Copy link

codecov bot commented Jan 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.42%. Comparing base (6fcab5c) to head (61e1a39).
⚠️ Report is 16 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6488   +/-   ##
=======================================
  Coverage   76.42%   76.42%           
=======================================
  Files         396      396           
  Lines       19887    19887           
  Branches     4768     4768           
=======================================
  Hits        15199    15199           
  Misses       4688     4688           
Flag Coverage Δ
backend 76.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cstns cstns marked this pull request as ready for review January 12, 2026 13:22
@cstns cstns requested a review from Steve-Mcl January 13, 2026 13:57
Copy link
Contributor

@Steve-Mcl Steve-Mcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code good. 1 issue spotted - the team name is now a weird colour when hovered.

Image

This is not happening on FFC Live

I'll merge main in case it was a previously fixed issue before approving.

@Steve-Mcl
Copy link
Contributor

Code good. 1 issue spotted - the team name is now a weird colour when hovered.

Image Image

This is not happening on FFC Live

I'll merge main in case it was a previously fixed issue before approving.

Still happening after main merge! Weird!

@cstns
Copy link
Contributor Author

cstns commented Jan 14, 2026

should be fixed now

@Steve-Mcl Steve-Mcl self-requested a review January 14, 2026 09:51
Copy link
Contributor

@Steve-Mcl Steve-Mcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on pre-staging. checked as many places I could think of. Witnessed collision detect working (meu appeared below dropdown when enough space, above when not.

@Steve-Mcl Steve-Mcl merged commit d280b78 into main Jan 14, 2026
33 of 34 checks passed
@Steve-Mcl Steve-Mcl deleted the teleported-menus-alignment branch January 14, 2026 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants