-
Notifications
You must be signed in to change notification settings - Fork 82
Teleported menus alignment #6488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ve menu positioning and state synchronization logic.
…nents and refine position re-calculations for overflow handling.
…listbox, and combobox components, and simplify position re-calculations.
…nu positioning logic.
… ComboBox components.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6488 +/- ##
=======================================
Coverage 76.42% 76.42%
=======================================
Files 396 396
Lines 19887 19887
Branches 4768 4768
=======================================
Hits 15199 15199
Misses 4688 4688
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ponents for consistency
Steve-Mcl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…om team selection layout.
|
should be fixed now |
Steve-Mcl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested on pre-staging. checked as many places I could think of. Witnessed collision detect working (meu appeared below dropdown when enough space, above when not.


Description
Tidying up after the expert release before the holidays where it was found that menu items that were teleported to the body of the page either overflowed outside the viewport or had their widths impacted.
Menu width and positioning is measured and adjusted in a cohesive manner across components.
This PR improves overflow detection and collision detection and fixes menu widths while serving a starting point for the following work on the kebab menu.
As a quick fix, I also addressed the teleports in these components and correctly placed them in the teleported slot so they produce their effects.
Related Issue(s)
pre-requisite for #6374
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
area:migrationlabel