Skip to content

Conversation

@cstns
Copy link
Contributor

@cstns cstns commented Jan 12, 2026

Description

Refactor to replace ff-list-item with ff-kebab-item across components and tests for improved structure and consistency.

Related Issue(s)

closes #6374

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production
  • Link to Changelog Entry PR, or note why one is not needed.

Labels

  • Includes a DB migration? -> add the area:migration label

…ents and tests for improved structure and consistency.
@codecov
Copy link

codecov bot commented Jan 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.42%. Comparing base (1c343d7) to head (c7873e2).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6490   +/-   ##
=======================================
  Coverage   76.42%   76.42%           
=======================================
  Files         396      396           
  Lines       19890    19890           
  Branches     4771     4771           
=======================================
  Hits        15201    15201           
  Misses       4689     4689           
Flag Coverage Δ
backend 76.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

cstns added 2 commits January 12, 2026 15:23
…-menu-headless-ui_follow-up

# Conflicts:
#	frontend/src/ui-components/components/kebab-menu/KebabMenu.vue
@Steve-Mcl
Copy link
Contributor

@cstns are you looking at e2e fails?

  │ ✖  brokers/3rd-party-broker.spec.js         00:09        5        4        1        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✖  brokers/brokers.spec.js                  00:33       12        7        5        -        - │
  
  
  ✖  2 of 29 failed (7%)  

Base automatically changed from 6374_kebab-menu-headless-ui to main January 14, 2026 15:25
Copy link
Contributor

@Steve-Mcl Steve-Mcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good

@Steve-Mcl
Copy link
Contributor

Was an e2e test fail. Merging main before digging.

@Steve-Mcl Steve-Mcl enabled auto-merge January 14, 2026 17:08
@Steve-Mcl Steve-Mcl merged commit ff69e98 into main Jan 14, 2026
22 checks passed
@Steve-Mcl Steve-Mcl deleted the 6374_kebab-menu-headless-ui_follow-up branch January 14, 2026 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Alter the existing kebab-menu component to use headless-ui for accessibility

3 participants