fix: raise errors on invalid inits, failed integrations, etc.#243
Merged
Conversation
Merging this PR will not alter performance
|
beckermr
commented
May 15, 2026
beckermr
commented
May 15, 2026
beckermr
commented
May 15, 2026
beckermr
commented
May 15, 2026
Co-authored-by: Matthew R. Becker <beckermr@users.noreply.github.com>
beckermr
commented
May 15, 2026
Collaborator
Author
|
Ok this one is ready for an initial look @ismael-mendoza. I expect we may iterate a bit on this one. |
ismael-mendoza
requested changes
May 18, 2026
Collaborator
ismael-mendoza
left a comment
There was a problem hiding this comment.
Thanks Matt! I only have a few minor comments
beckermr
commented
May 18, 2026
Co-authored-by: Matthew R. Becker <beckermr@users.noreply.github.com>
Add type checking for seed parameter in the seed method.
Collaborator
Author
|
@ismael-mendoza This one is ready for another look! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As it says above...