Skip to content

fix: raise errors on invalid inits, failed integrations, etc.#243

Merged
beckermr merged 55 commits into
mainfrom
equinox-err-2
May 18, 2026
Merged

fix: raise errors on invalid inits, failed integrations, etc.#243
beckermr merged 55 commits into
mainfrom
equinox-err-2

Conversation

@beckermr
Copy link
Copy Markdown
Collaborator

As it says above...

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 14, 2026

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

✅ 36 untouched benchmarks


Comparing equinox-err-2 (24f1ccf) with main (f6ed18a)

Open in CodSpeed

@beckermr beckermr changed the title fix: raise errors on failed integrations fix: raise errors on invalid inits, failed integrations, etc. May 14, 2026
Comment thread jax_galsim/gsobject.py Outdated
Comment thread jax_galsim/gsobject.py Outdated
Comment thread jax_galsim/core/utils.py
Comment thread jax_galsim/moffat.py
Comment thread jax_galsim/moffat.py Outdated
@beckermr beckermr marked this pull request as ready for review May 16, 2026 00:58
@beckermr
Copy link
Copy Markdown
Collaborator Author

Ok this one is ready for an initial look @ismael-mendoza. I expect we may iterate a bit on this one.

Copy link
Copy Markdown
Collaborator

@ismael-mendoza ismael-mendoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Matt! I only have a few minor comments

Comment thread jax_galsim/angle.py
Comment thread jax_galsim/bounds.py
Comment thread jax_galsim/random.py Outdated
Comment thread jax_galsim/random.py Outdated
Comment thread jax_galsim/random.py Outdated
beckermr added 3 commits May 18, 2026 11:52
Co-authored-by: Matthew R. Becker <beckermr@users.noreply.github.com>
Add type checking for seed parameter in the seed method.
@beckermr
Copy link
Copy Markdown
Collaborator Author

@ismael-mendoza This one is ready for another look!

@beckermr beckermr requested a review from ismael-mendoza May 18, 2026 17:33
@beckermr beckermr mentioned this pull request May 18, 2026
4 tasks
Copy link
Copy Markdown
Collaborator

@ismael-mendoza ismael-mendoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@beckermr beckermr merged commit 948d92b into main May 18, 2026
10 checks passed
@beckermr beckermr deleted the equinox-err-2 branch May 18, 2026 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants