Skip to content

Conversation

@nstarman
Copy link
Contributor

No description provided.

Signed-off-by: nstarman <[email protected]>
@nstarman nstarman added this to the v0.4.x milestone Dec 10, 2025
Copilot AI review requested due to automatic review settings December 10, 2025 01:02
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the nox automation framework and modernizes the project's development infrastructure. The changes include upgrading nox to version 2025.11.12, integrating nox-uv for faster dependency management, adding new linting tools (mypy, pylint), and reorganizing dependency groups using PEP 735 standards. The noxfile has been significantly refactored to use the nox-uv integration pattern with dependency groups, and the CI workflow has been streamlined to use the new session structure.

Key Changes

  • Upgraded nox from 2024.10.9 to 2025.11.12 and added nox-uv integration for faster virtual environment management
  • Added mypy and pylint to the lint dependency group for enhanced code quality checking
  • Reorganized pyproject.toml dependency groups following PEP 735, creating separate groups for build, lint, nox, and test
  • Refactored noxfile.py to use nox-uv's @session decorator with uv_groups parameter, eliminating manual dependency installation

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

File Description
uv.lock Updated lock file with new versions of nox (2025.11.12), added dependencies including nox-uv, mypy, pylint, and their transitive dependencies across multiple Python versions
pyproject.toml Reorganized structure: moved [build-system] after [project], created new dependency groups (build, lint) using PEP 735 format, added mypy/pylint/nox-uv to dependencies, added codespell configuration
noxfile.py Refactored to use nox-uv integration: imported session from nox_uv, converted all sessions to use uv_groups parameter, split lint into separate precommit/pylint/mypy sessions, renamed tests to test, removed manual session.install() calls
.github/workflows/ci.yml Renamed 'pre-commit' job to 'format', consolidated linting steps into single nox -s lint call, added new 'status' job for overall CI pass/fail aggregation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: nstarman <[email protected]>
@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (5e90c91) to head (39e10ed).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #40   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines           82        81    -1     
=========================================
- Hits            82        81    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: nstarman <[email protected]>
Signed-off-by: nstarman <[email protected]>
Signed-off-by: nstarman <[email protected]>
@nstarman nstarman merged commit 4081e15 into GalacticDynamics:main Dec 10, 2025
15 checks passed
@nstarman nstarman deleted the nox branch December 10, 2025 03:51
meeseeksmachine pushed a commit to meeseeksmachine/optional_dependencies that referenced this pull request Dec 10, 2025
nstarman added a commit that referenced this pull request Dec 10, 2025
Co-authored-by: Nathaniel Starkman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant