fix: audio recordings fixes and performance improvements#3514
Merged
isekovanic merged 13 commits intodevelopfrom Mar 25, 2026
Merged
fix: audio recordings fixes and performance improvements#3514isekovanic merged 13 commits intodevelopfrom
isekovanic merged 13 commits intodevelopfrom
Conversation
Contributor
SDK Size
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Goal
This PR fixes several SDK side audio bugs and interaction issues around voice recordings and audio attachments.
The main change is a (long overdue) rewrite of our audio playing management so that it no longer relies on
react-native-videoforstream-chat-react-native. The main rationale' was the fact that it would appear the specific format we use was not seekable at all (and no way to forcereact-native-videoto seek withAdtsExtractor.FLAG_ENABLE_CONSTANT_BITRATE_SEEKING_ALWAYS, at least that I know of). In addition to that, usingreact-native-nitro-soundis much more stable and performant.Additionally, this PR also includes:
WaveProgressBar)WaveProgressBarworkletusage🛠 Implementation details
🎨 UI Changes
iOS
Android
🧪 Testing
☑️ Checklist
developbranch