Skip to content

fix: design token and icon changes #3530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
isekovanic merged 4 commits into from
Apr 3, 2026
Merged

fix: design token and icon changes #3530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
13f2960
fix: final icon renaming
isekovanic Apr 3, 2026
c5f5511
fix: final token bump
isekovanic Apr 3, 2026
d334d7d
chore: bump podfile.lock
isekovanic Apr 3, 2026
036b95e
fix: lint issues and tests
isekovanic Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/SampleApp/ios/Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1948,7 +1948,7 @@ PODS:
- ReactCommon/turbomodule/core
- SocketRocket
- Yoga
- react-native-cameraroll (7.10.0):
- react-native-cameraroll (7.10.2):
- boost
- DoubleConversion
- fast_float
Expand Down Expand Up @@ -3680,7 +3680,7 @@ SPEC CHECKSUMS:
React-microtasksnativemodule: dcf5321c9a41659a6718df8a5f202af1577c6825
react-native-blob-util: a511afccff6511544ebf56928e6afdf837b037a7
react-native-blur: ecdc987ab8d8fba95abef14551f033376872d0a6
react-native-cameraroll: 8c3ba9b6f511cf645778de19d5039b61d922fdfb
react-native-cameraroll: 5c5fb716af11f6178dca48271ae065cd786a0a02
react-native-document-picker: b37cf6660ad9087b782faa78a1e67687fac15bfd
react-native-geolocation: b7f68b8c04e36ee669c630dbc48dd42cf93a0a41
react-native-image-picker: 9bceb747cd6cde22a3416ffdc819d11b5b11f156
Expand Down
4 changes: 2 additions & 2 deletions examples/SampleApp/src/theme/useLegacyColors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,14 @@ export const useLegacyColors = () => {
() => ({
accent_blue: semantics.accentPrimary,
accent_red: semantics.accentError,
bg_gradient_end: semantics.backgroundCoreSurface,
bg_gradient_end: semantics.backgroundCoreSurfaceDefault,
bg_gradient_start: semantics.backgroundCoreSurfaceSubtle,
black: semantics.textPrimary,
button_background: semantics.buttonPrimaryBg,
button_text: semantics.buttonPrimaryTextOnAccent,
grey: semantics.textSecondary,
grey_gainsboro: semantics.borderCoreDefault,
grey_whisper: semantics.backgroundCoreSurface,
grey_whisper: semantics.backgroundCoreSurfaceDefault,
icon_background: semantics.backgroundCoreApp,
overlay: semantics.badgeBgOverlay,
white: semantics.backgroundCoreApp,
Expand Down
2 changes: 1 addition & 1 deletion package/src/components/AITypingIndicatorView/AITypingIndicatorView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ const useStyles = () => {
return useMemo(() => {
return StyleSheet.create({
container: {
backgroundColor: semantics.backgroundCoreSurface,
backgroundColor: semantics.backgroundCoreSurfaceDefault,
paddingHorizontal: primitives.spacingMd,
paddingVertical: primitives.spacingLg,
...container,
Expand Down
2 changes: 1 addition & 1 deletion package/src/components/ChannelList/ChannelListHeaderErrorIndicator.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ const useStyles = () => {
alignItems: 'center',
justifyContent: 'center',
width: '100%',
backgroundColor: semantics.backgroundCoreSurface,
backgroundColor: semantics.backgroundCoreSurfaceDefault,
paddingVertical: primitives.spacingXs,
paddingHorizontal: primitives.spacingSm,
...container,
Expand Down
2 changes: 1 addition & 1 deletion package/src/components/ChannelList/ChannelListHeaderNetworkDownIndicator.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ const useStyles = () => {
alignItems: 'center',
justifyContent: 'center',
width: '100%',
backgroundColor: semantics.backgroundCoreSurface,
backgroundColor: semantics.backgroundCoreSurfaceDefault,
paddingVertical: primitives.spacingXs,
paddingHorizontal: primitives.spacingSm,
...container,
Expand Down
2 changes: 1 addition & 1 deletion package/src/components/ChannelList/Skeleton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ const SkeletonBlock = ({ style }: { style: React.ComponentProps<typeof View>['st
return (
<View style={style}>
<NativeShimmerView
baseColor={semantics.backgroundCoreSurface}
baseColor={semantics.backgroundCoreSurfaceDefault}
duration={animationTime}
gradientColor={semantics.skeletonLoadingHighlight}
style={StyleSheet.absoluteFillObject}
Expand Down
4 changes: 2 additions & 2 deletions package/src/components/ChannelPreview/ChannelSwipableWrapper.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,12 +143,12 @@ const useStyles = () => {
justifyContent: 'center',
},
elipsis: {
backgroundColor: semantics.backgroundCoreSurface,
backgroundColor: semantics.backgroundCoreSurfaceDefault,
},
standard: {
backgroundColor: semantics.accentPrimary,
},
}),
[semantics.accentPrimary, semantics.backgroundCoreSurface],
[semantics.accentPrimary, semantics.backgroundCoreSurfaceDefault],
);
};
2 changes: 1 addition & 1 deletion package/src/components/ChannelPreview/__tests__/ChannelSwipableWrapper.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jest.mock('../../../contexts', () => ({
theme: {
semantics: {
accentPrimary: '#00f',
backgroundCoreSurface: '#fff',
backgroundCoreSurfaceDefault: '#fff',
textOnAccent: '#000',
textPrimary: '#111',
},
Expand Down
51 changes: 30 additions & 21 deletions package/src/components/MessageInput/__tests__/__snapshots__/AttachButton.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ exports[`AttachButton should call handleAttachButtonPress when the button is cli
align="xMidYMid"
bbHeight={20}
bbWidth={20}
fill="none"
focusable={false}
height={20}
meetOrSlice={0}
Expand All @@ -112,14 +113,10 @@ exports[`AttachButton should call handleAttachButtonPress when the button is cli
width={20}
>
<RNSVGGroup
fill={
{
"payload": 4278190080,
"type": 0,
}
}
fill={null}
propList={
[
"fill",
"stroke",
"strokeWidth",
]
Expand All @@ -144,6 +141,8 @@ exports[`AttachButton should call handleAttachButtonPress when the button is cli
[
"stroke",
"strokeWidth",
"strokeLinecap",
"strokeLinejoin",
]
}
stroke={
Expand All @@ -152,6 +151,8 @@ exports[`AttachButton should call handleAttachButtonPress when the button is cli
"type": 0,
}
}
strokeLinecap={1}
strokeLinejoin={1}
strokeWidth={1.5}
/>
</RNSVGGroup>
Expand Down Expand Up @@ -613,7 +614,7 @@ exports[`AttachButton should call handleAttachButtonPress when the button is cli
}
strokeLinecap={1}
strokeLinejoin={1}
strokeWidth={1.2}
strokeWidth={1.5}
/>
</RNSVGGroup>
</RNSVGSvgView>
Expand Down Expand Up @@ -748,6 +749,7 @@ exports[`AttachButton should call handleAttachButtonPress when the button is cli
[
"stroke",
"strokeWidth",
"strokeLinecap",
"strokeLinejoin",
]
}
Expand All @@ -757,6 +759,7 @@ exports[`AttachButton should call handleAttachButtonPress when the button is cli
"type": 0,
}
}
strokeLinecap={1}
strokeLinejoin={1}
strokeWidth={1.5}
/>
Expand Down Expand Up @@ -982,6 +985,7 @@ exports[`AttachButton should render a enabled AttachButton 1`] = `
align="xMidYMid"
bbHeight={20}
bbWidth={20}
fill="none"
focusable={false}
height={20}
meetOrSlice={0}
Expand All @@ -1007,14 +1011,10 @@ exports[`AttachButton should render a enabled AttachButton 1`] = `
width={20}
>
<RNSVGGroup
fill={
{
"payload": 4278190080,
"type": 0,
}
}
fill={null}
propList={
[
"fill",
"stroke",
"strokeWidth",
]
Expand All @@ -1039,6 +1039,8 @@ exports[`AttachButton should render a enabled AttachButton 1`] = `
[
"stroke",
"strokeWidth",
"strokeLinecap",
"strokeLinejoin",
]
}
stroke={
Expand All @@ -1047,6 +1049,8 @@ exports[`AttachButton should render a enabled AttachButton 1`] = `
"type": 0,
}
}
strokeLinecap={1}
strokeLinejoin={1}
strokeWidth={1.5}
/>
</RNSVGGroup>
Expand Down Expand Up @@ -1508,7 +1512,7 @@ exports[`AttachButton should render a enabled AttachButton 1`] = `
}
strokeLinecap={1}
strokeLinejoin={1}
strokeWidth={1.2}
strokeWidth={1.5}
/>
</RNSVGGroup>
</RNSVGSvgView>
Expand Down Expand Up @@ -1643,6 +1647,7 @@ exports[`AttachButton should render a enabled AttachButton 1`] = `
[
"stroke",
"strokeWidth",
"strokeLinecap",
"strokeLinejoin",
]
}
Expand All @@ -1652,6 +1657,7 @@ exports[`AttachButton should render a enabled AttachButton 1`] = `
"type": 0,
}
}
strokeLinecap={1}
strokeLinejoin={1}
strokeWidth={1.5}
/>
Expand Down Expand Up @@ -1877,6 +1883,7 @@ exports[`AttachButton should render an disabled AttachButton 1`] = `
align="xMidYMid"
bbHeight={20}
bbWidth={20}
fill="none"
focusable={false}
height={20}
meetOrSlice={0}
Expand All @@ -1902,14 +1909,10 @@ exports[`AttachButton should render an disabled AttachButton 1`] = `
width={20}
>
<RNSVGGroup
fill={
{
"payload": 4278190080,
"type": 0,
}
}
fill={null}
propList={
[
"fill",
"stroke",
"strokeWidth",
]
Expand All @@ -1934,6 +1937,8 @@ exports[`AttachButton should render an disabled AttachButton 1`] = `
[
"stroke",
"strokeWidth",
"strokeLinecap",
"strokeLinejoin",
]
}
stroke={
Expand All @@ -1942,6 +1947,8 @@ exports[`AttachButton should render an disabled AttachButton 1`] = `
"type": 0,
}
}
strokeLinecap={1}
strokeLinejoin={1}
strokeWidth={1.5}
/>
</RNSVGGroup>
Expand Down Expand Up @@ -2403,7 +2410,7 @@ exports[`AttachButton should render an disabled AttachButton 1`] = `
}
strokeLinecap={1}
strokeLinejoin={1}
strokeWidth={1.2}
strokeWidth={1.5}
/>
</RNSVGGroup>
</RNSVGSvgView>
Expand Down Expand Up @@ -2538,6 +2545,7 @@ exports[`AttachButton should render an disabled AttachButton 1`] = `
[
"stroke",
"strokeWidth",
"strokeLinecap",
"strokeLinejoin",
]
}
Expand All @@ -2547,6 +2555,7 @@ exports[`AttachButton should render an disabled AttachButton 1`] = `
"type": 0,
}
}
strokeLinecap={1}
strokeLinejoin={1}
strokeWidth={1.5}
/>
Expand Down
8 changes: 6 additions & 2 deletions package/src/components/MessageInput/__tests__/__snapshots__/SendButton.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -603,7 +603,7 @@ exports[`SendButton should render a SendButton 1`] = `
}
strokeLinecap={1}
strokeLinejoin={1}
strokeWidth={1.2}
strokeWidth={1.5}
/>
</RNSVGGroup>
</RNSVGSvgView>
Expand Down Expand Up @@ -738,6 +738,7 @@ exports[`SendButton should render a SendButton 1`] = `
[
"stroke",
"strokeWidth",
"strokeLinecap",
"strokeLinejoin",
]
}
Expand All @@ -747,6 +748,7 @@ exports[`SendButton should render a SendButton 1`] = `
"type": 0,
}
}
strokeLinecap={1}
strokeLinejoin={1}
strokeWidth={1.5}
/>
Expand Down Expand Up @@ -1488,7 +1490,7 @@ exports[`SendButton should render a disabled SendButton 1`] = `
}
strokeLinecap={1}
strokeLinejoin={1}
strokeWidth={1.2}
strokeWidth={1.5}
/>
</RNSVGGroup>
</RNSVGSvgView>
Expand Down Expand Up @@ -1623,6 +1625,7 @@ exports[`SendButton should render a disabled SendButton 1`] = `
[
"stroke",
"strokeWidth",
"strokeLinecap",
"strokeLinejoin",
]
}
Expand All @@ -1632,6 +1635,7 @@ exports[`SendButton should render a disabled SendButton 1`] = `
"type": 0,
}
}
strokeLinecap={1}
strokeLinejoin={1}
strokeWidth={1.5}
/>
Expand Down
8 changes: 4 additions & 4 deletions ...src/components/MessageInput/components/AttachmentPreview/VideoAttachmentUploadPreview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ export const VideoAttachmentMetadataPill = ({

return durationLabel ? (
<View style={styles.durationContainer}>
<Recorder height={12} width={12} pathFill={semantics.textInverse} />
<Recorder height={12} width={12} pathFill={semantics.textOnInverse} />
<Text style={styles.durationText}>{durationLabel}</Text>
</View>
) : null;
Expand All @@ -91,7 +91,7 @@ const useStyles = () => {
},
} = useTheme();

const { badgeBgInverse, textInverse } = semantics;
const { badgeBgInverse, textOnInverse } = semantics;

return useMemo(
() =>
Expand All @@ -111,11 +111,11 @@ const useStyles = () => {
durationText: {
fontSize: primitives.typographyFontSizeXxs,
fontWeight: primitives.typographyFontWeightBold,
color: textInverse,
color: textOnInverse,
marginLeft: primitives.spacingXxs,
...durationText,
},
}),
[badgeBgInverse, textInverse, durationContainer, durationText],
[badgeBgInverse, textOnInverse, durationContainer, durationText],
);
};
4 changes: 2 additions & 2 deletions package/src/components/MessageInput/components/AudioRecorder/AudioRecordingLockIndicator.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { StyleProp, StyleSheet, ViewStyle } from 'react-native';
import Animated, { LinearTransition } from 'react-native-reanimated';

import { useTheme } from '../../../../contexts/themeContext/ThemeContext';
import { ChevronTop } from '../../../../icons/chevron-down';
import { ChevronUp } from '../../../../icons/chevron-up';
import { Lock } from '../../../../icons/lock';
import { Unlock } from '../../../../icons/unlock';
import { AudioRecorderManagerState } from '../../../../state-store/audio-recorder-manager';
Expand Down Expand Up @@ -69,7 +69,7 @@ export const AudioRecordingLockIndicator = ({
<Unlock stroke={semantics.textPrimary} height={20} width={20} {...lockIcon} />
)}
{!micLocked && (
<ChevronTop stroke={semantics.textPrimary} height={20} width={20} {...arrowUpIcon} />
<ChevronUp stroke={semantics.textPrimary} height={20} width={20} {...arrowUpIcon} />
)}
</Animated.View>
);
Expand Down
Loading
Loading