Skip to content

Update dependency pem to v23 #14007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
renovate-bot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update dependency pem to v23 #14007

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion kms/attestations/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cryptography==45.0.1
pem==21.2.0; python_version < '3.8'
pem==23.1.0; python_version < '3.8'
pem==23.1.0; python_version > '3.7'
Comment on lines +2 to 3
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These two lines are now redundant and can be simplified. More importantly, the condition python_version < '3.8' is problematic with pem==23.1.0 because this version of pem dropped support for Python versions older than 3.7. This would cause installation to fail on Python 3.6, for example.

Since both lines now specify the same version of pem, they can be combined into a single requirement without any version specifiers. pip will handle Python version compatibility based on the package metadata, which is the standard practice.

pem==23.1.0

requests==2.31.0