Harden Trivy verification flow#38
Merged
Merged
Conversation
The release build was failing early in Trivy verification because the release tag, checksum validation, and install path were spread across multiple ad hoc checks. Pin the Trivy release through the repo version file, verify the pinned checksums through shared helper scripts, and make the container install path consume the same validated asset metadata as the host-side checks. Signed-off-by: Adilhusain Shaikh <Adilhusain.Shaikh@ibm.com>
adilhusain-s
requested review from
anup-kodlekere,
mtarsel and
rahulssv-ibm
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The release build was failing in the Trivy verification path before the Python build could proceed. The Trivy version pin, checksum validation, and install logic were split across multiple places, which made failures harder to reason about and update.
What changed
.trivyversionas the repository source of truth for the pinned Trivy release.scripts/verify-trivy.shto verify the requested release tag and the pinned checksums.scripts/update-trivy-checksums.shto refresh the checksum file from the upstream Trivy release.python-versions/install-trivy.sh.python-versions/trivy-assets.sh.Makefile,python-versions/Dockerfile, and the reusable build workflow to use the new verification/install flow.Why this shape
This keeps the Trivy pin, verification, and install path aligned so the same pinned metadata is used both on the host and inside the Docker build.
Validation
actionlint.