Resolve upstream Python build tag#40
Open
adilhusain-s wants to merge 1 commit into
Open
Conversation
The build was checking out an older actions/python-versions snapshot while building newer Python releases such as 3.14.5. Derive ACTIONS_PYTHON_VERSIONS from the requested PYTHON_VERSION by querying upstream release metadata on the host before the Docker build starts so the correct upstream source snapshot is used. Signed-off-by: Adilhusain Shaikh <Adilhusain.Shaikh@ibm.com>
adilhusain-s
requested review from
anup-kodlekere,
mtarsel and
rahulssv-ibm
as code owners
Member
|
theres a merge conflict here in the Dockerfile and I'm not sure why the python version changes from 3.14.5 to 3.13.3 @adilhusain-s |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
When
PYTHON_VERSIONmoved forward, the build could still keep using an older,manually pinned
ACTIONS_PYTHON_VERSIONSvalue. In practice, that meant arelease such as
3.14.5could still build from the wrongactions/python-versionssnapshot.As a result, the release build was not guaranteed to use the upstream snapshot
that actually matched the Python version we were trying to publish.
What changed
scripts/resolve-upstream-tag.shto query the upstreamactions/python-versionsrelease metadata and resolve the matching source tag for a requested Python version.MakefilesoACTIONS_PYTHON_VERSIONSis derived fromPYTHON_VERSIONon the host before the Docker build starts, while still allowing an explicit override when needed.python-versions/Dockerfilewith the requested release line.Why this shape
This keeps upstream snapshot selection tied to the requested Python version
instead of depending on a separately maintained tag value.
Validation
scripts/resolve-upstream-tag.sh.3.14.5and confirmed it resolved the expected upstream tag.